From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA017C433E0 for ; Tue, 9 Feb 2021 10:57:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6CA3F64E26 for ; Tue, 9 Feb 2021 10:57:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CA3F64E26 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D776A6B0071; Tue, 9 Feb 2021 05:57:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D284D6B0072; Tue, 9 Feb 2021 05:57:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C17116B0073; Tue, 9 Feb 2021 05:57:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id ABF876B0071 for ; Tue, 9 Feb 2021 05:57:30 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7C224A8C3 for ; Tue, 9 Feb 2021 10:57:30 +0000 (UTC) X-FDA: 77798428260.16.shade32_06167a127606 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 5D47E100E690B for ; Tue, 9 Feb 2021 10:57:30 +0000 (UTC) X-HE-Tag: shade32_06167a127606 X-Filterd-Recvd-Size: 4223 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 10:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612868249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kK2ClUw3Cdk/dZ7XyshGuNhYtTCXK+mZDDdWQTvzzq4=; b=JiXA7FJcGduQn1si6xCRS145YZE4yOR9sU9OPMQuDratz+BD0bP7AK58kJQFDTvacHKgzO wMf/JmE/cUa5j2GyhZw0wE+6oEthIj+E0KnMvJffbwdt/h+IhWSCmSXHc2RNxJ+ULVqGKz J4203xotX487jAT/Naoys4O38WXZdhQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-459-e56SiWe7OLG7HO4suxdo-A-1; Tue, 09 Feb 2021 05:57:25 -0500 X-MC-Unique: e56SiWe7OLG7HO4suxdo-A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 062B0803F48; Tue, 9 Feb 2021 10:57:22 +0000 (UTC) Received: from [10.36.113.141] (ovpn-113-141.ams2.redhat.com [10.36.113.141]) by smtp.corp.redhat.com (Postfix) with ESMTP id A070110016F8; Tue, 9 Feb 2021 10:57:17 +0000 (UTC) Subject: Re: [PATCH v4 1/3] mm, slub: use pGp to print page flags To: Yafang Shao , willy@infradead.org, andriy.shevchenko@linux.intel.com, linmiaohe@huawei.com, vbabka@suse.cz, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, joe@perches.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210209105613.42747-1-laoar.shao@gmail.com> <20210209105613.42747-2-laoar.shao@gmail.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Tue, 9 Feb 2021 11:57:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210209105613.42747-2-laoar.shao@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.02.21 11:56, Yafang Shao wrote: > As pGp has been already introduced in printk, we'd better use it to make > the output human readable. > > Before this change, the output is, > [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200 > > While after this change, the output is, > [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) > > Signed-off-by: Yafang Shao > Reviewed-by: David Hildenbrand > Reviewed-by: Vlastimil Babka > Acked-by: David Rientjes > Acked-by: Christoph Lameter > Reviewed-by: Matthew Wilcox (Oracle) > Reviewed-by: Miaohe Lin > --- > mm/slub.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 34dcc09e2ec9..87ff086e68a4 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -638,8 +638,9 @@ void print_tracking(struct kmem_cache *s, void *object) > > static void print_page_info(struct page *page) > { > - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n", > - page, page->objects, page->inuse, page->freelist, page->flags); > + pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", > + page, page->objects, page->inuse, page->freelist, > + page->flags, &page->flags); > > } > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb