From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DFD7C369AB for ; Thu, 24 Apr 2025 15:03:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B59F36B00AA; Thu, 24 Apr 2025 11:03:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B08776B00B9; Thu, 24 Apr 2025 11:03:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 980606B00BA; Thu, 24 Apr 2025 11:03:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7A9E46B00AA for ; Thu, 24 Apr 2025 11:03:56 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4FC0F5D569 for ; Thu, 24 Apr 2025 15:03:57 +0000 (UTC) X-FDA: 83369257314.24.25F7874 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf04.hostedemail.com (Postfix) with ESMTP id 401C140012 for ; Thu, 24 Apr 2025 15:03:55 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gltzJCuQ; spf=pass (imf04.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745507035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5chFS9OMORzLKORouVhOFOBJ5V69Jo/Whb7Bt9/v68A=; b=FurBKphPbapSDpBcj6IeuqVUDMGCEBZVi3d1Tj+D/YO2XYgJ9oK/fFcnQVjQwekyh7eYlZ rsm7A9X6UtRdIFODMnoKNewnnUX0hBYSATlxbe7erLyAKhjqAUHvCmXYyWqYrOC2QbHnrN xKOQt6xtmlTbZMKDjU7BzR2hA4xCLLA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gltzJCuQ; spf=pass (imf04.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745507035; a=rsa-sha256; cv=none; b=H0XDLC2MdzMWtbxXs9EEjNhrzX7p/jnLL1XJhvATTAJxlA6dcPT9hVDs2vRysgGDq2GmI5 1wMDS6gEptbh+bllQBGsVt3qFmQSLW4Kr96rqzLJRf0oBUEJ9ct/qYf6gZzZTu4+YU9gJs gsaUruRH8O/faiUuuGgFg0og41mxCiE= Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ac34257295dso195140366b.2 for ; Thu, 24 Apr 2025 08:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745507034; x=1746111834; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5chFS9OMORzLKORouVhOFOBJ5V69Jo/Whb7Bt9/v68A=; b=gltzJCuQgQDB6GqT2YqM1iGzjSrISMjeyyJKbitT+D75DNN4TyUezKsDQ1xkqfqfMQ 7PetDHgTvWr1QtVUOKx2/ILyqDAATnEmiCRt/ZlEtpf2RfK9mqtUaGU/a6EznFA1wHy0 P8D4AG+cR+lCInLmq+fXVuOLzJd/4UUQkH+Js6vkULYljydCwKvraORBzi09ckl9d1G3 O+Kq74nz5ZjqB7Fn//tBnK0gjDTYAN6nl4ImsrYNWRTZZtNS21DYbvd2kzaWQwBsiGei II8snFXTyOTUuT4VYe2LcTIICxNhaKuMOzV20Mo5X+CxWy5drpvpDpKfP/QiBEXFh+qB 6LXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745507034; x=1746111834; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5chFS9OMORzLKORouVhOFOBJ5V69Jo/Whb7Bt9/v68A=; b=OHAk9bq/FimNFrAtv9HU2GAofTXwOyi37EXW+0EK/VU3l8BbryouP+VKk4N7539NCE S7M/0XJcPGD8IYZzgrEBo8uN6707GSLiWdEO+i2PUpxmyILuuU8VKsWzezjZqm3oQcey 2MumHJNtfvCJkx2pHuYl6CKGz8TB9khoHMp59uh5mR2xI8wJJIknENw2Yvti1R+F5z8d X/rhJSWyrKCfgtMQ9g7bTwHyXzOgolKarBSMHOMh5+SDOwz8a8BV+ljse1/himHWSfvw rg1zt0qOxyWsPg12JR+ZC9v/6ogDSJboUS/7cVOn08Lp6tyEF0Wz19adRHpwjLn++P+y Tbzw== X-Forwarded-Encrypted: i=1; AJvYcCVEHbkRYxkn3YJTVAyi8i6Ffb6QvDb2nFfN6V/Mpv6Je/q1x4ScXGW+xn4Nps8EeNo2KazLENwoNQ==@kvack.org X-Gm-Message-State: AOJu0Yw80qAOrKUMF3oaCV4ZAgortlat6rPqkiNYaANs2VYG155V/b8a NBvytbQotOZ3qcnbZJP/bvttjX2dGkYB1q0yRTHACUr6QeouMntm74zF0Q== X-Gm-Gg: ASbGncvyljRc6MwffLXvqYSl7Uq5K5IeXEoVp03P5p6bPYDR4UtO1nK/4joFeYPU6gb 26r1frwOf5aSetnHtMzlUrKcKrDafnJViTfCtrNBHsLfCOccxiQVi6Z4YrUKqQmwJleLgeYLIij sOYdh/GSfx64XDiCV21dyxabVgFOXIQzRohVPRYxSC9+FdZV4K+w9L1h58t49MAvcNl5DMeB6Fs jvrSTxtC0THSx95i4hXpPvztrKvwwIDpuJnbRChqEKFgZIZTjqQA/WWbl2Ry7aeHzNQ+4ZUqddB T/fA4UWom2+ZSMBMX/Kmr+dwuR2WfJbzwNVGDAJQoQWo2GbNQ7jW+lmQgr+779shEgWGFXAWk8d xUomlSn6a4e7y X-Google-Smtp-Source: AGHT+IEco8mssxoawhcAhtRNlPLqlID5zUq0vN72hKI33kZSrx4fa3BkNkpoQ0Lld1zoeiMfeTtTrw== X-Received: by 2002:a17:907:3c93:b0:ac2:9093:6856 with SMTP id a640c23a62f3a-ace573a6e8cmr320455066b.54.1745507033210; Thu, 24 Apr 2025 08:03:53 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:1cca:202:d408:3819? ([2620:10d:c092:500::5:5042]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace59c260d2sm120633666b.145.2025.04.24.08.03.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 08:03:51 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 16:03:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/12] Documentation: mm: update the admin guide for mTHP collapse To: Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, david@redhat.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, ryan.roberts@arm.com, willy@infradead.org, peterx@redhat.com, ziy@nvidia.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org References: <20250417000238.74567-1-npache@redhat.com> <20250417000238.74567-13-npache@redhat.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20250417000238.74567-13-npache@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: jsaqy4fbomuz7dhjr8ea69h7qt9fmikq X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 401C140012 X-Rspam-User: X-HE-Tag: 1745507035-151984 X-HE-Meta: U2FsdGVkX18x5lmI3WlT0AaMcT0ya0PCw0H4qjfYiepXDRQnRGI+XSMxYoii5kmlan6KlIeEx/5zITWFSWOytQ11uRYSe88KsE/XAk1kwmi1w1Ydq0j+KwniSAqnLfnUqjfN8sFXVIw5rDrYYSweEm4FfHzDN4tawU/JWcvBKqomVg2qpzHCc8VKNdP6sJifWyCq5kEC/Msb91VETOIKUM5gWvHM47ZAGHqIH4qpsuUt7JQQIeh62m7CPzMhIUgzAEPxwJ8B8paiVGkjOiyJVRG6KPaEyd9+UXV2R6L79BKFUWxTmUaoQXBvnEuX/Y5DOhwJzBhJfrKzrNx0VyrlDSOQRK6zjP1BM4fektY+/mHMkEO6cm+4ydPQnRrqHvmZEiVn/K5Aj5qNXN0C0l9mSkeIF7MVQ/4NB5ffyOtt6ISCreaoPLbDAUEXlR5ebjS5LC3hvYlOqLNFb2tYxdbnzQ15CWT15lNX2sa/OJeVl4uiz3jGRXKS6plHrGTFYUS/S0I02M3346INAMzLKVhGT1URlSKXVMUvk2XSCX4RXPUPz2sLbyN5x3nV1tpsw5p+jJL3BEPy8SZY+yRpPBjCEyhC3xeezHX3LwTlXMSe1tXNqHC+ckxpURoEfnk3OeCj6DAmEJnCTCs7wLDMgG1CSZ2LY/iObhksePL7pw4kGSu06lvReDca/QO7b1BrxaxzM6DoAvdkEWmGhhQX1HRv8syz0XEHGbfKFtFxN76SRuwMbiUoCyvJgqCMea+he/6hm9pi1PLl3GQFnHUQ/omXQRpDD7PfmPPq7Sujf2eFdBHtBSZDQVGCYSh5I4U10L6/mHT+FMN6gVSdHYBxGv9GTKmki+BbuuALHR2RFt1Gas+xVF5SGLZ2/WTP0uVjyl2pHjzYurRtqWtmg+dSFran4V+PWMCydBaUZvF/Ht8+yTqEwlFeXqph84MRfl+NFqUdtUJp9QEUl7bUHaT+M9C X5OSKRbF 7IO3ZpWKlDTFku8IqSMmCEUd+g43FTKSWV4Yg5F71s0s7zenGNo7kbMztPkSRRoQcIV0DX3Sz3yGdNw4yjaoq7nsR1thE/E0urq5HoZ4J7NTLuk0C9j0AuMAEXy8nrGrUsy//I+SDD9GBXawQHCDj9++E3d0kptQRO7MPr8D3wxL4BohxUKAx3gz+KjH4J7bLy4UQ1YURZeAc3F2BOAPzO0LAB9Q4c3i7xp1lLPZYcxQbIi3nj7a/wEBRgL/McjP3Vi9hdGD61Se1yZ4L/k5wZHuG6R5O3SV/S1BjLCdmO+sJHnzfBEstdjkaXGRRFG0uHtUzRxF1KFmqaGJAlFIE15QiJyP/8+VfLlrQugobx35vTvxkzDxdDuEfBWqEKfM0wqXQUYTDk2M8SQ6dkvuVCpvnW0vvxG9LS8r5da5s1ODWrsevxLSrux7S5oHpAqhQXK0rR7ybS1IALC43DMkmZuhkao4BWNPxrovwZdVs8IpGnCYdZ53pLcfEF+aJLKDzQZ0bIIYulR1VTogMbjjHTdty0vr5+D3Yvte62aE0Iwkhj57oEnwCXqGf8r94x73SjXsD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17/04/2025 01:02, Nico Pache wrote: > Now that we can collapse to mTHPs lets update the admin guide to > reflect these changes and provide proper guidence on how to utilize it. > > Signed-off-by: Nico Pache > --- > Documentation/admin-guide/mm/transhuge.rst | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst > index dff8d5985f0f..06814e05e1d5 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -63,7 +63,7 @@ often. > THP can be enabled system wide or restricted to certain tasks or even > memory ranges inside task's address space. Unless THP is completely > disabled, there is ``khugepaged`` daemon that scans memory and > -collapses sequences of basic pages into PMD-sized huge pages. > +collapses sequences of basic pages into huge pages. > > The THP behaviour is controlled via :ref:`sysfs ` > interface and using madvise(2) and prctl(2) system calls. > @@ -144,6 +144,14 @@ hugepage sizes have enabled="never". If enabling multiple hugepage > sizes, the kernel will select the most appropriate enabled size for a > given allocation. > > +khugepaged uses max_ptes_none scaled to the order of the enabled mTHP size to > +determine collapses. When using mTHPs it's recommended to set max_ptes_none > +low-- ideally less than HPAGE_PMD_NR / 2 (255 on 4k page size). This will > +prevent undesired "creep" behavior that leads to continuously collapsing to a > +larger mTHP size. max_ptes_shared and max_ptes_swap have no effect when > +collapsing to a mTHP, and mTHP collapse will fail on shared or swapped out > +pages. > + Hi Nico, Could you add a bit more explanation of the creep behaviour here in documentation. I remember you explained in one of the earlier versions that if more than half of the collapsed mTHP is zero-filled, it for some reason becomes eligible for collapsing to larger order, but if less than half is zero-filled its not eligible? I cant exactly remember what the reason was :) Would be good to have it documented more if possible. Thanks > It's also possible to limit defrag efforts in the VM to generate > anonymous hugepages in case they're not immediately free to madvise > regions or to never try to defrag memory and simply fallback to regular