From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97802C021AA for ; Wed, 19 Feb 2025 01:23:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C4922801C6; Tue, 18 Feb 2025 20:23:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 074E92801BB; Tue, 18 Feb 2025 20:23:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA53B2801C6; Tue, 18 Feb 2025 20:23:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CCA942801BB for ; Tue, 18 Feb 2025 20:23:24 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 60DB9808F2 for ; Wed, 19 Feb 2025 01:23:24 +0000 (UTC) X-FDA: 83134946328.05.A912AB5 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 5141E14000C for ; Wed, 19 Feb 2025 01:23:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=iEqpCihA; spf=pass (imf23.hostedemail.com: domain of jefflexu@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=jefflexu@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739928202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RKKB/bnDibpzm10Y361PXYXPsCzqwGtf81SgiyAceQo=; b=lJtFxv3pik/ahc1VKY+FRSAJ3BvzxW4i2xtjw9ORoP1g/g0xyrUIWID6JUH4gtWMl/HdA+ lwSplxwvdzlg4FgBsEgn9DfcgTLyALVi8Y77sLxFU0/KWBz79USMIQpnLYF5DQYyaoMtAu aYasAvpoy/a2wGDnE67NXsON7ELC4R0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=iEqpCihA; spf=pass (imf23.hostedemail.com: domain of jefflexu@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=jefflexu@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739928202; a=rsa-sha256; cv=none; b=BvrZiI4PFJ6dguDWDsOdaltZukN+gI07eY5uHY3kX0G6LOTUhzF1pCO8vQ8Owc+mtXfmfD 0kQ0jUlwehd4L9D37Q4lJaBEJPwYp9VeqtTwqUaJ4MUSSa9p/JSOHT+BLu/NzejArDAFdt hjubaRl9rxrJHDXk4CoqlKgyHf4rNDc= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1739928198; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=RKKB/bnDibpzm10Y361PXYXPsCzqwGtf81SgiyAceQo=; b=iEqpCihAxVfsv3OucWVKjxHPruLw2VpHvfSpx3ip7+h0V5hmzo3dCHLqcJXgQUgX7jPRrQYJCnnHgeWGfBYiubmEILz00UHNCJW94nS0iurCA3Lvse+Px1c7NxBlwvr8dIqyn2eMpYXYPEA5L8vy6INoqAmh5byRvTIC/G9h+PM= Received: from 30.221.145.137(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0WPnAzoo_1739928196 cluster:ay36) by smtp.aliyun-inc.com; Wed, 19 Feb 2025 09:23:16 +0800 Message-ID: Date: Wed, 19 Feb 2025 09:23:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/truncate: don't skip dirty page in folio_unmap_invalidate() To: "Kirill A. Shutemov" , Jens Axboe Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, brauner@kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk References: <20250218120209.88093-1-jefflexu@linux.alibaba.com> <20250218120209.88093-3-jefflexu@linux.alibaba.com> Content-Language: en-US From: Jingbo Xu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 5141E14000C X-Stat-Signature: 1fbmxrpzqpn43zh5e4ii5z4ehamct4jp X-Rspamd-Server: rspam03 X-HE-Tag: 1739928200-544915 X-HE-Meta: U2FsdGVkX1+NCRQ9w5pn4tilmRHzjd4gpA+7XQPHwVPDGHyOlugP52igGu98TO6JdYzfyr+hwV6F7Q7fWO6ySSaRtwtsPUQWdnOHrisLGFzZIIsjShKEDBdJACICl58VAew7GyqhLSRppRgN3svUtB49xbQUHIvn5bnjni3Dt/f7tUngQKDChP9i0R1OlIjJwDtIQakmDKmoosEFiLZay/S0D1FySoysid99N5vqaxobI/fgRtaNzK+4nN5eKHA7I9cvi67yGY2rB8MHuZRqSYktNBd4IVk3y5zeH85I0TQFB24UeAmL4qH01vMQwJ/8+Y+7twh+pz8vYio+H4GsWb70p00Ck/me7JsOtC8n8WHAVaX+1MCuRvM+rpS/7arXXqMZmyYkkG9kViuqt/titKu8Fcr/k/sryrXmSBgu911Nkath3N6X1iyTHKiWtTxpFxOGkY1xszi1xuQUVWNm3yTVRhrqddEWze5ajT+XXNQijbAQMdxKFehTVJz/jJV3GJW/AhD0W9KH2iAuuCdD5S7hePXvSNO4rsKZCvQwAxVwQLGsbtjsHKeCC1j6Yd5nwVsAnLqhTaQh758UOcJgxjstAZo/p4MQVf0TQRgYmIDFFHndf924c6O5fYHhhueUhmhd0Cqmlrc+1j527g/T6I4eVZv3HUhM2/OEI8E+YxAsdArhF9f189NGeYYdzfQd5BpfeRQsEEX5ff2mpyoCoYCJWifonofV0X0OZ5FAqFrxQOD8iMhj9TmkOa1sxRcJtoxqTCBsnlKWNjUoOs0rUTFBKA7klJQltfP1eBRomZwajDhRsU+w6aq3XJpdJaV33jkB8Qj3Qz8/OOh7XyUDvFIeQCOEbfV+VCDLxP+auSE8sOHueZ+99VOi0zb+4KGEgPBFxWZhi0I+VJP++DaJK4Ph6a9cxp1Npp/YvYBcUNlxFQiML1HRWb6gJi7eG36EYE/sXeT3/1HgpeZodcL Q4eC3DZX SKmZ5asU0P1rcEWvmSUoT4zaKkq0aKbBP0kRgrfQiXzhNSgqlBIhnBoolw82MBAWWkAzoswXcymlX4X9EGWNCUx1S6eka3jt9SdUKEjPJtQ3rzHqkekJYPolEgpX+yA0VskjfWrs6xU2wfctlcuOBNkAb+OlxFmRHuRDl2dkbQgJ+pSm22Us0rR3hGTtsTblgl9WUU2Tae0Z955BJMfHyWNhmxyP7RglhmKncSzNjtHena0D3X15ULKtkkSDNJC7Xg/NVg4LiiyRwfoRJ5cVVXLrX3eBVqDGTjT1I6vMXJy8A61Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.007036, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/18/25 8:32 PM, Kirill A. Shutemov wrote: > On Tue, Feb 18, 2025 at 08:02:09PM +0800, Jingbo Xu wrote: >> ... otherwise this is a behavior change for the previous callers of >> invalidate_complete_folio2(), e.g. the page invalidation routine. > > Hm. Shouldn't the check be moved to caller of the helper in mm/filemap.c? > > Otherwise we would drop pages without writing them back. And lose user's > data. > IMHO this check is not needed as the following folio_launder() called inside folio_unmap_invalidate() will write back the dirty page. Hi Jens, What do you think about it? -- Thanks, Jingbo