From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DDDDE77197 for ; Thu, 9 Jan 2025 13:14:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB3D96B007B; Thu, 9 Jan 2025 08:14:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3BD06B0082; Thu, 9 Jan 2025 08:14:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A66DF6B0083; Thu, 9 Jan 2025 08:14:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 849186B007B for ; Thu, 9 Jan 2025 08:14:03 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2FC2445BBC for ; Thu, 9 Jan 2025 13:14:03 +0000 (UTC) X-FDA: 82987956366.20.2FD47BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id A34E91C000D for ; Thu, 9 Jan 2025 13:14:00 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GWL8aPlP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736428440; a=rsa-sha256; cv=none; b=Rw6loEsVDQiHv1lu/Fh+YfgMKhl5jKZWTr1QmWGjiWo1VBKoYdfgVztKbW6Hn3oSIZBHGN ZHLGVw1KZuyBEw50ktjH5Ou/qii3SA6SXA7/+7TnPbjCERsEdSHRdzDl13zPI9APisUe52 OF66vSEuVfZg2AZGt8/qmCGWtiLmemo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GWL8aPlP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736428440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l0foGLBWMT6OCb+sFhOcxf5nD66mdXUC8R9HfpTxIy0=; b=m41hSWj5+ylNi4JCYy56/ZCnqD6QcSyOMVRIKw4dU03suFUvCf8vnLV2d6O9iICCNUpqYI eOMjhshBcYyUjHNNyRMTfDjIpGVYHkgCfhGYC73bNLLqbLd9qPEqjMg8KSrt8xR2rOj2LZ 6YEh+BSTymAFyga4JT0/ETW96+imzMM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736428439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=l0foGLBWMT6OCb+sFhOcxf5nD66mdXUC8R9HfpTxIy0=; b=GWL8aPlPm9bCIsgvJPOrxyT7eHn7UoZmpSGqZ1Ij1+j1aPoTsOpUW24tKiSNiYvDh+h2Ta hZfpKb0DnAkKZ19gjejQxoEl/H2pgQzM7TpWADwVRcQ6T8bgiP7NY+xfUH8qb+aqc/as0K bvUIGQN6jI+gNtmlHNw2GByOcFbKY7g= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-x1lbM0mRPEi2MgLbm90BWA-1; Thu, 09 Jan 2025 08:13:58 -0500 X-MC-Unique: x1lbM0mRPEi2MgLbm90BWA-1 X-Mimecast-MFC-AGG-ID: x1lbM0mRPEi2MgLbm90BWA Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3862e986d17so377455f8f.3 for ; Thu, 09 Jan 2025 05:13:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736428437; x=1737033237; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=l0foGLBWMT6OCb+sFhOcxf5nD66mdXUC8R9HfpTxIy0=; b=dWk7Rc+LfhNwzIPHFzuksFUGO7VJBzD5AZ8lOPAMxyLxZ+WiwIq45/CD0Yv3IroL8B 7rZSTG3giX8Jn9qRNOLpZ4l9ZqNq4EFI/kJRDYXmNvZOpOnxoBtEcQlymxnnosbETiLG vS2eo1RiCXRWOz5/aw43KM/9N9cnmbxD5Pmzofe9XdwKjiS9V3GkAJj+HHNBiJCvEaxt RSBf1WI7izJgTGhwH9Lpd7gzQ3KiwQpbxS8bH7/4VtSHWdOxtCkuMROsx7k7t/cFEMTg FLqi0nJrHHXk86aU5PFN2v7kfAp/JEOn5qgPN6+WAqGrjDi+Y3KhcpSoxy73dnHoTaNt voWg== X-Forwarded-Encrypted: i=1; AJvYcCXCexDShB9FDTIhp6Ntqsiprhrr6/n0cP8bodJYPOmCmW80qR75l17Ox69HAyoiVnYLY5Fn06GARg==@kvack.org X-Gm-Message-State: AOJu0YzXiQvpS+X8xAOXToz96/e4eEDzB/o8NPbXtL4Y1ox0UyUGkjUW RTw1dXFRUWXwPHxbhSSlmoE6TTaCdig7t2t1PB1SXpEa8nY04piA51llW5UtB0ncRb/uO6EdSu7 cMelIP6J8sCIbo/wVuW8X7E4ThPfp3TnN+LBNypzKvt9NKj8H X-Gm-Gg: ASbGncsu9Su8hgtkNDkxqME0/qHxfI33B1a/DJ1osCZGRDZ6zDOsqUyYKT8R4kFgGzm PFkj+WerZMUhkeh4F5DAp5gdh+Bh0Lq63aQJP9z9kabVShS5V5aVnCNagJJWBJ69yu7d9mijjeq ykYmfiwCBkxEzNIhTdvAaE6N8mHNGg/zFTd4VhF333r5MfHDPbltOdBzXmRJd+yI6ZisjfEsvac X+d6MaoETx2Giwtg2+iAHO5f0AIdI44/l3YEpOf9dfQ7UExeSJ7gpSV2lEND3h2RM9KkAN3YJnU /B+o/S5AkoJ9cSt7lhkHfsoZ/VFjGvMw2ZyKbCJofOw8bX/NAqWI4idM8qI07phgEQ3QaBna0sw YjWy+Qg== X-Received: by 2002:a5d:648b:0:b0:386:3e3c:ef1 with SMTP id ffacd0b85a97d-38a87312f36mr6395465f8f.35.1736428437327; Thu, 09 Jan 2025 05:13:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHN7ebYRtD5//4iuQNh65Q2fIWi5XlRSwkQ2l03Se6YkvfE7+Vy/Ut+fdfkK5hg53tBNKehmg== X-Received: by 2002:a5d:648b:0:b0:386:3e3c:ef1 with SMTP id ffacd0b85a97d-38a87312f36mr6395435f8f.35.1736428436970; Thu, 09 Jan 2025 05:13:56 -0800 (PST) Received: from ?IPV6:2003:cb:c72e:800:d383:9661:5934:2cfa? (p200300cbc72e0800d383966159342cfa.dip0.t-ipconnect.de. [2003:cb:c72e:800:d383:9661:5934:2cfa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e03f8bsm20591515e9.23.2025.01.09.05.13.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 05:13:55 -0800 (PST) Message-ID: Date: Thu, 9 Jan 2025 14:13:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/memory.c: Add return NUMA_NO_NODE in numa_migrate_check() when folio_nid() and numa_node_id() are the same. To: Donet Tom , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Ritesh Harjani , Baolin Wang , "Aneesh Kumar K . V" , Matthew Wilcox , Zi Yan , Muchun Song References: <20250109064632.898260-1-donettom@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250109064632.898260-1-donettom@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aW5EgrEit-Adm-26rcosuB4IZ8a1VrbnjVxrY9oBQv0_1736428437 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A34E91C000D X-Stat-Signature: k97tzoktx7xroaabupe1hczhi9mjs3jc X-HE-Tag: 1736428440-781688 X-HE-Meta: U2FsdGVkX199t8mIixgbj5GATC4wRXIzvmLub9ldfhAZHVDYMx6PR9qeiATm/p6ylIRDZke+h71mMp3BP2ITlZ46LZDmrtDfbfHdN5dmVMux+pQvt+tzzCdGrcpAYXWDrbN4gmg2uarz7SO700hUo7bL8abSaK99FoYWpDxwao0A3BongfXE5X9/ZdXLCRAKKc5/o1E6dgWPP03TxOWoSd86h7unZVuV4Qylg1nao01CPW/Z82MMRGIXbSnmCXApjvPBp/5hYb10z7DT4sYAPZ3NOpQ68ET0xVE0uc4uZ8inr89qMOGO6ze8uuiWXK5kUuO0sQcbSnbMYhH1erHv379m1/D35wiE6vhbyXrlNidb4ZfIiI0SLaMwuG9AWx6T8CO8/IJzwc7GRFdo+mh1pZP+8GaWdyndqnuGGBN4psjXlWDJUCX6LkbbJ4UhWaMSNR53syfV0uFjJePoWt9Th8rV3Go1hLsltVHXm93sdgb1ERc4DczyIB67b8TnUmQFatNOkzuyBBRW7p9GuuwDEMZLbp/p+khaCEwzQvTqYiv5/rhHgXd22hdZs4L0C3d0xavgBwLyk2OCV/+Xkwnp/1OCLe4eKlAI7mYfEmZIBJgYperYdwldf+q/q8IWC05qAlAxOFzx+tUjPXhyZvSfJjVd9N0u/KFFexcmmDBdFCN/NrZLHdHv68J6oP63rUTnO0subymd8isK2KRO0SLSSbTtWQ3/IUT5MilH2cz/ex1+AJr4iZ51usr3QekA2oQZZ8rQeju8ZELMbST01PaiM59pIBiKlOiD8e4RdaiwYvUKWkgIJPHmw9RM118ui1lpQJ4UKpHpS4C1BEBzbPtwGITe5/VjnsBhcdyLtLTV49PoTNWYOtR2j4NOsTXnVFFuDmpInvWkGJgr1imkkhI650bxdYBd5GpfWg1McwSLBcNCacRk7U2PTgZTB2+yVovoEgyTqHXK6YTKjtPpl0v ceBIjmwg y294ErPt6P6jA7AxAQRDpkij9IIfNqfZOj7xu1vo115NidVIXabYHCkZi1I6JDcEfbN517xRQDu5j8pSTeCBKvr956479rl7O0OYXzk9sz2aXuUdkL9DEYOtkXlOpI0XTK5H0UjHlAlNREfPwMQamGnbTmbV2CVbsUr9A76FTA4TQZa7w68VYffYJOgqHgiJAqrnfiO1FeT+dKe6E6TuFRql2Z3v8asppcOiqvjoEa1RH7dSK48B1t4g4KlfKnhYA47UTgPjLiz4UyIFOciJTSyUwmLx0yOjzWVwKDSguio5wGjnCyYC7hgZEXu4GyAkGo9PoS8hmUYctyXZUPiK9IwcdiswZ8x4joU7nrUVwFABj6uDczEBysRd3Mf/34ypt9YD48TWXSDpS5h9Qu+qZ1+wp0EzlGYnCo+RbgL/L7aYpKm55qzo7SxCmC4EXWu4hOONDTKTz0BM3+NSkSCnaULPdp1hbrjF0QiiIrF66coMncKE+w/9O3Xt/qIoVNXHObXiP6UvxfG5oD2Jw2lC8nieYEwrxYVWbkdLu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.01.25 07:46, Donet Tom wrote: > If the folio_nid() and numa_node_id() are the same, it indicates > that the folio is already on the same node as the process. In > this case, there's no need to migrate the pages. > > This patch adds return NUMA_NO_NODE in numa_migrate_check() when > the folio_nid() and numa_node_id() match, preventing the function > from executing the remaining code unnecessarily. > > Signed-off-by: Donet Tom > --- > mm/memory.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/memory.c b/mm/memory.c > index 398c031be9ba..dfd89ff7f639 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5509,6 +5509,7 @@ int numa_migrate_check(struct folio *folio, struct vm_fault *vmf, > if (folio_nid(folio) == numa_node_id()) { > count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL); > *flags |= TNF_FAULT_LOCAL; > + return NUMA_NO_NODE; Doesn't this just mean that it is a local fault, but not necessarily that we don't want to migrate that folio? mpol_misplaced states: "check whether current folio node is valid in policy" Could we have a different policy set that does not indicate the local node as the target node? Note how mpol_misplaced() obtains the target node to the do int curnid = folio_nid(folio); ... int polnid = NUMA_NO_NODE; int ret = NUMA_NO_NODE ... detect polnid if (curnid != polnid) ret = polnid; ... return ret; So mpol_misplaced() will return "NUMA_NO_NODE" if already on the correct target node. -- Cheers, David / dhildenb