From: yangerkun <yangerkun@huawei.com>
To: Chuck Lever III <chuck.lever@oracle.com>,
Christoph Hellwig <hch@infradead.org>
Cc: "zlang@kernel.org" <zlang@kernel.org>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
"yoyang@redhat.com" <yoyang@redhat.com>
Subject: Re: [PATCH v2 2/2] generic/732: don't run it on tmpfs
Date: Mon, 29 Jul 2024 22:28:26 +0800 [thread overview]
Message-ID: <b2096645-6b24-70c2-aea0-361fc5984d5e@huawei.com> (raw)
In-Reply-To: <D332E074-6760-4EC1-B3C6-437C1C52229C@oracle.com>
在 2024/7/29 22:21, Chuck Lever III 写道:
>
>
>> On Jul 29, 2024, at 10:16 AM, Christoph Hellwig <hch@infradead.org> wrote:
>>
>> Looks good:
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>
>
> I would prefer this test continue to run on tmpfs.
>
> tmpfs is broken, and needs to be fixed. If the generic/732
> failure is an issue, then add it to the expunge list --
> it found a real bug, that, once fixed, we don't want to
> reappear.
The reason why I thinks it should not run for tmpfs is that the same
mount options won't share the same sb. I prefer it's a expected behavior...
>
>
> --
> Chuck Lever
>
>
next prev parent reply other threads:[~2024-07-29 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 8:47 [PATCH v2 1/2] generic/732: remove unused code Yang Erkun
2024-07-29 8:47 ` [PATCH v2 2/2] generic/732: don't run it on tmpfs Yang Erkun
2024-07-29 14:16 ` Christoph Hellwig
2024-07-29 14:21 ` Chuck Lever III
2024-07-29 14:24 ` Chuck Lever III
2024-07-29 14:30 ` yangerkun
2024-07-29 14:28 ` yangerkun [this message]
2024-07-29 14:16 ` [PATCH v2 1/2] generic/732: remove unused code Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2096645-6b24-70c2-aea0-361fc5984d5e@huawei.com \
--to=yangerkun@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=chuck.lever@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=yoyang@redhat.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox