linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Michal Hocko <mhocko@suse.com>, Wenchao Hao <haowenchao22@gmail.com>
Cc: Kiryl Shutsemau <kirill@shutemov.name>,
	Andrew Morton <akpm@linux-foundation.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	"Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Add AnonZero accounting for zero-filled anonymous pages
Date: Mon, 16 Feb 2026 17:56:12 +0100	[thread overview]
Message-ID: <b20695bb-227a-4e00-a36d-9fc389aa1ab6@kernel.org> (raw)
In-Reply-To: <aZNI9mo34vs27DXz@tiehlicka>

On 2/16/26 17:42, Michal Hocko wrote:
> On Mon 16-02-26 23:59:50, Wenchao Hao wrote:
>> On Mon, Feb 16, 2026 at 7:58 PM Kiryl Shutsemau <kirill@shutemov.name> wrote:
>>>
>>>
>>> One users want the stat and all users on the machine pay the price?
>>> That's a poor trade off.
>>>
>>> In general, smaps scales poorly. It collects a lot of stats and most of
>>> them are ignored by user. We need something like statx(2) where user can
>>> declare what he is interested in, so kernel won't waste cycles.
>>>
>>
>> I initially considered two approaches:
>>
>> First, exposing the needed information via smaps. This does incur some
>> performance cost but is the simplest to implement. The new feature can be
>> dynamically toggled via a command-line parameter. When disabled, the
>> overhead is negligible—only a minor if check, which is insignificant compared
>> to the full smaps cost.
> 
> You are comparing content of all anon pages, aren't you? Depending on
> the content this can add a lot of overhead.
> 
>> Second, adding a new system call or extending madvise with a new command
>> like MADV_GET_ZEROANON. Userspace tools can then use it to measure
>> memory waste from zero-filled anonymous huge pages.
> 
> MADV_GET_ZEROPAGE would make more sense to me. But a more fundamental
> question is whether this metric is really what you want long term.
> Kernel can do all sorts of optimizations behind userspace back - e.g.
> map shared zero page - so just learning that a process has a lot of
> pages filled up with zeroes doesn't tell you all that much. Or does it?

If a sysadmin wants to see where THP hurt (zero-filled pages), surely 
MADV_GET_ZEROPAGE is the wrong (ugly) interface.

All we want are per-process stats. What am I missing?


KSM could deduplicate them, the deferred shrinker could remove them. 
Unless both mechanisms are not desired or are ineffective for another 
reason (e.g., page pinning).

-- 
Cheers,

David


  reply	other threads:[~2026-02-16 16:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14  8:45 Wenchao Hao
2026-02-16 11:34 ` Kiryl Shutsemau
2026-02-16 11:45   ` David Hildenbrand (Arm)
2026-02-16 11:58     ` Kiryl Shutsemau
2026-02-16 12:19       ` David Hildenbrand (Arm)
2026-02-16 15:59       ` Wenchao Hao
2026-02-16 16:42         ` Michal Hocko
2026-02-16 16:56           ` David Hildenbrand (Arm) [this message]
2026-02-16 17:10             ` Michal Hocko
2026-02-16 17:17               ` David Hildenbrand (Arm)
2026-02-16 16:54         ` Kiryl Shutsemau
2026-02-16 17:01           ` Matthew Wilcox
2026-02-16 17:10             ` David Hildenbrand (Arm)
2026-02-16 17:18             ` Kiryl Shutsemau
2026-02-16 12:15 ` David Hildenbrand (Arm)
2026-02-16 15:10   ` Wenchao Hao
2026-02-16 15:18     ` David Hildenbrand (Arm)
2026-02-16 14:22 ` Matthew Wilcox
2026-02-16 15:55   ` Wenchao Hao
2026-02-16 17:03 ` Matthew Wilcox
2026-02-17 15:22 ` Wenchao Hao
2026-02-17 20:29   ` David Hildenbrand (Arm)
2026-02-17 21:53     ` Kiryl Shutsemau
2026-02-19  2:11       ` Wenchao Hao
2026-02-18  7:52   ` Michal Hocko
2026-02-19  2:47     ` Wenchao Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b20695bb-227a-4e00-a36d-9fc389aa1ab6@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=haowenchao22@gmail.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox