From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B213C77B6F for ; Mon, 10 Apr 2023 10:09:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A33F928000F; Mon, 10 Apr 2023 06:09:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BD24280002; Mon, 10 Apr 2023 06:09:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 884F928000F; Mon, 10 Apr 2023 06:09:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 75392280002 for ; Mon, 10 Apr 2023 06:09:36 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 369F280BEF for ; Mon, 10 Apr 2023 10:09:36 +0000 (UTC) X-FDA: 80665059552.07.6225ACE Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf09.hostedemail.com (Postfix) with ESMTP id BA88614000E for ; Mon, 10 Apr 2023 10:09:33 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XXgX32mn; spf=pass (imf09.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681121374; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QEmp0lSStdbKqWXzl5gxerQ4TIQzHhey9TWvVEc/6IA=; b=M595CeqhMSDhZ6gpGTKKE9+tyKpIZxVLogNJHthlKsp1MW1Ivuyc4Ek7evyTmRnSPjpbd/ 2tafGoxmBtT583wwfRYAfoz2mFz8BOdS7PMA5hAZc4LysZDNeSn5yN4yIgvxbFjRmpgDe9 1PJFF5W+atbQ4zQy1C2hdhKlj6s2/fQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XXgX32mn; spf=pass (imf09.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681121374; a=rsa-sha256; cv=none; b=vYD7xvxjDeUE4elgdMJQcD50joroNv2yMYOIjO9v82LJFuxZZyBb8mvLB8RvYwgjnyDfrG 1Zu5hgefOfTj2LcG64nYFUzXU52feckh/iJC9hczFrgp6J6g9ypr/SdKlqIwcEEvaE1uOg xfS3bL0kXzx9d2LnMBMcOKYiJsD0wHY= Received: by mail-pj1-f46.google.com with SMTP id nh20-20020a17090b365400b0024496d637e1so9417601pjb.5 for ; Mon, 10 Apr 2023 03:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1681121372; x=1683713372; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=QEmp0lSStdbKqWXzl5gxerQ4TIQzHhey9TWvVEc/6IA=; b=XXgX32mn4y+8njkj3RfhVL9iUkpop22zBOAemvpTl1D/M/SvoWnZLa/htOwBP3cE3J JtjpkY9BXgW19HXfsUuSwDz5uBU5y9nVX+MMNQleYPiSXHIVjz48x7Dz/aoOxD+coEyI 8k82sJGjvfJ4wOBlSA+3HIcPiPJW/Bqnqqq0OA2pojrTf603mZwC5tUVeeVTNAlBQDqI cgPskiC8ffHVJWQZFKclVVl+2HmjYXGXkD9DnwZwmQWoU48qJAad2V+y18HAzdm2x0wB fsa8zOA2YkRtcrHHJJKT6yw86oqbqmI0/gTlxIHUVQOzPWvcwozPev3dIZ33KXrQeR2U Alvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681121372; x=1683713372; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QEmp0lSStdbKqWXzl5gxerQ4TIQzHhey9TWvVEc/6IA=; b=bZKg1eIUWjUoubmJ1xmMeAXmEeJ3ECezYDD58wSeFmBR9V6PJkgP9kxUP1L7Dxsppc uD3IjYJmFL/6WDCrcnKS1OoQS6hkIMSAIBuDugxs/4eBeDHyGbIRVKayj0BJr5ljUh3e UDvq7xwiOcm5n+kMpPcLmvwMY2jy4MrIk+wULHRJQv4ktbXUo04MeqG1+8vRbK6isv7X OpE5Lh5s2Z1d+juR/0e3FFwM13l1erv2szBLkaj04d6IvUAQFb84c9PlGfo4Rp2irNag a217nGF3pwohYqDoTcL5v6cg5bh6fdJN9tQxs2+krzJkTlcfBnpPw1yRXuY5Chl8b8cd 3ddA== X-Gm-Message-State: AAQBX9dYpAFoBXwz09DAZhCT7ajZlge/z+MGO/519nuHrZAwlstCZNFZ QBc7hsZKUnlInk3L5JE92bQaYQ== X-Google-Smtp-Source: AKy350ZE+bmVNBlLOjagMfR+lJksJjtQKtz2tDfRSz+9IlhY8kqEPosmQe6maztyHrrb+7Y2Uq0BRw== X-Received: by 2002:a05:6a20:2926:b0:cd:a358:bb7 with SMTP id t38-20020a056a20292600b000cda3580bb7mr9221616pzf.37.1681121372393; Mon, 10 Apr 2023 03:09:32 -0700 (PDT) Received: from [10.200.10.217] ([139.177.225.248]) by smtp.gmail.com with ESMTPSA id s21-20020aa78295000000b0062dc14ee2a7sm7492087pfm.211.2023.04.10.03.09.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 03:09:31 -0700 (PDT) Message-ID: Date: Mon, 10 Apr 2023 18:09:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] maple_tree: Use correct variable type in sizeof To: Gang Li Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, David Binderman References: <20230410091431.74961-1-zhangpeng.00@bytedance.com> <8b5af22d-1612-a2a0-02da-728f1fd57bf1@bytedance.com> From: Peng Zhang In-Reply-To: <8b5af22d-1612-a2a0-02da-728f1fd57bf1@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: BA88614000E X-Stat-Signature: cbsdox876sn6qq5taqxkopa3ug7h53zb X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681121373-281199 X-HE-Meta: U2FsdGVkX18tw0xem482cehbMmIQR8TnQUTCEKzcx05hPiSzeky0EMfGcVhrgfgpST2iSTeebxXE3JuT+b6Geo8fcq900lmsPsGWRnGaDT8QP792Kb45kyxfCigIPeF8ZahugAKVOltxJ/g207VomOXMyBIOv16sbw/EQ3x7jMT1KvsSxggTcYpirE9t6r/nTl9wCFk0vRIKOWOahakW5aOhn4ZVBcDkyERV519enCOp91U75+2DMp0JXXia13lIwO0oBtuYN6C5ThTUCc555QBqkZhYwSdvIoO6lw107RE9za6CGWukw/aHofg38D9I+vIDEk5k0rv5TjcQ0VXYMJMnfKImXqYGEp02AtvFXEz3/Ce5BhYwUNZMtqzkf7U33aXDKXeOAVhQ63GiJbnqBmfGUksPnyakWnCklEE6nfXSB3kEaClQ3HGt+F7ZA8s6Mtzx8t4lDt8wr4GZUeDWm5kqinPyvxpKmUI3QixuCaH7iI8Xa2ITibFPyrzrUk9SulJLcBTstPj6ErMIIh3DyeheRW+4dPzkEz2xh19ucL6l1a/XCmlwO2rlMrBFMA9poaK7U+j3zBsWhRytpIWd6S0s7TuKDrLdufDKcm6kgKcAGv2w13eLc5PL3/TC7X1cGRV482Pm2RYF4liCJ+WkIrgh+33LWbPfVs/4onAVoBozjr8zXuXMLK4+vi/keaS3nwKN2nvQsBVJpjmEucikx4Y/DHDdNurYnI3BfRXwn8tbk3dRKW4sWo5BSIkIqaA/bVN4xhsTrPYtBA/ggaW/Aw7WCLxYqZSfFAwt6vY9SsK8HwFCAFFn2TOXepgPaq0FjdIEdHIhazNHFAxBx7GNr0p9Z/58NC0LiGvBWuIkQ3HdeR0Fn4/X/1EXWYQTWaUoBjbKi4kRRMqDGL8ix8808JGEVLEk+cor4+d/12ciovGinyQJfA4CnfpkF2QHowGDRC3nisT6R7GibLEd6EE chQ2f+Bz Q7gHv17x9YugxkViEFe++Pv02UasOqGTRy8vYJiBbMvP6Hu4EXL2ne5eWmLyTZnfcJM6QWaHnzFCMk/iYSY+nHNKiJc4nGMXJkgJAX64WlSR2VwixOYwvceEqw+1BbbHMA0dXD9NjVX2No/rj72EMwhcK13a5PwsmjrcSsalmFWuaMljUxnA53RfA/aomFZWxfV9vvmsPU1epLGCXOwuZ63qu1YwG0SV5/8JQbEeBEOdPpgTSFQALkYmfroVtXi0SICJPld7+kkwVZnzHmnH/QCI6pggAUbjrriOoUpw69xSSPP0CFQblVg5HwfE9x9H5GYVR3qmz8htE+BVqRfo+JvGJnns/QjMXVIF/LyRQBFGlO5fotNQtnCBOHTEWL40DJNIHZnJYEG7smqIgvlxwK1jq56D6xRy48uMlE+LuEa0XxIZxbMRBJ16JMGPIOHnnmJhJeAqRBehHUXYweRzcrI0sPTNobaL504wf5devSpWJfdUaPm5ex3dL9Ws1UmttjYAd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/4/10 17:46, Gang Li 写道: > On 2023/4/10 17:14, Peng Zhang wrote: >> The original code is: >>     memset(pivs + tmp, 0, sizeof(unsigned long *) * (max_p - tmp)); >> >> The type of variable pointed to by pivs is unsigned long, but the type >> used in sizeof is a pointer type. Change it to unsigned long. >> > > Maybe add a fix tag? > > Fixes: 54a611b60590 ("Maple Tree: add new data structure") Maybe sizeof(void *) is equal to sizeof(unsigned long) in most architectures, so I don't know if it counts as a fix. Thanks. > >> Suggested-by: David Binderman >> Signed-off-by: Peng Zhang >> --- >>   lib/maple_tree.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> index 88c44f6d6cee..b06fc5f19b31 100644 >> --- a/lib/maple_tree.c >> +++ b/lib/maple_tree.c >> @@ -3255,7 +3255,7 @@ static inline void mas_destroy_rebalance(struct >> ma_state *mas, unsigned char end >>             if (tmp < max_p) >>               memset(pivs + tmp, 0, >> -                   sizeof(unsigned long *) * (max_p - tmp)); >> +                   sizeof(unsigned long) * (max_p - tmp)); >>             if (tmp < mt_slots[mt]) >>               memset(slots + tmp, 0, sizeof(void *) * (max_s - tmp)); >