From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E83C2D0A3 for ; Fri, 6 Nov 2020 17:28:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A79892078B for ; Fri, 6 Nov 2020 17:28:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=deltatee.com header.i=@deltatee.com header.b="ZP0R0Hzd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A79892078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=deltatee.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 182496B0036; Fri, 6 Nov 2020 12:28:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10C266B005C; Fri, 6 Nov 2020 12:28:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F16916B005D; Fri, 6 Nov 2020 12:28:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id BCCCF6B0036 for ; Fri, 6 Nov 2020 12:28:15 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6A3A01EF1 for ; Fri, 6 Nov 2020 17:28:15 +0000 (UTC) X-FDA: 77454676950.21.smash79_1915b53272d4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 497D6180442C2 for ; Fri, 6 Nov 2020 17:28:15 +0000 (UTC) X-HE-Tag: smash79_1915b53272d4 X-Filterd-Recvd-Size: 5148 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 17:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QpuHLB0GpYTnQrdJoCEWfsKDl3xh5PNClZ27s55U+do=; b=ZP0R0HzdgH1uFfEUZzzikuYDfI zqaPSQGeQvgM5YjaFvhCmlSs4rN5X1m1sqlZV9ed6j0uJF7a1RS+fTwtp1gP1X9N8KodSiYvt+uPN uZQKAE5qAr8FdL5Owfwzb8VEesIyBead7s8R6Zm9WHJN4vMTNGcM+ddbVw9gYc4myoSfcTyFWsqC7 47NWcc50emSaTQajUsHV0+gGGJfZIMPB5+TQg9V0LSTnPdPKecJnCqfC70vqTLUhWCaTf31rwFOlt UmzKn/5wlKuw9Wdl7UBmStDMNhpka7cU6SP3l8+zi591j4n58kY7NS/qm8hOrSau9vRmLye1yHat0 4ObFWpcQ==; Received: from s01060023bee90a7d.cg.shawcable.net ([24.64.145.4] helo=[192.168.0.10]) by ale.deltatee.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kb5Wu-00036E-5n; Fri, 06 Nov 2020 10:28:05 -0700 To: Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , =?UTF-8?Q?Christian_K=c3=b6nig?= , Ira Weiny , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter References: <20201106170036.18713-1-logang@deltatee.com> <20201106170036.18713-15-logang@deltatee.com> <20201106172206.GS36674@ziepe.ca> From: Logan Gunthorpe Message-ID: Date: Fri, 6 Nov 2020 10:28:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201106172206.GS36674@ziepe.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 24.64.145.4 X-SA-Exim-Rcpt-To: daniel.vetter@ffwll.ch, willy@infradead.org, ddutile@redhat.com, jhubbard@nvidia.com, iweiny@intel.com, christian.koenig@amd.com, dan.j.williams@intel.com, hch@lst.de, sbates@raithlin.com, iommu@lists.linux-foundation.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, jgg@ziepe.ca X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-11-06 10:22 a.m., Jason Gunthorpe wrote: > On Fri, Nov 06, 2020 at 10:00:35AM -0700, Logan Gunthorpe wrote: >> Introduce pci_mmap_p2pmem() which is a helper to allocate and mmap >> a hunk of p2pmem into userspace. >> >> Signed-off-by: Logan Gunthorpe >> drivers/pci/p2pdma.c | 104 +++++++++++++++++++++++++++++++++++++ >> include/linux/pci-p2pdma.h | 6 +++ >> 2 files changed, 110 insertions(+) >> >> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c >> index 9961e779f430..8eab53ac59ae 100644 >> +++ b/drivers/pci/p2pdma.c >> @@ -16,6 +16,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -1055,3 +1056,106 @@ ssize_t pci_p2pdma_enable_show(char *page, struct pci_dev *p2p_dev, >> return sprintf(page, "%s\n", pci_name(p2p_dev)); >> } >> EXPORT_SYMBOL_GPL(pci_p2pdma_enable_show); >> + >> +struct pci_p2pdma_map { >> + struct kref ref; >> + struct pci_dev *pdev; >> + void *kaddr; >> + size_t len; >> +}; > > Why have this at all? Nothing uses it and no vm_operations ops are > implemented? It's necessary to free the allocated p2pmem when the mapping is torn down. > This is very inflexable, it would be better if this is designed like > io_remap_pfn where it just preps and fills the VMA, doesn't take > ownership of the entire VMA If someone wants to manage their own P2P memory and create their own userspace mapping with vmf_insert_mixed they are free to do so. But this helper is specifically for users of pci_p2pdma_map_alloc(). I know you don't intend to use that but it doesn't make it any less valid. Logan