From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D6F8C00528 for ; Fri, 4 Aug 2023 01:53:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7A632802B6; Thu, 3 Aug 2023 21:53:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2A652802AE; Thu, 3 Aug 2023 21:53:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F1B92802B6; Thu, 3 Aug 2023 21:53:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 816582802AE for ; Thu, 3 Aug 2023 21:53:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 45795C0861 for ; Fri, 4 Aug 2023 01:53:26 +0000 (UTC) X-FDA: 81084750012.25.7B668A1 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf13.hostedemail.com (Postfix) with ESMTP id CB11A20004 for ; Fri, 4 Aug 2023 01:53:23 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691114004; a=rsa-sha256; cv=none; b=HOvdJPUxOAAH2rWwtR3cdcUV2nF/Wg8Ca5app9WcciZ0lCqLMqFuBWZza6xs0s0c2UZuec HtnJduotXE/7ayWDJCEWaLbYcqkNOtMpZahCeF9ZMe7O8TxkAFeJa1PqUjg7fNSSO+sylV jAmP2+emrD7vPo+BdHGWtZiVckokjOc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691114004; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kqsoFpS8oOeNFRsp2u8HNUEab2HjkEXsXqAQnk26C14=; b=DgiEOFsa2qdy/ZusmaRCHKRT9XOW7VQ3UtGOvzecM3m7iqhlaIibSArJxHqGDZWo0fvYe5 2BtpvKLIVtrVdEZkDblCLpI8gWHhZNTeQph8WCf2jn4JWPfFHFpefnkpyVCqXeGSCGUHy3 1odyZREklx3xRzyE9iGjtLlI3JiXTkE= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RH7wz2RZ8zVk1x; Fri, 4 Aug 2023 09:51:31 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 09:53:17 +0800 Subject: Re: [PATCH] mm/mm_init: use helper macro BITS_PER_LONG To: Mike Rapoport CC: , , References: <20230803114051.637709-1-linmiaohe@huawei.com> <20230803133346.GH2607694@kernel.org> From: Miaohe Lin Message-ID: Date: Fri, 4 Aug 2023 09:53:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20230803133346.GH2607694@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CB11A20004 X-Stat-Signature: c6zi3pt19xscpozfoib5qb56pomwm9au X-Rspam-User: X-HE-Tag: 1691114003-423077 X-HE-Meta: U2FsdGVkX1+oShlNhvHUb1wMJwnl/Z3jljyI4UOlBE3ali9x9JHnX/uzDMSIzYbHkBbey/hXJGhXNoob9MExPKLGK9sDXe3vpsWJHvD1P8fVLuwdcU/pHj2d//CHJXyYyL01G/CaiPs+a1V4vGqs6sGGvRGT9XBvi6Wx22fUKgxvCTOnT2Pmq0NVcRI9g8Kaui/i8me7D1neGWTdSZFTmv4UAgUKojpbIfDT1aTl9BNOakBUeU7cPi2H+TG/LgGys9KTWkLik8XL1ekNfQq30DPZsflJ4eL+VaBf9pb8KLjAvkWZEDbyXn2knLig96KkSfPHuahSvaq/YbX98DHMAlpwUCi6xMvEleZDvHjQOAoiUqvvUpalcjBKNQVmVI+6+6VWicMTwjNFSWmQh777lvBkerQcsYVnXqgb91W1asZ9RPcgMfidgdBpMshWWb3JRC0gRu6jILy0jPqJRROeQngC02gsBZbo20PmRdhdWWjbgIpRIX+FrrqAVE8xTr6zbyt/UMhwtcmyegJAl1Y/mcCV5R7EChe5/bo0ugKwzr41Uv/5c3dK09mxjceFrKGDq73sKtUgC62KSVRlQJyYwGgcvvqDlndaAz+ey0dytP/gJavj5y+gFxQE5cUXgV/iFF9C03KYrhG4OCLBXq9Pw+q2Qk+dSnWC9AgS12S8OomVDjTnK+CyhS9PhP1ZzX/RzijPMffeuJfsy3TrBJwGo/dnJvAGe2Zgx1stj67rCISl+wZhGAmgA8tMMs/rkB2a7wzrASe5kbeselj2zeXlwdAPV3pHZZMzMN8XVigzr1G9SuYCZ6HfRQIuRDzT7a2Mz55Fxr6zroCpMHlFv7DGcrKW9cepENNXiVZskctVIyvWMjaAdS+BUPglkOgoneBma4DfjfkXbxHaBEO1MMZZ5TX+apbhWlTGcfogTVLgThd2d2NNEAOHW7Rh8n76rWheqNVL/5Ig82D0sZgG7fk jlbhjZS9 qWr+ckKyz+N7moH5cexNpwTTAJdbcfaFQlBaBjbRcSPFwv7W11guQk2BdINCYaYq4+mXOS/8KqkcCVpCAaLFuSadihDwZf39/oU52Tflhn4fI8qFO+TIxtwnUA1sBdIUrGdrXvH9RhxvtQxEve49HGClWgh43Y72IC9SUnV/lHqPVo3ZVdlHUnxx42Q3LZDZMiLgBPbpDoqGZVa0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/3 21:33, Mike Rapoport wrote: > On Thu, Aug 03, 2023 at 07:40:51PM +0800, Miaohe Lin wrote: >> It's more readable to use helper macro BITS_PER_LONG. No functional >> change intended. >> >> Signed-off-by: Miaohe Lin >> --- >> mm/mm_init.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mm/mm_init.c b/mm/mm_init.c >> index 66aca3f6accd..2f37dbb5ff9a 100644 >> --- a/mm/mm_init.c >> +++ b/mm/mm_init.c >> @@ -79,7 +79,7 @@ void __init mminit_verify_pageflags_layout(void) >> int shift, width; >> unsigned long or_mask, add_mask; >> >> - shift = 8 * sizeof(unsigned long); >> + shift = BITS_PER_LONG; >> width = shift - SECTIONS_WIDTH - NODES_WIDTH - ZONES_WIDTH >> - LAST_CPUPID_SHIFT - KASAN_TAG_WIDTH - LRU_GEN_WIDTH - LRU_REFS_WIDTH; >> mminit_dprintk(MMINIT_TRACE, "pageflags_layout_widths", >> @@ -1431,7 +1431,7 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l >> usemapsize = roundup(zonesize, pageblock_nr_pages); >> usemapsize = usemapsize >> pageblock_order; >> usemapsize *= NR_PAGEBLOCK_BITS; >> - usemapsize = roundup(usemapsize, 8 * sizeof(unsigned long)); >> + usemapsize = roundup(usemapsize, BITS_PER_LONG); >> >> return usemapsize / 8; > > BITS_PER_BYTE instead of 8 here? Sure, this is even better. Will do. Thanks.