From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E8EC47DDF for ; Thu, 1 Feb 2024 12:32:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77FD96B007B; Thu, 1 Feb 2024 07:32:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72FDB6B007D; Thu, 1 Feb 2024 07:32:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61F206B007E; Thu, 1 Feb 2024 07:32:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 546826B007B for ; Thu, 1 Feb 2024 07:32:33 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 27213120721 for ; Thu, 1 Feb 2024 12:32:33 +0000 (UTC) X-FDA: 81743173386.02.3816D7D Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf20.hostedemail.com (Postfix) with ESMTP id 3542C1C001C for ; Thu, 1 Feb 2024 12:32:30 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=uCrbeZSF; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf20.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706790751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bxz9cdBqN8ujFtkandGz+8lXjevzJLMemD2wkc1YE2g=; b=lFtMjr+4jh2t/4okguOlCB2al8HfY8Qn2m238k3bCK+wQzZJ5qJx+8g+CkhsZSlprrve0+ ntYdDTVvV0755rPZYAvIndOxM5rBeJ2K+6wXTfWj+N52de5zv0Jqmf4tMaRIKR8IKbK5Ma qGD78mVHo+8DtU67nbyNpb9SYNyAxzg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=uCrbeZSF; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf20.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706790751; a=rsa-sha256; cv=none; b=ao1Fah+phU+miiwSN16n5cUbHwg9Lh0/KFgI25U9hAA4spafGHrgHKNsr0ci7/U2j4/7ny ceA7NMGfiwBVMeHmfU5JVQZpinO4duN7nf/tolBpaOnNg+JCIHWVydOAWazwMoO2JWJjej xZMGoIJVOzDzmGNCfBk/0DSqKoThVus= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1706790749; bh=qhZOIwqkNCYpK2Pp3te5HY4KlfQz8tkJ4SWf+XkvlIM=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=uCrbeZSFwgWfSog96oC2NDyv2UBshUZiQloq+462UDy+Y5RhZ83+Z4zLj1BaeN+ko Cy9GOMa/7VgV8bwMbTH1hNfRy2ePm8viLk/h4IxcoO90TvQ2OqznHW4tf+oMVqc7Tz KnjRKgOrnWWFOAuUl+O2jfRrIm/4n+O7OQMdS4H/Rq5UZhywlhK1aUcyr65HIK2ysu a9uMcYTSiJfB3SPiJypIxjlArGnevqRYCKGsiJQH1dF7r4ebHaF3+fTG7vE53GiU+B MInpTqco6OcASUesYM8V7Ei1J1MIGlsLM4sGyjaIINPDvVg2Cq8JmfPEheroUCUhD8 DsuAQU4qN5XTA== Received: from [100.66.47.90] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 3D366378047F; Thu, 1 Feb 2024 12:32:28 +0000 (UTC) Message-ID: Date: Thu, 1 Feb 2024 17:32:44 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: on-fault-limit: run test without root privileges otherwise skip Content-Language: en-US To: Andrew Morton , Shuah Khan References: <20240201071307.592317-1-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: <20240201071307.592317-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3542C1C001C X-Stat-Signature: qc3g9wrdszzxwmn7yxy669uwaooc7u1s X-Rspam-User: X-HE-Tag: 1706790750-844246 X-HE-Meta: U2FsdGVkX18FLTfDgaWAdYbSOQ1Xlz/oW3D0IUDygBlySuW/PfdBmMkU9AkVyMrTEc/UI7nsWD9vbLNzFaqMXXcP+43sntbxjoh6p7fIw/SaYVGckxE/LANVMzvmjcr2tk3zLckTCcJZ+/eOhAGw3UWEacFPkTeNsQtJto/G28bcpMjnS7obL0q1nkDwmPbuqY0S9QckK9TsW6IVYeNDZVKXYtG5QCYFp1T1USSdm5AOhg5akB4UJuw0KKMbrFIZ2srRrTlXJjs/nKMOpstFHBaFJIgK+GJQlfoDMk3B3U7nSiqBmM6oJmSnh6sirfkZzVZPF/grWs0muCVzKxQFc8CwXvBdgodoBuQc3y/DBy/7Mh3F7EKhR+AgKigmaiaRZgmXoFOZtoJuqA6Qavf3xo01GsfItcXSZ6xhiJelfTBWbnKUqf3mpeYQM9pxYMX/xmUGbLPPjZumSGOl8M8A30uFn+AOkXAiIij+ZSbNdHiu6OanuDMVZlJa5O5ezGPodqiPP1oqDfN3hwrYsvcNHaCefNNq2eiGREHnhB6RXmkPoksPGd6OydYM6tDgU2ZuCFY0L7NBHGgzdeJ+5cjIoqefUofz1uJb9+As/DnAvcXTvQA14LptUW6w4TTB3AY9WRvQzzhdzovAVIdnf4HrcbyPFMDBuf4w4awrClQNlF19aUDpnuKh3nKghl6wIu+OqA5wq043WJbXuQZL50ld8VEZ0Qep0soAeYGwOahuih8UWt7Ctc1yGsPf+HmUV987GoDsl0ZJt+uk1i9+JTpM+T71D9dAdrf+9tNK1iAbPfyIKl+POkStRQlmVqOnq3SkhesSkYHe91tMAFohUdhRVIK1flaZIqlOk4WcuFmMLhyToNkKYbb0auQW9KTnWEUt9NGWn5ctHkRaKogPQKHPB/3xxJK/FgqXYgbap2JkKLGS5O5AfrZ1KJ3LXFKriT02R+tf+JdYU1gES5enNLK SOzCAiM2 i4Tvx6iM5kjk7QEYkz/UmdLGXJ7kipoj0ZJs9c70sy4GGlR6o+LFUqeK0JWnZSYxEoKQm1VY1V/gX/hddVnQov2cydNFOCjO+oyI/RMbqBavcpuX3/XrmOo/07zSdukFLp1Ka2VyVKyZiFQfFcfYPIYJQKbKmFGsVXr8uy68W5YTKEoEkGOU1ryKXdDaiJAluSVVNT3uJgs4SMwjMH5HBwkAWN6W/lPHq20QdKXgvGvUO8bFNZTX5By4RZQW+DWye5/MG2EJo+6hm5zEGTYaZQeh/TjDAjSl0X2keSwV9RhBMqVs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002935, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Please disregard this patch. I'll send another patch to fix another thing. On 2/1/24 12:13 PM, Muhammad Usama Anjum wrote: > The mmap() respects rlimit only for normal users. This test should be > run as normal user, without root privileges. > > Fixes: b6221771d468 ("selftests/mm: run_vmtests: remove sudo and conform to tap") > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/on-fault-limit.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mm/on-fault-limit.c b/tools/testing/selftests/mm/on-fault-limit.c > index 0ea98ffab3589..431c1277d83a1 100644 > --- a/tools/testing/selftests/mm/on-fault-limit.c > +++ b/tools/testing/selftests/mm/on-fault-limit.c > @@ -21,7 +21,7 @@ static void test_limit(void) > map = mmap(NULL, 2 * lims.rlim_max, PROT_READ | PROT_WRITE, > MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, -1, 0); > > - ksft_test_result(map == MAP_FAILED, "Failed mmap\n"); > + ksft_test_result(map == MAP_FAILED, "The map failed respecting mlock limits\n"); > > if (map != MAP_FAILED) > munmap(map, 2 * lims.rlim_max); > @@ -33,8 +33,8 @@ int main(int argc, char **argv) > ksft_print_header(); > ksft_set_plan(1); > > - if (getuid()) > - ksft_test_result_skip("Require root privileges to run\n"); > + if (!getuid()) > + ksft_test_result_skip("The test must be run from a normal user\n"); > else > test_limit(); > -- BR, Muhammad Usama Anjum