From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C5FC77B60 for ; Thu, 30 Mar 2023 00:24:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E8ED6B0072; Wed, 29 Mar 2023 20:24:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 199B76B0074; Wed, 29 Mar 2023 20:24:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03AD46B0075; Wed, 29 Mar 2023 20:24:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E4F8A6B0072 for ; Wed, 29 Mar 2023 20:24:43 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BECE4C0E6D for ; Thu, 30 Mar 2023 00:24:43 +0000 (UTC) X-FDA: 80623668846.15.D7E5C30 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf05.hostedemail.com (Postfix) with ESMTP id C0D45100014 for ; Thu, 30 Mar 2023 00:24:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=Qn+RYKAZ; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=QYxDsIVM; spf=pass (imf05.hostedemail.com: domain of "prvs=446f2bedc=damien.lemoal@opensource.wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=446f2bedc=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680135881; a=rsa-sha256; cv=none; b=msFmSC+e9ypoT3kLy+MP72ydXMy1vOwL3RwvkaRLanspzPeh84CF2ThrXEdMf54jvsWLH2 t8dFyV8cZhv1SxtYEx+nY9m+byNa3yKVY2RQiyv0BXgUX9jInNQIED+1qtvAPho1hcF5mx nS6xTGx2ugl++hLh0pdCfhN9Jxv0bR4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=Qn+RYKAZ; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=QYxDsIVM; spf=pass (imf05.hostedemail.com: domain of "prvs=446f2bedc=damien.lemoal@opensource.wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=446f2bedc=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680135881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qt1x7YVxfqzn+HD4mjAgVT20c57AOdxOnsXsCs1FA/w=; b=jfIMiXcHnMy4Mv6r0jnFFfpi6pbCSKsw2iTCCVPLqi0nCRFIBkQ7j4x4/aQW4NJXooqnDM vb3Z4gIUqX7effycFTIfM+WAGjnLhvN3IOUBD4n4AtWJShGeHpSRuiE3yexTjhJs3NwJGa 72YatBQnNyFi4KKT5i0g6OCAn8hL7P0= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680135880; x=1711671880; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Qt1x7YVxfqzn+HD4mjAgVT20c57AOdxOnsXsCs1FA/w=; b=Qn+RYKAZFTZ/InWanaFJ4smXCz1sROJG4KDq+et5xwwuK2lPRSoG2Y0l 4I8eirbEFxSK9pBEPF72+q4Z/MnIuhczbLmjD5c06jGRFBbgMRxEoelSM 8zR1Nvjy+ti7feH4fPpaDIIOxyrS+COEoZ+JImEdp6MX9uk5fL6J4k9Q2 gUewaEG0V5GfYm5eIyw5bV+7nE/rsWvxIETDgUjiUJ0h4WqGsGvJsRwru Mby1Vtd2qInmYIaJLniVcXevqr4u+qqSg1Fujtk/EJb51bvSPnFakI/41 jZsF9LvXqExMZkrJ33dVICkEgUqr6aTH7nTyNFCvUoMAN/5F3KGGkrPLU w==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="231811665" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 08:24:37 +0800 IronPort-SDR: NeES0L8Q2KAQEIXPJCZNgDFUHWzUFiZBV3t8jwpmdw+6DS8kBLZmz4WfXgpNdkd/9V+9//RKTo MejRR4x5v7FTRVVOcI6vc82KQ5XIsQmDrTb7utComFWErvd2GmobQ1Gydjt2k7BLI832uwlyh/ 8hBdGvU4EeS67u2nDOoO5FBMjz6yXoVSRlbB4PRnmb5yUe6Teng3GkGORX7DJnEVENf8wU1B/z uUHLOcVBouF07sA/3B7B/iU79LJiDcu0hiyBGOOSHygv/I/A25udzazCjIwymOXWjoesK4zXk1 /x8= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:40:46 -0700 IronPort-SDR: jQMLIO/nuoNMakv3DHuG1fQUEKviLgvF6FDMlxqbwsupSMplovXsjHWHHWSLbFZlhBY8wsoPvC 54CCAT3ZqIrPd5y/nPrRmAqTmMTJpKFfqitULjKhpf13C7UDS7SBLYr6a6iU6TunZG1M+W4T81 wIS7j7Fd5CF2T5/3VAgANhtieYC4zjIVx8YROMloDAJWysOBzU9NFXgwIkJoxtVYZYP8fuvUGS IX0bnB43RZ3ghJLOfma8tn5J84S9ZxVYSBCX4DnrYemhb0QUZZmO5SY5oJGmykfqA7vLYRRte9 RTM= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 17:24:38 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn41J3QdWz1RtW6 for ; Wed, 29 Mar 2023 17:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680135875; x=1682727876; bh=Qt1x7YVxfqzn+HD4mjAgVT20c57AOdxOnsX sCs1FA/w=; b=QYxDsIVMrmX6uf+9bVUxwnELpwLFtWbRMF/Nt94gTpOQqsLyuHo PXJiVZbl3870VsxXn8brpbI6uXwWHk7stsw+5gkioY211aQ4o7Uwst47JscjbQrE K99N0ESBwKRwcJ19lOavdNixjywODC+7YTyIWnQWpWiZ7LOJA65a1Dktc5vhkT82 znVNQgKCEILTiX4ZJrtUa8z6RLlEDM8bBMpnfRTy9OPKQbfOM5lFjJG9REul1WDJ YusjXPCg9SHR5Djh+zW5IEAVq4UBPEDGxuvLD8JkqpT7PkTcGPvdn28OEWHZvMVg 2Mi24TQl4Lz1GQlrFjxVXjdvpPxbmdednfA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cqWC9g5iYk4W for ; Wed, 29 Mar 2023 17:24:35 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn41C5RmQz1RtVm; Wed, 29 Mar 2023 17:24:31 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 09:24:30 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 18/19] dm-crypt: check if adding pages to clone bio fails Content-Language: en-US To: Yang Shi Cc: Johannes Thumshirn , Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <3a0f0c92-63cb-3624-c2fe-049a76d1a64a@opensource.wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: C0D45100014 X-Rspamd-Server: rspam01 X-Stat-Signature: r17wd8ajqszy5urjg6zsf5j3h1ztqd57 X-HE-Tag: 1680135880-289699 X-HE-Meta: U2FsdGVkX18BdTVmc2kh7DJm60cKEsiNp0C7w9b03iMkjL853RwViBgKXqw1jc1VdqV4pjVr2Md4k86a/oM+Z25GQPlpGGEk/IgJEZUpR7g7uJCeupdXLqAE64hs43QH6KREtU/cpxI9tkfiZrOU8NdPtaXlXnSZNTNs2/mD/z6jpk+Zj/Q06uaNI+Qthhf696QhMCQfp2gWovpUOqToKLa6oDeMakPQL6l4DFsNwjV3uk0pIonc0mtE5cqSQOaCi0xgdgdcHigxakqOKhsx0nZhVf6BZyXdKxq7muZAecBUV3+/Laua5YVKqclJ4izg/+LrZUfPhhx+11LU0ywh5FJZpADgsyRKoSdr1zYhTqy3o37S1YtmsJxuDOVkUEVC/lYpEuVL6xFVtQGu9z22Db1W6vW+lvTrEciX3fVh6YIEK1ETPdbLiamp65sRfO2+lDViLVJjvbuhoiVmtu/ot2t6/2m8UPS8LOkFjhsCcnzgfFjm8aGO3s1BlAMqfVrVvMAf/J4tYufILSsr42KM1eW+FOJVLwZAUT3yLBTPzR4cI3BxZagmZIOw9ly4fYYKSBBca6RyZ/KFHHJG44pYKK2eJOHtGYrKk9G1hBaxcQVAibp4HaipixZzYBAvZatmIZHRK5FMclT01gwCjQ6reKDPZP9Dx7mwjElIOjIhaGbbPn9UF/44GwqB/f2055vgatyT3HjVzseVwgH3DdlwyTcJHDNPEGIN3z5OQc7GB396Zpvc03LGvS+UriGXq32tPg+rUKk/SwbwxoyiFqrpY7ZNTvDTOBAEwJ9Zx2UwW8sNQAOZHwDhqIhASUzRlaCrgVuZ5SwdS/DMVclMvV6XfVi0bP4FbtZ7qm3A+adlgTmYZppMXjPepuT5xBOr1sOhSJEQiEp+64A+W9uyU1Q9f++h4l9Qo954uJzz5YBZZHnIZD1rZynaLs2mpuhyRct5xjsR0yYx3h1QBC//B6q 80qaT56R SwoBYEv+/AZzc9iVoZ88DTPTZVIHDV7rtFdTxRRqZgldNwZo03tjnfaSC7EtLHFMxxAkswwaSnDrAppBdOhio3dzBb+HV8xIg4V1u5jDDorjNtzDzTrrQVErNexT9LXuF6KXghOvOKHeW76ztW7p/qg3MiAMPExVMGxfpWDrYQ1KUMZZ/Lw0di2VkSMysh5Hf7CDmCeQTNfAUTJVX9lq/Yf8GlcKlicfCmaWzo0hzfi6vWreImwJ1oCn+/MyVm1E6jMOfXBUgqPEmA9dQ89JCra7vt1Iteo9jMH/0GLKrbtU3rl3KiOAQ8nV1zyAxpoeHVb6J6bNLD/iggAanmoaxHKIurdQlMAlT/KZE0QfGt4uuAClrzOc0eeyRDJDRO314H7DC+SOo1uZSQtTPERntLgm03SpDr6UZrl/60NUjVRhpVmvt+ahD4ZX8WX2rja013JfVFSeC0jGc+K9rH6VUHuP4YzaIuCGe1EdEtJr1mhgP5xi2xF/tSPc7ztuUq5OPyn5qLemAbeAAjFi5Asg+hV3lz8Nt6jl5WzAMWsGE20nlkfPGknqqWVTm5kKTmGFpbf5HfvWobWGusHEFZ74oNq3JgxnpBpp03UomnKmM8DZCUg6xnGuLWrrSMtibDXxubFwiR08YrTy/3PvClaXdrMRSMloXvScGuCl6xiOj6+8DwgY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 09:17, Yang Shi wrote: > On Wed, Mar 29, 2023 at 4:49=E2=80=AFPM Damien Le Moal > wrote: >> >> On 3/30/23 02:06, Johannes Thumshirn wrote: >>> Check if adding pages to clone bio fails and if bail out. >> >> Nope. The code retries with direct reclaim until it succeeds. Which is= very >> suspicious... >=20 > It is not related to bio_add_page() failure. It is used to avoid a > race condition when two processes are depleting the mempool > simultaneously. >=20 > IIUC I don't think page merge may happen for dm-crypt, so is > __bio_add_page() good enough? I'm working on this code too, using > __bio_add_page() would make my patch easier. If the BIO was allocated with enough bvecs, we could use that function. B= ut page merging reduces overhead, so if it can happen, let's use it. >=20 >> >>> >>> This way we can mark bio_add_pages as __must_check. >>> >>> Signed-off-by: Johannes Thumshirn >> >> With the commit message fixed, >> >> Reviewed-by: Damien Le Moal >> >> >> -- >> Damien Le Moal >> Western Digital Research >> >> --=20 Damien Le Moal Western Digital Research