From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5EDAC3ABCD for ; Mon, 12 May 2025 12:58:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 202DF6B011E; Mon, 12 May 2025 08:58:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18A136B0120; Mon, 12 May 2025 08:58:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 003636B0121; Mon, 12 May 2025 08:58:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D2CDA6B011E for ; Mon, 12 May 2025 08:58:14 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9C72C161151 for ; Mon, 12 May 2025 12:58:15 +0000 (UTC) X-FDA: 83434258950.11.036B291 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf06.hostedemail.com (Postfix) with ESMTP id 8777018000B for ; Mon, 12 May 2025 12:58:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vmyc2YId; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747054693; a=rsa-sha256; cv=none; b=pVnJBXQme1DB7lIMzi+CYLFvgB4ie96MHQ2oSe87YVPT34jA6atXPrvkSmNRIlWhZ6CpQu BP82RUqCcEkLLU38W1g7w5Uqz4omB/y4a+LDfPezu5uyh3ppGSaS2mlHMzcXbvdw7LtV8F 9XWfbGJNPQ8PWPYdbjLVzid8C9AA7rs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vmyc2YId; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747054693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YUfHzzLkVUWyZNQomKkAfvfG+NNPVh/dAwIfVzHSOio=; b=bFrb810m796H3Q21Rf2YnXNBImKi4xT+XCfW4YtTTXmKxykXbdOHSNI4bwe4tKbyBdXysT vHJsvQ7xH7tpvrafvBFF4VnstdP99GWIfAiibVmWMiJ3/H0YrYRrq7iYbu4zDl8xLa/GZf fMwlQ4cpFOTqrklJ0kVp1caf7+U33Dc= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a1f8c85562so1944402f8f.1 for ; Mon, 12 May 2025 05:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747054692; x=1747659492; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YUfHzzLkVUWyZNQomKkAfvfG+NNPVh/dAwIfVzHSOio=; b=Vmyc2YIdeGZ8IiWLtgnM74uVvhgl7tMfQfqeiS+/5y6xq+ECDRBjzR8ItUXJrHBvOW LgZ2GNfm5RvS1xirpKCRjpZZu1qNM/okKSMkweJkhp+1TrVhBzM7CQRSMXV+TEJpMo0k zSKGfiZGlkAX5heEy/ljJv79jGjflXYd0X6rcEFBq7PxTMzewV6M6iXLFt8Vig4YOgkB hFra6FxxuiQnOjx2UYHenFp/qQvn0YWA6H19w9AQWU/JNEkPTAzslh2vikqK7klHL3bt 1YgaJ1S6Ngcy+JPmaMLiKTU/Mpy7vdTwEJPHLIGT8Q6ByRpT5ynZbwGMZ/aSRXOGfbJF hSzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747054692; x=1747659492; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YUfHzzLkVUWyZNQomKkAfvfG+NNPVh/dAwIfVzHSOio=; b=vqajCFFFtwcOAnYLWRv2nrm007gIg4xBm44CF+XN2thohgWxXyJER0nlL78Dy8MMR6 JGWOngOeGPKgxdJCv8GPTCuZb026jKbPJ+mmt1hMt5xunw7h6diKOAhvDhkpRrHZYYG9 QtVTMieUQmLF0BGA3DaUsHZlPDem+86/dUjhSfejtgzEZCAUTXE+EnJ+eTKmTuFAewkd /PqZDHNKEAfWtEZiDBP0H0St8wPVyp5M77NSboBdcoPEBmXVcnX6mY0jYY90B0AvIr4T cGi6ktcSvK8S8ub4H3V/z6qIhxFL2oqTluqflwlCPnCqDBiHlRJFsMGTH20KROOdsYqN tyDQ== X-Forwarded-Encrypted: i=1; AJvYcCXdLDNXPyIkY7UU9nTmpuis9X7rD9zTWBtDBq9OVJwGaKEHHYirn8K/0tlvdEbRFwxHARWnuCK1Mw==@kvack.org X-Gm-Message-State: AOJu0Ywmcx92Y9JkH0Jtk01Csb7FHl0w3kLAT9/WBofmKaN+/RBmESq+ 3fou/wKNSFY/nfBtQTwcZwlTGEYmrop5Vw5fdk+z/orM3Z2AMhFe X-Gm-Gg: ASbGnct0I7lxwtugQuKYYGX0t9+weSnC15hswCfX+eWEBxz6Iye2/cDSV13F0klAR9o IqRwuuqulVusi3F1PXGHYywMurqE5N2m6hlUAq0Ve7O+CklGOyHEurAAsSrFZ8rEJb1c0McQwIX DNwDGi+ia6OVxJpUKnnOJY5Wl68WWRttfOubDTZ9LmEKmex5ov9A4fC6D05Pm5ZpFm/kwwVzMl6 m9+H0PiQX+Kwx+swxuwauMwnOn9D5+WgCwcDi9c/7b0oWHPhCKH67/vKZvxT1Cnba0lPwMrD0j9 N1LFbh2S2b7g3wGFgrs+XrGpifzIO8isGHAc0AMeIqWWT+rresLykJJxKRoFxQ== X-Google-Smtp-Source: AGHT+IE3qc4mSsKQFbTECg8BbO2NXy9TVSwu9MLdCGGNSU6yyCc3khR5s/jlk1z6qlpukuO/50zmlw== X-Received: by 2002:a5d:6489:0:b0:391:253b:4046 with SMTP id ffacd0b85a97d-3a1f6431452mr9068500f8f.16.1747054691759; Mon, 12 May 2025 05:58:11 -0700 (PDT) Received: from [192.168.8.100] ([148.252.146.237]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f57ddd2dsm12404291f8f.9.2025.05.12.05.58.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 05:58:10 -0700 (PDT) Message-ID: Date: Mon, 12 May 2025 13:59:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 00/19] Split netmem from struct page To: Byungchul Park , Mina Almasry Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com References: <20250509115126.63190-1-byungchul@sk.com> <20250512123626.GB45370@system.software.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250512123626.GB45370@system.software.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: wy4bdzbrukwaryydih8n7qttopfc6iu9 X-Rspam-User: X-Rspamd-Queue-Id: 8777018000B X-Rspamd-Server: rspam06 X-HE-Tag: 1747054693-659815 X-HE-Meta: U2FsdGVkX19rek9hIqbFKfzSynJBNjheVA5U8I2MD8C6i5hS/FZxrGdD9G4GWcJmJotdgsPBmUEGXIHCv9tR+GgGyWfIvNTgOD6xrro+9idI77XHt/74hs4tTLsVPdrkMvbmJ5+iTwbA3c6CQNvgSrA1lJF7RPyyG9NWW/WLAEpEabplbHWnKsVaBt6W5lEOhOnMTW3pRGRlxjdIKiki0z5gX7ynyffz2vjfSuXMKWHiMR7PN8XMtDRLuypUGtd6SesjXECo56mPY/xI43TjPDuqeV3nfsGdT9rVlvH0WI3XoJLYN5BjsdEtJU8ZKekCOHC8u2I/KaV/6mcMKRxbVnJZ+QQeccTuh1aVNx4m/ynV9jcBMbW9vVQaZ2gULPHrPKUyHvT0imEcdKjAbT+PYuYrSgZvyxIZevakUr2LfRICDUfrw5cc5HdB09Esvx05EHID8QVogvkupFuUfLbhUiKA71FhuVrTR9ZZ6sWOcW9iYmaj5QpkRGPOHljfdhfEidu+bIZ2nhWlirgfsU7Q9HuUK1wAGJfOUWUhi84qXsy7yiDV2Xk9fU/bTX2IugLo1ruFy3rvdsf39zCyRzEaqP6wqFRYz4wh3OzmJdX124rWnGc7a8m7kRSICFC3xeWjE6BCKz51TJxS5v+NEKwj55GIttudUJ5Ua/teBLY72i8ZS1EFww1YPGd7VDV73Oa5777QkHdU2b0p/PLwr9nUaOjAgYuQjjlmr6rnNCLMDlSHx7edY4SMQhQDDD9C5QS5Ldeq+McUsPZ9mzs+AjnzUQg170iWk2KL6JGIePlyF+eJrUaiieOtsL4asJy8+aHliNXfGVKlStMK+tbfh8xPwZZdlHcKIXb5LIKX9YBEFT30XClyF9lZJA4dbMIHwGWJB5T9WVl1HuCm6n9gbPECXs6N4UmaqjDbh7+eYGu8jsEyGY6Kmfbj96lJSX3Glu033FcieP38kl9HOhGkWh/ A/N+egw2 jrdhyqy0qsVtrSptJBKLbRc2VEa4ojOMMXVdMoVhBNe4W1IFHV9ZLMOnAKnjC1/qJnCitlQ0jNUsX/u5Uc6U4RLnTCP/NWAPZRs9Km7ZCLUHm2+TYRuUFx/y1IPOactx1ALNMmkDO/dBPvRWprgq8YUuS8z4vMEDDg+AMIvyuQoZs/48G/cSbhYEnUn239lM+T/YaTuc4WNjNoXaT4adZY0RTGELLBY9rwnkkiBOpTq51C1NYvnczD+MmRP3IYx3z38PIgCNQxrhk13PWeEp94EHc2Jldl5PNEOVY173L34PCxBKezqj8+fFYP+UM5gzvoigfNN61iGXSVPUzYx3aD/Q8l6Hao1SwaAI7RkW0tl6Aq6dZ9seL0/q0RHWMRXL5Hcd5C46/IU8hbfDcLQnjEmU20E/5hYRhdMBIRvFWtR5OnclPsubLMN3jGr38LwkyoGrzGi6wpDalFf89ejDYn15YEZXOoHwSJU/EuuN/aYjFopaOzdYSc3rJgMndWp9nNdMnWrkOwCmyqyu8It4/0Ja1KupZbauUbriaDEuNFYsqxR3MwR9JEysQ5ArGEe6tGQpymef3WrOwx891oFH1TVEMOXlhx5Dsv+ODYa4PosxVy+kj0Pc5kQ+upofbaDVTSjH/xqITM80OXtK6r/1yIkR6lmiUjrcVBA/4DCiIWSy9R0dh7Opldx3nqGUgvcmQJQzm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/12/25 13:36, Byungchul Park wrote: > On Fri, May 09, 2025 at 07:09:16AM -0700, Mina Almasry wrote: >> On Fri, May 9, 2025 at 4:51 AM Byungchul Park wrote: >>> >>> The MM subsystem is trying to reduce struct page to a single pointer. >>> The first step towards that is splitting struct page by its individual >>> users, as has already been done with folio and slab. This patchset does >>> that for netmem which is used for page pools. >>> >>> Matthew Wilcox tried and stopped the same work, you can see in: >>> >>> https://lore.kernel.org/linux-mm/20230111042214.907030-1-willy@infradead.org/ >>> >>> Mina Almasry already has done a lot fo prerequisite works by luck, he >>> said :). I stacked my patches on the top of his work e.i. netmem. >>> >>> I focused on removing the page pool members in struct page this time, >>> not moving the allocation code of page pool from net to mm. It can be >>> done later if needed. >>> >>> There are still a lot of works to do, to remove the dependency on struct >>> page in the network subsystem. I will continue to work on this after >>> this base patchset is merged. >>> >>> This patchset is based on mm tree's mm-unstable branch. >>> >> >> This series largely looks good to me, but a couple of things: >> >> - For deep changes like this to the page_pool, I think we need a >> before/after run to Jesper's currently out-of-tree benchmark to see >> any regressions: >> https://lore.kernel.org/netdev/20250309084118.3080950-1-almasrymina@google.com/ > > Sure. I will check it. > >> - Also please CC Pavel on iterations related to netmem/net_iov, they >> are reusing that in io_uring code for iouring rx rc as well. > > I will. Thank you. Mina, thanks for CC'ing. And since it's touching io_uring, future versions need to CC it as well. -- Pavel Begunkov