From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA6DD5CCAA for ; Wed, 30 Oct 2024 13:09:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 674076B0093; Wed, 30 Oct 2024 09:09:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 623326B00BD; Wed, 30 Oct 2024 09:09:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49D006B00B3; Wed, 30 Oct 2024 09:09:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 28AD76B00BD for ; Wed, 30 Oct 2024 09:09:41 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CA4A180890 for ; Wed, 30 Oct 2024 13:09:40 +0000 (UTC) X-FDA: 82730300058.04.0599D40 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 52741140022 for ; Wed, 30 Oct 2024 13:09:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GkLDG75x; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730293734; a=rsa-sha256; cv=none; b=pjYgzyCiiMAZFSsOkBLOS4cFT4HKoklP2ueqzwbjNmb3uvTvAtUe0/+mJUnZxBlQ+SymIq soFBb8iK1S1oVF7obXsSfqNQOroZkJPmyKVOWgjKiUgEDO8ntAcNkpNP5jvXbACv+i13mt v7T8WlQPNFEVX1a60VTTm11tARbcp4g= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GkLDG75x; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730293734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XvB4RbSJuz3suY/pA+C+IPGoIX1153rF4DWWm8hjNbc=; b=iXbs/uyTmrmfFDY3t6/Peh/Cb3g/wjW6c8aiJ/KJbi0FPo3WcRUxdbwrx7fwONCjAvnLGI 5jAuctce6TxamBQM0kXly6eHv7ZVlFKyA+uRJ5EEnO9EQPKP9F013DIMQ+bs4eGTXxqpgl 4xKjR12WN8GpKzpuCWQbAjxwetPkmlw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730293777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XvB4RbSJuz3suY/pA+C+IPGoIX1153rF4DWWm8hjNbc=; b=GkLDG75xxriK6+Dc1YKOqR51qeMIa3Cq+rXkL4Q2kHvEA/suVe6YvMko4zl/AtAyEPEXc0 aCPKaFuwchvn9ipG/dWKNumLFY0eGshsxO7Pr65sH7ZeST628pDleN/omk4N+N+W59aIHO mLzLhq7k+nDjL45usPsHIzusKQC5t7A= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-bHq-W1t5MimxwVUafpt4xw-1; Wed, 30 Oct 2024 09:09:36 -0400 X-MC-Unique: bHq-W1t5MimxwVUafpt4xw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2fb5bd1c324so44234851fa.3 for ; Wed, 30 Oct 2024 06:09:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730293775; x=1730898575; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XvB4RbSJuz3suY/pA+C+IPGoIX1153rF4DWWm8hjNbc=; b=W4bKfQJm4ZpDlu1h5cefwGqsijfccUBMK8pmiWBZHjyR43wb+5lSzgS0FTxocl69zj NnB26gxpywoVUncv4owF6icH9fVew82jtWr/V9YsowzDMpa6ShXunBA8hoMjGDyrgXgA dJAQxQJ6WLkZVVruT04k6XS79QqbGwekqnhcuZiQolAOs4W8NJLM8CdiMCQZAWQFXrdt cKlHhH0qjacqNfw0Vtc9k8Z2HNJL1I/u6lkjkG9AckZe5L93NBJJcnn7RMkqh6k2Mbxw 04/h0GGnT226S3EqoFh29QY4I32zH08iWgQbyhFkbX/inq0KIKZwMx3Lljzyr4/pApwl S1kQ== X-Forwarded-Encrypted: i=1; AJvYcCWbj5R1QDo6cZN9T+9nL7CCiQ20nBbzNErtdsXisr3Bu3B+Rrqt1KZXDyC6x8hVoosQJZA81vxzSg==@kvack.org X-Gm-Message-State: AOJu0YypRdomThjhs/98XgLMd5LaFRAiK7ZXaReaNVfQhlIwD64nAhhU XgA43F8pRM1fEDXPGS3hQ7A9ZSwYJq7Pph/Txb7G0fNJm0YYAk8YGV7S7bTt520oHl5iN2LlUJc X+661rgqRgnWxsGeo8kaoaTr88pOjIKcculIdjya8Ce30SNoR X-Received: by 2002:a05:6512:3ba7:b0:539:530e:9de5 with SMTP id 2adb3069b0e04-53b34b3bc7amr7653291e87.56.1730293774667; Wed, 30 Oct 2024 06:09:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEfoEErcVmzkUXWloKEqLXiAywDPyRIvqjaz7dnf0iaRkBIYJKkf07oWwsu/xq/65r2VCnZdg== X-Received: by 2002:a05:6512:3ba7:b0:539:530e:9de5 with SMTP id 2adb3069b0e04-53b34b3bc7amr7653259e87.56.1730293774188; Wed, 30 Oct 2024 06:09:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c733:7c00:d067:e327:4f99:7546? (p200300cbc7337c00d067e3274f997546.dip0.t-ipconnect.de. [2003:cb:c733:7c00:d067:e327:4f99:7546]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b1c8a9sm15391035f8f.12.2024.10.30.06.09.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Oct 2024 06:09:33 -0700 (PDT) Message-ID: Date: Wed, 30 Oct 2024 14:09:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: shmem: remove __shmem_huge_global_enabled() To: Kefeng Wang , Andrew Morton , Hugh Dickins Cc: Barry Song , Ryan Roberts , Baolin Wang , Matthew Wilcox , linux-mm@kvack.org References: <20241017141457.1169092-1-wangkefeng.wang@huawei.com> <20241017141457.1169092-2-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241017141457.1169092-2-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: jc9ii4rwi15gnnxir9xj4sdrwareg7e6 X-Rspamd-Queue-Id: 52741140022 X-Rspamd-Server: rspam02 X-HE-Tag: 1730293760-135686 X-HE-Meta: U2FsdGVkX1/fxoXxdFO18EGvVT1yL7dZJIW3DjdVotWFK7rB7vuFPurcs9zMOJTdm4zd2EPL+T7txmAnnVdp7O69zCD6UTukJBOIMgtp3wYSm3nFj93pR3gh5hCm4y4jjJdxCHQsM2sW5s7Mecw3K24CIgTwmHZbvTcxeSv5vCEeVNUcGNEXwMcc0QXRO+uHXmYd4drdp7oiFAOW8Y7D62aWGM94zrQQE+CZtDeZaoFqwm0rf5WZnq5/3K6PMzcG/oSTZB1JGNuwcEHNhHIn5Ukk9PYOjcANG5nkrOr+QmmQIF2CaaV9XPagXEDFnfse5IJ5YQgwcU0GcsUzZCdSJGuTmuOvURZUHzu8xPFBEHhut4964MPC5gYFgHjPzgnNNO/W8D3/XhFB7/rzriJl3KUudEBc+T+71HoeaHQfMMoX0zXZGUQhajqbMIOjzJTAvKRaBEs0kscsV/EX7ly+zFdZCcZLab2gNNJNDmRw2sK6PHf/kmGDpuJ+GzXPwXWYY3lc46zAu7a1h/T9u9U64PW72XmWjaTFTGu8gD6bsWtqJfqPmoPYvddBnwge83orblLtSNLC4+lE3sl5IpzkywHAYR0enE7q0N2sXJzsj9QcGHvPKGEfJNCTE2snaDe0ezTfpHxrdEw61B4Unv99kZQrHH6oGAei/xm3VuqrOcSR0Mn/V8iO2Unwk/x+oAIXnxEthnJjAwFS51xfzHoOZujgHallb8smaa8e9xczXGn6n3RosBydPYZx6ohag23Wc9ys4xE4v/g7VY6b3lfTN0TLuvc0ilcDymuc4M8tP2hGXH1ty1fNDvac4H4TpQMYT+9lEaeJJLVPv2Sr8IyO0izkbBpf/Oskn/vucOUB7e1f2KzX9X3Oq224QJW0V1CwywD9i7O23uclWvzjfx8I6jEQeTNm2ijHOcAsFsTVLczpkGdwfzM7rOxIFdHdxbPwxVMce0fFxy7Cggnp1kZ q5PiLsqv TSJ0x/FKIz6OmltpZspZnPdwEKtgFuWJFqPye6tHn2VW6ESy34uyvgjqZK2RXs3m6udp7IfRJgJDmN9OpFpSQK+GzruTYAjpKZd0HULA5FAD450xMfyvxwfwirE9hJHX9wdRh96M5HAii5RhvX+q1l/VHr6vGwEQ8TgKGHNWq9aGCG5qOZib2qayqiXyMfzusWzSf2gQ64AbtKaM8U7h74bDy/2VMLc/5sQCF9TCBRxCvgWMD+PB3vcDuYLmmK9I0r/pwvo5gHegLIrDFYPqFrFVeqxmD1K9YhPU6zJNDxdjZKR+dGK+hMCpI5fqIg6k+vsK7AjcznrFdZAtTAeZFSZXHjGswfkbwQZYW0hdxibKtjwWQ/sg2k9iw1pCx6KF+FXYXrw/l5hCB+RJL3AVIU1HknKQNgYVaLxXUAE7iVDrXZp/h9NPMd6hpcJyT23F33oEmofXIWJcF+bV9LJzUbg8pmjDdaBnGxyvL62TQK+3PFhA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.10.24 16:14, Kefeng Wang wrote: > Remove __shmem_huge_global_enabled() since only one caller, > and remove repeated check of VM_NOHUGEPAGE/MMF_DISABLE_THP > as they are checked in shmem_allowable_huge_orders(), also > remove unnecessary vma parameter. > > Reviewed-by: Baolin Wang > Signed-off-by: Kefeng Wang > --- > v2: > - Add RB and send separately > > mm/shmem.c | 33 ++++++++++----------------------- > 1 file changed, 10 insertions(+), 23 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 247c0403af83..e933327d8dac 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -548,17 +548,15 @@ static bool shmem_confirm_swap(struct address_space *mapping, > > static int shmem_huge __read_mostly = SHMEM_HUGE_NEVER; > > -static bool __shmem_huge_global_enabled(struct inode *inode, pgoff_t index, > - loff_t write_end, bool shmem_huge_force, > - struct vm_area_struct *vma, > - unsigned long vm_flags) > +static bool shmem_huge_global_enabled(struct inode *inode, pgoff_t index, > + loff_t write_end, bool shmem_huge_force, > + unsigned long vm_flags) Please use double tabs on the second+ parameter list. > { > - struct mm_struct *mm = vma ? vma->vm_mm : NULL; > loff_t i_size; > > - if (!S_ISREG(inode->i_mode)) > + if (HPAGE_PMD_ORDER > MAX_PAGECACHE_ORDER) > return false; > - if (mm && ((vm_flags & VM_NOHUGEPAGE) || test_bit(MMF_DISABLE_THP, &mm->flags))) But where is this check for shmem_getattr()? -- Cheers, David / dhildenb