From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A5B9C46467 for ; Thu, 19 Jan 2023 22:24:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9A586B0073; Thu, 19 Jan 2023 17:24:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A23066B0074; Thu, 19 Jan 2023 17:24:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 876006B0075; Thu, 19 Jan 2023 17:24:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7221C6B0073 for ; Thu, 19 Jan 2023 17:24:52 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 547DDA0DFD for ; Thu, 19 Jan 2023 22:24:52 +0000 (UTC) X-FDA: 80372979624.01.9878A47 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2049.outbound.protection.outlook.com [40.107.220.49]) by imf05.hostedemail.com (Postfix) with ESMTP id 36B3C10001B for ; Thu, 19 Jan 2023 22:24:48 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=DOqe6cSA; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf05.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.220.49 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674167089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EZaMfnVMntrY4FMm/5eS41ZsOM82mlHbSMuWAyMvDKs=; b=CqdDmjx6U7Wj+oo90YXey8tBmXFYIZp88hiRMgzGh95mraRVGunTIYFUzwuqCxozAzXbqA h1l6hRCqb5X31MIEBNDnmO3i0lt5L1B/ggW8i4S1F4ffeM+rkOQs57Vv8n9bbFdkFYRYzC O8shQNHdrq1qkm3itKiKUp1/L7nkVfk= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=DOqe6cSA; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf05.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.220.49 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674167089; a=rsa-sha256; cv=pass; b=hZ8QjLNxKSKufG+C6xkb9vCKeoJ0c5CCSj+FBb+tWQ/r0fx763m568vfy3mXfIm4HlAjwh uhI2AR/W4/7Ks76NcvL9Z6RRNku0DGVxT6+Au0AbRzEZRtxvuMOinWXN66HOp8potFz9zC oJSMctKg4SxxKG2HF/V0SkmPMWL2fI8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZTuH9x9QOubmiVA63dYgMKPRitMjXLQVQKTFsHlco3PWLEOpYnJXoZgS45ppz+7c8SD8FajFNG0bmMyjDGndYWsCFKEGlDhT88cwfhwFzJHDV1d+ZNgE8xwUpRqGoWG6N7ebKyA32/Y4lCrMwfQHzfXhrVY2G7f+HLopDMt9s2EHLvs4Vc9ihKELzeYzDW0T00ARc525QXMJ4OESxxklhmwXaDmcjqBZB3YAsUnw76xjUzsK/2URgp+phbZQ9RyfvKh/aeb7fBPBFVKg3pboHeaXmO42Xq+K4nxXJ41d39e3/T2RGDXCdgbheRhDQvynVyETqdlc7qHv0zj7LGSOqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EZaMfnVMntrY4FMm/5eS41ZsOM82mlHbSMuWAyMvDKs=; b=Pc5K0lhJ64cNeU+i/upbbiM4xWNbQ5DEOLOsk6pzrtzxOnrlMdqwuA1o3wrl2g5Dux26ID0+9HL4X0RgRd41Xuwkci9chUyXef3k4h5GhMJ7r5y/GTsmmym+DTrQDY9enT8WCfUrMF1xpVshnr8s/jbM+Hw4bXyGcmFNTLX240A9fNf+9wDzhN2tkNqgPPuSdKjCFsQs38lMuShff0gMOuyZWQ7Ma0yZu51vd2zKWUNsp2GFmf1dyknsCg9BpSqIBa4mX/G6Zb23DUXfTfPGbNso5DKNJwc5Ww9jUBy8GK/O+u2ukczQ3o9LQqojiJI0r6Gqz/uDk9T/C7PCcL0zAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kvack.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EZaMfnVMntrY4FMm/5eS41ZsOM82mlHbSMuWAyMvDKs=; b=DOqe6cSAwqJaRSLkjToUKxXUh7Gg80+z/LrmIQ8vv1s/x6rnFA5ar9nPLrRJCbZKJjfCN3LIvR+QB8GSVDOdgfulJZK1FK3ZTGfrNbYRXlNLN/DRkMUj8VqoLk3h7zlgWgUYwv1xwDZTBgqfzuu0GMHMQrk/MiycD4VH1ZdefSWzne9mZqCgEHtG2Bj6jPWlT7gBLkqScP4FLP5ftsjy09lNVy7y/x6GoCrmGIoxmKL4qIDeC1IT2c/vDzmWY2jhn2UZHUpvZFd5TT7FkGdIsI50N95g8DHXYeuvyKLQ4Jxi7PeDugqDWnTSLAlU2i9lzVciVeSZRWLjJ/d3+TTyWw== Received: from DS7P222CA0027.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::35) by SA1PR12MB6848.namprd12.prod.outlook.com (2603:10b6:806:25f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.26; Thu, 19 Jan 2023 22:24:46 +0000 Received: from DM6NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2e:cafe::3) by DS7P222CA0027.outlook.office365.com (2603:10b6:8:2e::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.24 via Frontend Transport; Thu, 19 Jan 2023 22:24:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT063.mail.protection.outlook.com (10.13.172.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6023.16 via Frontend Transport; Thu, 19 Jan 2023 22:24:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 19 Jan 2023 14:24:30 -0800 Received: from [10.110.48.28] (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 19 Jan 2023 14:24:30 -0800 Message-ID: Date: Thu, 19 Jan 2023 14:24:29 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/8] mm/gup: don't call __gup_longterm_locked() if FOLL_LONGTERM cannot be set Content-Language: en-US To: Jason Gunthorpe CC: Alistair Popple , References: <2-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> From: John Hubbard In-Reply-To: <2-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT063:EE_|SA1PR12MB6848:EE_ X-MS-Office365-Filtering-Correlation-Id: a3d29722-12c7-48bd-5a76-08dafa6bf875 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oEEaWec5b7SmyMVRU4SD09ZKM/+DrPlXrY7fcWuTV9f1GuGCikFGpUN/SYHHuqk58ezA9aEiQrxeoFkbUZfl9lx5NFSff/k9KwwnQCXgsE6OTXjCy9bd9kLKhQ+NTCGwxY7lVJiz0/r4BncglfnVV1fGyhNulaTHQ/luLy+VlRRP8bauLcUTWoDQiX+gjB/AQOmTzB8kIfJzghN+acm4YUCBx3NBbs3gQOlVMac6JxapFS7oSHQDxHaZ99GWMP/aM//tj2Th/7yafxAKkcku8lOPjtTFy+fkfVr+mgZR3FtYQ4yHgfvC4o3U5gqla4n5jDLsr5k3pZrIwWCoCCmW6qtJgV4LojsO78EmpO3Fwyn0oBZ8F/sUOXOd59QxtrzivUS0PISFQDioUNsNoH2+Nxbc+xfAdKLNzhco1rDlXD0ARGmWEjmo6+S36fnSujwTLdC625LGkC+Db3IQOW/fIoTR8U3qGKSY/6ZWXfQJIJXiG8iIfn9e7a7+JPiKitW0LXpdfeWe0yhAb+FTfecGr3OxnpYQfQ65tRPrcmyyXiU/mhb4lB8N9IHunoiK+aw73xe7SDAsq1v7yiTbdty7lPq8dpHx1lxdyiMIMOzDwpMfT/GOIynvD010Fd2akF9jq2iedMtd+pUUQJylC/nOE4vyOce38WQ2KanvmUEEuo18YrbGuy+ppjUV/8abVnpWh9MVHpz1VjS4TwRgO58/g3Um8FIKe7qRbn9NNEi/zPA= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199015)(46966006)(40470700004)(36840700001)(82310400005)(31696002)(356005)(31686004)(40480700001)(36860700001)(53546011)(478600001)(336012)(86362001)(2906002)(37006003)(316002)(16576012)(54906003)(4326008)(5660300002)(82740400003)(2616005)(6636002)(70206006)(70586007)(40460700003)(47076005)(83380400001)(7636003)(426003)(8936002)(6862004)(41300700001)(8676002)(186003)(26005)(16526019)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 22:24:46.1825 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3d29722-12c7-48bd-5a76-08dafa6bf875 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6848 X-Rspamd-Queue-Id: 36B3C10001B X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 3fp7e4eoddna8ywwiks6nxx8s8wituhw X-HE-Tag: 1674167088-618206 X-HE-Meta: U2FsdGVkX18sO76ASO2co2SvuYy9e1LXrvfb+XF3ZFiuVYc6U5yof+PkGjQ9aesO0YvMQN76wyeVATA78gBscfWzAqRjNW000muvLJ7CKqKZ+mA5jh+/iJHLe4CCZQy+zsYCVHvrfneI2jJ7gY1PsvR0xfOYeghQxolIcFIAiJAdVyIpwBQfhcIPZWLqZYMpulz2ZtpGPQ70b+bsmIFF3ZQ9fh2DoARfDv4ceDkANI4gncn5SUNencIsIartHb1wjUyq4HzMSg8bPFTtC6dhaRPTCdfFmmFvb90gysK/sbYSSKCOIw47azJX9Ey1OkcQObY4D8dLDCIWsNs2Wux9Gx6RbZ8ZoaVTyEhGof3b5Dh8Oh1tpSucB4ASp1QI8wN6ZSoD3VB9ysM7YhMB2f6qQka0ZXxlarwHxiucFovLxOQRl0kYVCvasiZq+0XE6l4wxrO2OLjsdtX/6WeQkvCevrKXMUvtSCh1xEeLnlTmEsNRaSVI1GuVBicegYaORKmpqBaW06gNLHihvMAdpJ2cPCYEIhgb73mfFm0FV1S6Z7k+YCMeBkxFyamD3LiyY7DxV7UO6AlsjTdBig6kdbXfNgDtZsM+EOse6dMCCV8n6aDsBl7axpXjD3KVJIyeFDQ2gzU+Jq3NGseCEnUXgfNWelthmWZxVUVMai4xPhoCs7TahlFQUxUDulpxTgFFYgv+nRvS4BSpvyMN2F9UIz4obkQF2x6ArIApaUXAweAJiQfLdaCI2cmGEXAcUK9UzPFKEinBjmgShvKa6/8V4td5Cs8ZwBqglSS75Ws/M1zRnCKDDh059eMEBG3ckl7AUY8B7nxGGFGsFUSjPpZJPNkvNojR5Rln+sdJP/3w7lekQvPWkLxWVfHCHpYRH/18Dv32bKYeh/PmwGtunJqHTnDY+RdBiDVR1IE8RFnaTTVZXt5n4cJpSH1IFx4PTywXrYRwi2D+ZA3vqZH4wI7v6bT zwrulJbW a3+w//WeBlbWl6048AsVGuWYO+ORDqjhrJKorszkWnlPUWiOKZZPl/FYSfwI6BZm3zeDXGST1BVeXxWjqydONn7ml2/tYnEe7f9N5Bvfe0A0jyR0WSQ/9UfM1tYk7vxATjqNlEuONI5R96NxwR2xigP9P0zdt+vreSclu/lfJFk9dJqPSz4W2znfcia3QgkPQc4nno6wSS2qZ1FEw9/IjU77NxgXRyo5dwF8ePu1iKSdcr4EI10SFarluxIjtMKgEBkbZ6JAE5x9YSfgKl4Mzn3sLAnllmTGgQk/ifopPwsmNXdPn77Dftl4jpTAM6gMvlKJamM46uynsF63fnjq8Oqy58c7tVmwVSzkbJqlM2h2cR4kX45xlReqhx5rLwDXsJYYNMRyVMQP3/tg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/17/23 07:58, Jason Gunthorpe wrote: > get_user_pages_remote(), get_user_pages_unlocked() and get_user_pages() > are never called with FOLL_LONGTERM, so directly call > __get_user_pages_locked() > > The next patch will add an assertion for this. > > Suggested-by: John Hubbard > Signed-off-by: Jason Gunthorpe > --- > mm/gup.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Looks good. I appreciate the patch granularity, it's easy to review as a result. Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > > diff --git a/mm/gup.c b/mm/gup.c > index 3a9f764165f50b..2c833f862d0354 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2188,8 +2188,8 @@ long get_user_pages_remote(struct mm_struct *mm, > if (!is_valid_gup_flags(gup_flags)) > return -EINVAL; > > - return __gup_longterm_locked(mm, start, nr_pages, pages, vmas, locked, > - gup_flags | FOLL_TOUCH | FOLL_REMOTE); > + return __get_user_pages_locked(mm, start, nr_pages, pages, vmas, locked, > + gup_flags | FOLL_TOUCH | FOLL_REMOTE); > } > EXPORT_SYMBOL(get_user_pages_remote); > > @@ -2226,8 +2226,8 @@ long get_user_pages(unsigned long start, unsigned long nr_pages, > if (!is_valid_gup_flags(gup_flags)) > return -EINVAL; > > - return __gup_longterm_locked(current->mm, start, nr_pages, > - pages, vmas, NULL, gup_flags | FOLL_TOUCH); > + return __get_user_pages_locked(current->mm, start, nr_pages, pages, > + vmas, NULL, gup_flags | FOLL_TOUCH); > } > EXPORT_SYMBOL(get_user_pages); > > @@ -2251,8 +2251,8 @@ long get_user_pages_unlocked(unsigned long start, unsigned long nr_pages, > { > int locked = 0; > > - return __gup_longterm_locked(current->mm, start, nr_pages, pages, NULL, > - &locked, gup_flags | FOLL_TOUCH); > + return __get_user_pages_locked(current->mm, start, nr_pages, pages, > + NULL, &locked, gup_flags | FOLL_TOUCH); > } > EXPORT_SYMBOL(get_user_pages_unlocked); >