From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B00A7C77B73 for ; Wed, 24 May 2023 07:25:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D6C4280001; Wed, 24 May 2023 03:25:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08800900002; Wed, 24 May 2023 03:25:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9026280001; Wed, 24 May 2023 03:25:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D9CDD900002 for ; Wed, 24 May 2023 03:25:19 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A8A8FC089B for ; Wed, 24 May 2023 07:25:19 +0000 (UTC) X-FDA: 80824312758.18.5FE060F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 6AC6340015 for ; Wed, 24 May 2023 07:25:17 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a1nXVmrc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684913117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IWSXqauAfNHPJuKsKdbaqQql9PsPaAFFdxN4RB2Q3oA=; b=LPMrIwiNNdQophsIKQ6KjbUyRKzk/Ti5apgcDVp0zhLl3ZRArKmVqdoztknQaLxAnM0z4J EWUnaEmdAbY+AtkLe+LYpyo8UAwUzJumfsVck02zEYFHNRXneAQBsHMdnVu2MBAVgCU6pn fV7yMz8q0cV8XpwnwwocdJho8EKTGl4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a1nXVmrc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684913117; a=rsa-sha256; cv=none; b=O3dywLAsdX68kmfTU0FzONtg68E+pz3zXgVUOlxC0NC2pnHaQFN80OYAiupKKuY4SvTxxO 0tNiwc2HkUsnoyfg5lNDQvMrDvtUGNT3huK4+yLr8nJEMbxwn/2M+6WPYaPe1rxyEDF/1c aj1hWBJYslPW0N2V6CykMaBGwokUcC4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684913116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IWSXqauAfNHPJuKsKdbaqQql9PsPaAFFdxN4RB2Q3oA=; b=a1nXVmrckVA7p71S0+8h181rwIVjmON3AQkf7PkzbvukKYHYQhoDO7svZJ0X7DA1PeCKc0 kYu5zGet3HQq4OmVRJqcpU5IcVN4QtkhSF7RBzmoBShyx/zlAAo6oVrlILJkTjhEbevc9/ OVoMlalh2E1Zw7RsuZm0K8CfyNpi/R4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-FJtKbdOrOKy4x_0UILgUDw-1; Wed, 24 May 2023 03:25:13 -0400 X-MC-Unique: FJtKbdOrOKy4x_0UILgUDw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f42bcef2acso2653345e9.2 for ; Wed, 24 May 2023 00:25:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684913112; x=1687505112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IWSXqauAfNHPJuKsKdbaqQql9PsPaAFFdxN4RB2Q3oA=; b=S+nfRGFMENuZr7xhVIsxKZX3GmJCmxhiB3bFN58PG7USunFOMZvYxe+HOqLii6aJEZ 2CQpg8hQf+1x55fbNMZM6q+DEO+7wiizdyWOBqASEQVrSvFnTJoAs9qo6fqFK73KaYMf r0ntIE7IbgLxs5qwqnSHxt1+EJGR0nc+LauNjiFqUr0+eA/ggtR0rFSxhJs3pP0X7eYC 04qGWwiI18wdcupPNjxlMaUBD9fBQxhogyqj72hqk9nrWm0AaUUmrZvVSAcXrWDiroi+ yux1PsCg+oGGzM4xs/MVg6gJqaC6+SxWeeVRBpqEGAwG20/fkOWWE1ezTpHBvHVq5Piq j6zg== X-Gm-Message-State: AC+VfDyCX9ob0WzSfPCG3aYql9KRi5oHdnH5PtjXtWDP+3/7QjvSltw1 VUjeHYZ1esFG0mJ2w/WgQDAnwF0HHdIH133LREDaxoSVdXqbN2HBdQt+ezZpfeH45xUd7VqnU1o yqnbakiOLDQI= X-Received: by 2002:a7b:ce12:0:b0:3f6:38f:aa07 with SMTP id m18-20020a7bce12000000b003f6038faa07mr7768774wmc.24.1684913112237; Wed, 24 May 2023 00:25:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7lgsff9iqzGhSfQoNDY6nmmo+TLB+2UaUr546vhBOlAYM6wzq3tdCWiwtdaOEgsdPlRlQK3Q== X-Received: by 2002:a7b:ce12:0:b0:3f6:38f:aa07 with SMTP id m18-20020a7bce12000000b003f6038faa07mr7768764wmc.24.1684913111943; Wed, 24 May 2023 00:25:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:f700:24cd:855:1c60:1ff4? (p200300cbc70df70024cd08551c601ff4.dip0.t-ipconnect.de. [2003:cb:c70d:f700:24cd:855:1c60:1ff4]) by smtp.gmail.com with ESMTPSA id h8-20020a05600c28c800b003f4272c2d0csm1270069wmd.36.2023.05.24.00.25.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 00:25:11 -0700 (PDT) Message-ID: Date: Wed, 24 May 2023 09:25:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v9 4/5] ksm: consider KSM-placed zeropages when calculating KSM profit To: Yang Yang , akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn, shr@devkernel.io References: <202305241351365661923@zte.com.cn> <20230524055851.20565-1-yang.yang29@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230524055851.20565-1-yang.yang29@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6AC6340015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: tfipxbffc578e7dny6edd8mtywhnpcm1 X-HE-Tag: 1684913117-449239 X-HE-Meta: U2FsdGVkX1/DdQ6ziGVDfagjM3xtBXGSpkLx9Oo4N0De7CbFioCJCEac7/AjRkTYPm0Ek5cMuwle0NSS9vX+FEdnOanPu3Nb1IUVUt751RouGSII2qBAFrsBnMnY1CxW0Jl0oBmOiREMMZIS4dzWamMZw3kcRAL9YqWFzKKuOda2LiywMbBzUoFKkBVvdfMHUZBi2WhzW7T3pu4vI75Ymv6uvnsYFmUzGQCGza8kmcD8poS4f66gtKh8FxqCToHfS1u476Om+gan/M+EVyendm/HhxcaBuQfgqPwJyAKMm6PQFvPFucAUwl27eGrKgxvbdGEcUxzwVXCHBGX0OkmAgCPWDt1IPUH2D/Ju7Olhstufq5eMzBuM5Ff7PZ8EI9lYitF1/y2bEq+WigV6USYROra7y0JwBQmINtpHZKpiJe5lcZGzZ7hZLyzKBglxrQ6+Z9HLsoVXOt98jSNRh75wVALSsGPrvl6jt2+9XXurzok33ixlHFWpmaTBiSZPcG7TOhR6dlqTJf9Fp95dLm6mWSQpBXcLhfzu+SQmdQ09685BcZJlBABMSDdAKVdb9jeCVtvDtNDA3qGWD73TiDZ6FzLotn42RhwFAvH+Bf5UOdu8RaLtQwzsYu6DBg6YnLe2RSho2xYbxF6j2bxFiX2MyiQ5clsTRMx4aN+zUnIGHuY6l7OgnsoOm6FLYzlCzSajWk+L6Nw44gfy9gCF1wId9fIkUyqZGWT/PpgR+4O/0h3/wP8epdNwesl9QSv8nSXun4r1KANNq7fiYvPbkzGz77I8QKnsqpf+efIMgdgPvm5d1Vn2R+rqTNw8AkcctKkeI0EF3pcCd6waB8bA0k2nK9l3qM3qsVyB5CDkqH/BnjjY4KepL1F5TeXvPFfd1D6Q54jUEKNg14xI/c2vgn2LMK9BA2fHm10P2Pq6xc904WyKVzvNwoHIbR+zNhXP0HoPoQvwmo5bSTT5Z66lxP wLS69IFa H2CVzKmXlMDYOJd1J1grW0R56NecSuloTTY0XktWNAy+sxOcSljWHJWdRmEqc5q5iQqfxl1+03XHWntc/DwuMgE8356TNPtWzw1jtoCuSTG9Z8wso9y67aAUj/arcxOA0DEGWhJ0uzuZ2TZKQC4OQr9aKnJ8+NPruG6GIQkRGVrExgEmyIFPHBvGCNGuRK6Y+JqMkSxu2/TANUUlb7Sfgv0qm1oz0AVi7yuFiGdvv+KNRN8ur9bxC+TfugVjXdquWoOHoFps/eg2R+gOghg3CXJylqPJB2yutQLE4xGuP6l0jbm2O6S93ATXyaa/zMxbmewkhhZ1wgo+Lr0NLKGjNwBUKWHcM6IM3rOcpY79qmeX++SFGyaesSp0d6MZ7eboTn7FPFHv9UFkH4C8WOo+A4FZoMNBQ1v7YhcpI/9uekfKPfMdCZzej3WQX4QxN+REdSKS4Qihvc5e36E6eGKYybqgupJ5bcMltCqyK7ZpkWtLc5pOxmzqu1XpyD2n3JXangJ1tNuHFjnAsPoEVcHB7jWwCKGO0ewjDIs+9IsqLKIiQjH7Dqp4tb2zNuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.368375, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.05.23 07:58, Yang Yang wrote: > From: xu xin > > When use_zero_pages is enabled, the calculation of ksm profit is not > correct because ksm zero pages is not counted in. So update the > calculation of KSM profit including the documentation. > > Signed-off-by: xu xin > Cc: Xiaokai Ran > Cc: Yang Yang > Cc: Jiang Xuexin > Cc: Claudio Imbrenda > Cc: David Hildenbrand > --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb