linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
	Ira Weiny <ira.weiny@intel.com>,
	John Hubbard <jhubbard@nvidia.com>,
	linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Keith Busch <keith.busch@intel.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Navid Emamdoost <emamd001@umn.edu>
Subject: Re: [PATCH v2] mm/gup: Fix memory leak in __gup_benchmark_ioctl
Date: Sat, 14 Dec 2019 19:10:55 +0100	[thread overview]
Message-ID: <b167e207-f919-be9a-08cb-1d1a56e25e37@web.de> (raw)
In-Reply-To: <20191213223751.4089-1-navid.emamdoost@gmail.com>

…
> +++ b/mm/gup_benchmark.c
…
> @@ -85,8 +85,9 @@  static int __gup_benchmark_ioctl(unsigned int cmd,
>  	end_time = ktime_get();
>  	gup->put_delta_usec = ktime_us_delta(end_time, start_time);
>
> +done:
>  	kvfree(pages);
> -	return 0;
> +	return ret;
>  }
>
>  static long gup_benchmark_ioctl(struct file *filep, unsigned int cmd,

Can the addition of a label like “free_pages” be more appropriate here?

Regards,
Markus


  parent reply	other threads:[~2019-12-14 18:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 17:46 [PATCH] " Navid Emamdoost
2019-12-12 23:14 ` Ira Weiny
2019-12-13 21:40 ` John Hubbard
2019-12-13 22:23   ` Andrew Morton
2019-12-13 22:39     ` Navid Emamdoost
2019-12-13 22:37   ` [PATCH v2] " Navid Emamdoost
2019-12-13 23:12     ` Ira Weiny
2019-12-14  0:44     ` John Hubbard
2019-12-14 18:10     ` Markus Elfring [this message]
2019-12-16 12:18     ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b167e207-f919-be9a-08cb-1d1a56e25e37@web.de \
    --to=markus.elfring@web.de \
    --cc=akpm@linux-foundation.org \
    --cc=emamd001@umn.edu \
    --cc=ira.weiny@intel.com \
    --cc=jhubbard@nvidia.com \
    --cc=keith.busch@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=navid.emamdoost@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox