From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2232C433F5 for ; Wed, 3 Nov 2021 03:39:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 34BCD610E7 for ; Wed, 3 Nov 2021 03:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 34BCD610E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6642C6B006C; Tue, 2 Nov 2021 23:39:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5ECF36B0071; Tue, 2 Nov 2021 23:39:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B4556B0072; Tue, 2 Nov 2021 23:39:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 393A86B006C for ; Tue, 2 Nov 2021 23:39:58 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 03E323E568 for ; Wed, 3 Nov 2021 03:39:58 +0000 (UTC) X-FDA: 78766215276.02.6301960 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf03.hostedemail.com (Postfix) with ESMTP id CADB030000B2 for ; Wed, 3 Nov 2021 03:39:50 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HkXZl2FVDz90ks; Wed, 3 Nov 2021 11:39:43 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Wed, 3 Nov 2021 11:39:52 +0800 Received: from [10.174.176.231] (10.174.176.231) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Wed, 3 Nov 2021 11:39:51 +0800 Subject: Re: [PATCH v2] mm, slub: emit the "free" trace report before freeing memory in kmem_cache_free() To: Vlastimil Babka , Tang Yizhou , , , , , Andrew Morton , , CC: , , , , Hewenliang References: <5f3b17ae-bff5-fd0f-cd1e-fa481f100149@suse.cz> From: Yunfeng Ye Message-ID: Date: Wed, 3 Nov 2021 11:39:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <5f3b17ae-bff5-fd0f-cd1e-fa481f100149@suse.cz> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.231] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CADB030000B2 X-Stat-Signature: fdawxncqwhuqc4mx8ixpj1gqerx8ap5b Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of yeyunfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=yeyunfeng@huawei.com X-HE-Tag: 1635910790-41428 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/11/2 22:39, Vlastimil Babka wrote: > On 11/2/21 14:53, Tang Yizhou wrote: >> On 2021/11/2 19:43, Yunfeng Ye wrote: >>> --- a/mm/slub.c >>> +++ b/mm/slub.c >>> @@ -3526,8 +3526,8 @@ void kmem_cache_free(struct kmem_cache *s, void *x) >>> s = cache_from_obj(s, x); >>> if (!s) >>> return; >>> - slab_free(s, virt_to_head_page(x), x, NULL, 1, _RET_IP_); >>> trace_kmem_cache_free(_RET_IP_, x, s->name); >>> + slab_free(s, virt_to_head_page(x), x, NULL, 1, _RET_IP_); >>> } >> >> It seems that kmem_cache_free() in mm/slab.c has the same problem. >> We can fix it. Thanks. > > Doh, true. Should go best before the local_irq_save() there. > And also kmem_cache_free() in mm/slob.c. > Yes, I will fix the same problem together in the v3 patch. Thanks. > Interestingly kfree() is already OK in all 3 implementations. > >>> EXPORT_SYMBOL(kmem_cache_free); >>> >> > > . >