From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D49CD11C2 for ; Wed, 10 Apr 2024 13:05:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D2E56B0085; Wed, 10 Apr 2024 09:05:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9831C6B0087; Wed, 10 Apr 2024 09:05:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D5C26B0088; Wed, 10 Apr 2024 09:05:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5FCEC6B0085 for ; Wed, 10 Apr 2024 09:05:36 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1A1F61C097E for ; Wed, 10 Apr 2024 13:05:36 +0000 (UTC) X-FDA: 81993643872.17.20BF042 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf05.hostedemail.com (Postfix) with ESMTP id 902AB10001F for ; Wed, 10 Apr 2024 13:05:32 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="C4/L+Gsy"; spf=pass (imf05.hostedemail.com: domain of aleksander.lobakin@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=aleksander.lobakin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712754332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n8zLU4sqmLJR/xpfjhgKhollZCmPcHplYKZtcxDUZRA=; b=EWfO1PnPTZwN2UBuM0LM/lFSO45FZq/9e/rvL3OpFc4NfSu7cOth9MI1DcWG24r6PHnO1D puNDHPnNaSvvFqFfufa+a61azeMV/hdsYJWQkJ0RmIErX9mewkbscvpvKb/cJv1PgtUwVY AbwvslAalW8zwwpU1pBkET3OPdESK3g= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="C4/L+Gsy"; spf=pass (imf05.hostedemail.com: domain of aleksander.lobakin@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=aleksander.lobakin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712754332; a=rsa-sha256; cv=fail; b=bFh5XxzZmRB//db1p/CrXnjvFRAtVvGP/AgWUs5JDqHVkL1udkaCb03IZfHJNcQ53Qk+vO ui3ecutV+jaNpKRNJYVZ13RLTL2qI38X+dD2Snj02N1W7VCqUwynpgNUVCqCtzemah6oyE z195e8mUprygKm2iRVZsHjqnZtzSxYA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712754332; x=1744290332; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=m4rJT5FowvYx/KNfcxtkyF+TB5wD8s+Xkx6vQQXNF+Y=; b=C4/L+Gsy5BEQ5F7SS7nFiseP4uHRKgX27Ri9igM7ohrb86XMH8ebS4eZ eZDwcBdYAjnS3Gp0mXa3O50DaxAORLPxTTqnkMzQhuVvKxUj9AvSt4RZP b0DA+sDEjXsxFKdFNDQQm8J0U2rjRJGqzsjlDok67QofEPJgpEx3kLLqW oX19t+h7UEk5OivrDy+VihHiiMu506naOKCwBC5oqKnVFkw7bo756TxVX GY8Ul6b779r9O7Spe/ygvTZD8rjkSN4U/5JtCuOkpyodekUz+Ud4PzPeI zfWhKiGR4rrBrMyhVKBTs+avqK7BO1bReGAIk5JtNDtLOHYXft5LNi4Tj g==; X-CSE-ConnectionGUID: O6nfUfiqTJWWmYJ3K8IQOw== X-CSE-MsgGUID: ZhDPokkjTQW18MJKcq6cTA== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="11952205" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="11952205" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 06:03:39 -0700 X-CSE-ConnectionGUID: GPg6+GWPSFWyBM5rYOlbiA== X-CSE-MsgGUID: snud1xBrSra8K4jf6D364A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="25025718" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Apr 2024 06:03:40 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 06:03:38 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Apr 2024 06:03:38 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Apr 2024 06:03:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hcuF5T4Hy+lM09r9gtqzcuHYI0R9Ny3QcvRqcuMJzRPcuD3roGuafURs1TR6kknYF4t/1WBCrokbQHw+A6CnjbpY/NcqRByE8IKZcYf626nkjorQr3Eck/55Y9jGHsf1xIe87wv8OCyxxOpKGAGVD/jtBYIICCo5k5h3VMJ//gDtmbJUBnHjaIJV9x9Gxo6L1veT5LFVDakjjzeB2msF+rR5+/k1cvxei42/dMS8xXd8VZTAdrXSVB1Th0H2tc6+VNI0CEyRZhiphGFPfo24n6oU4PHALlrPqpJSJWQR10OTOlZrK6e4zMUqlm4XG442MXGT1xfBZArne+7YiXAE+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n8zLU4sqmLJR/xpfjhgKhollZCmPcHplYKZtcxDUZRA=; b=COwWFlahsLdUiE5nWaxVgRq4mbPpOvBcmQ0SG4Jwvg70SUvnubnJbWJ/S252YC7EOIzRWR0jc9mHYOGcB0RWUn0iO1TPPayxFMl9ekRjl09TEuD7h/MRvl8KVxWe6YIWjU3a6ex9sir3YGIT6uoLV2KLi4FwYBM6AYQBeLQG+934cFpWf0qQSto67G0tgGKwmoJw2o6eRVnQUvIT0xH1zenbvZ4gvEkoY6hJsbPLqGIs5rREVmkgZzvZORS3wplvveGjZXK/Z06gWCny+TJrt4+NLg5Hh+kguU7VeYCkgFNMD50xl/ymp6LA3VqKv0WRvdngemz+8+Ljw4rB18TD/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) by LV3PR11MB8696.namprd11.prod.outlook.com (2603:10b6:408:216::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25; Wed, 10 Apr 2024 13:03:36 +0000 Received: from DS0PR11MB8718.namprd11.prod.outlook.com ([fe80::654c:d66a:ec8e:45e9]) by DS0PR11MB8718.namprd11.prod.outlook.com ([fe80::654c:d66a:ec8e:45e9%6]) with mapi id 15.20.7452.019; Wed, 10 Apr 2024 13:03:36 +0000 Message-ID: Date: Wed, 10 Apr 2024 15:01:26 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 7/9] libeth: add Rx buffer management To: Przemek Kitszel CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Duyck , Yunsheng Lin , Jesper Dangaard Brouer , "Ilias Apalodimas" , Christoph Lameter , Vlastimil Babka , Andrew Morton , , , , , References: <20240404154402.3581254-1-aleksander.lobakin@intel.com> <20240404154402.3581254-8-aleksander.lobakin@intel.com> <45eb2bf1-e7b0-4045-82b3-93b9f81b7988@intel.com> <9d389192-63c4-44e8-b863-6323b45aec0f@intel.com> <36a067fa-75c0-4e7d-b704-229deea2d440@intel.com> <61a952aa-1b3e-43c7-9f35-ab53e492305a@intel.com> From: Alexander Lobakin Content-Language: en-US In-Reply-To: <61a952aa-1b3e-43c7-9f35-ab53e492305a@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: WA2P291CA0045.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::19) To DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB8718:EE_|LV3PR11MB8696:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l3ok9VRTipD/IsAcREqhuos5bws5DQS9gJ0VLlL842dK1rma9aA2a7gWIP8kfN0ZN2DBa3ehui4DMli2d6SPtQyaBd68abOpfg2kks0aQT156TH4rLaSHmVAZz0NVbAa/mVv19NOoOJyBlumyL15W1k+upWScHHegp0tl37FDoMkDA+pICuVFtkcTJ8S+IDqQtcLUyy6EW/OFCHh1C4n5mtZBaJbUS3Gdtfs8R/8n9MSYSY9SUWCxTVn+igh827xJKLZutMsiIYzHhyqzlPRS0gO0i7NaYxfxNC6D/u3oOeiwjBnNsNvZtN5YI5Oi5An02xSH1zKOOPLMysODvT2AksU3ZZe+4zFM9Nn9yL2rQYtyX6maRuC2hVCdQ3UPn40FOHSO7gztlTLmuXrXhHkE9/XKUPv+0IM0vcgnLjmyxrSQqFYrwOcvaCud3L8vRcpJfYcJ/YsHFl5AKiGhxeeYfa7QJIcNL61GgOR+tdsvdmQEYh7c8Tin10OgC2yXY4povgiv9vYnUXJjMdrTNpJrrrIDycKpAg/7JXnO2yVN11yoA43WerH2ramWkG9cNoD0Xxr1Yyc+WAdySyuGGDe7lhgPU7g+vsAamRJF9aFRm0mlFYQ3ykjv400UtLW11MpcSGcsn+jUpmnj2rMUWflkHg4Zeu1QW3tEHZ5j7l7Muk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB8718.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(7416005)(376005)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1hKTHJsbVRMVVNPbHUvVmovTW4rN2E3WWRPdUhMT3Rud1BieUluczVhSS93?= =?utf-8?B?VDZtMGxmTStFYkF3bE0yMWIxMXE2RlVKcmFrck8yMStkRGQvdm1BeDd0cEtE?= =?utf-8?B?bHVQNjFiaFFLOXNNU1dTOHl4ZytucjlkMU5QaFdrQ2lHZVdLMzRWbTRkU0Ez?= =?utf-8?B?VDRjakFvS2FFNy8yR0tLZjRybkp1RUlWZWFpNGs2R3VJZklPU1AvK1I2NjdZ?= =?utf-8?B?ZGlVczZaUmE2U2w2Zmxkc2p2bW4wYVBoN1dIU3RSMUFyZFBubFAxZkhHL3Fs?= =?utf-8?B?NHRGRmNmQll4c0YrcUNnVVVHTm9RVkxrR01XM2NyNStXQ1BmSHg0bXIvL1ZO?= =?utf-8?B?eWo2S29tMTVMeWhBZU81ZGU3bVR6R3Jld2FXTXhHVG56UGVpcjUweTNQaTk5?= =?utf-8?B?Yzh1cWgxa2pPQWNtclVLT1pnWXh3YmVnS0Y1SnBMTXdra213aWRSU0ZBcTNW?= =?utf-8?B?YzdXM2dsL3hvMnhWLzZ4d203VVJmaXBaT21UNVUrdXFpTWFVVFE0K2VMbWtm?= =?utf-8?B?ek40ZjNwaE1RNHVDTCsvTkF2bTI1TGRDam5CUXFsbGpIejN4WTg0RVVTUGd3?= =?utf-8?B?MTgzRmk2VVJXU2s1ZVN4UkIrYWlYc0ppdXJRR0dRV3RNTWlzUGFsNmlNejJH?= =?utf-8?B?VWxKZGhIOXllaXVJYXE2enNIYVRka2Q5OHdmaXVIWllHay84VVpuMUFJdWd3?= =?utf-8?B?REQ5OHI2TVF2WUlQMkYzOFJwd1gyajdvdFNNZk04OEhNUzMzTW1LVDBGcE1I?= =?utf-8?B?Z0s3M083cXcwby9jYVVtOENoOFl5RndjSFJVdHhoczRDNWJKamR2RTNJemhO?= =?utf-8?B?SmdFbnZPazZnMEhpYm0rQUVpNVpMVzhzWGdnQ1lkRks1biszbXZZejQ4SmNl?= =?utf-8?B?NXIzYzkvUFBGSzJXMnZaZmp6VUxxNFEzQ0tVZnBEdjFOazR1bmhiME9HT1Jq?= =?utf-8?B?RDZ4bldaTzg0UnlqaS9yOUdqWS9VMm9Kb1U0UjVhWGZlOUREaXl0blFObmtr?= =?utf-8?B?NjBvL1RYRnhhWlR5N2xucnBsQllqZ0NhNFkraFVlOGx1ZjdIb2VGVmJHbDI5?= =?utf-8?B?UGZpNDc2SW9vR0hyZUwyb3NwOVJUTWVTbFlLakhCT29FUGduR3d5UW53TGND?= =?utf-8?B?OC9VWCtxVkRMTlB2cjQ1djJoR2pJMFlMWmVJb1ZqbVhJOHFCR3dJU3JhWGFX?= =?utf-8?B?T2tISnZpS0d4bzUxNmNkRWV5aVh0M0ZRSlNHenhOcWlpTS8rbTJzS3h4U2ZS?= =?utf-8?B?azFjdWlUOEpaUjc3S09Pdm9CNjc1d0lycGVpazBId3ovTjh5eVFOdVdkdjVS?= =?utf-8?B?TE4zM09tUXFaYXF6UWEvVGdTeHhCRVVXWmdUL1F5UHNudE1leVIwUE9XWkNl?= =?utf-8?B?N2FWYnMxQXE3bUpWN1IzbXJvcEZidFg4OFlsTkFCSUtkN00xU0d6aEREQlZo?= =?utf-8?B?MGZ2QkR6NGhiTjQrdXdOSStwWEJRRDlSc1Y1WnR4Mnp3VXRpYTMxdmp1c2dB?= =?utf-8?B?MlZYYVJveVNkeHRGMk1NOVFBTEFTN1NjeHpIdGxjNFYxZEhlbTRhTzBSdU80?= =?utf-8?B?MjRXelJIR1FHeWhSUDlraFB0RFNhSTRXZlduTGNaVmlIZTlPcmlrd0dLdWFI?= =?utf-8?B?V2s3UUQxWWlBdko0SzdndGdQNmhTSTFYV0MyZzV0NG5tL1FtQU1KWkt4OXU0?= =?utf-8?B?SWhvT1BTaFh6MWJPY1F6T1ZVUk1zUUQ5dUJ0OTFFWm5iTmJuT2E5SGpieUl6?= =?utf-8?B?UCtHb2tZOExOQ1hRZTRLak9CWTEreHdFb1N2T0ZDWmpJNWkrZXJlZjFVOEJE?= =?utf-8?B?SVJkOHhjTjUwYmc5dkVNMk1uWlVQSGVETStZTFd6cGRpNEtWcHRQZ2FxY01Z?= =?utf-8?B?NVJTUElXRnJaN1U2d2ZqMy9UV0h0WDZ2c2U0Uml0WVdVNTBTaS9Ga00xMFUx?= =?utf-8?B?R0FsTjl4R2xjV2tHQjFnYWNnZ1NyTW9Fb1p6NStRWWFPbCtFRUNkTkx2Ym1T?= =?utf-8?B?WmFTQmJjQjk5ei9kTWZZUms5NXR2YzhvaXEzTUZJdlZrZ3NKUFFWWjJwaWlz?= =?utf-8?B?cXB3dXNQWStTNm1wWGUyNEU2MWxMWjdwUHh0TDkyUVZxWEd4U0dPUjJUZG5N?= =?utf-8?B?K3BNejRRZE5UR2pvTlNFNzZ5aHNxcDFvTGIrWE5qdUFDUkV3OEx0RjNqZ3dq?= =?utf-8?B?SkE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e1af9638-c95b-4f81-5a50-08dc595ea1f6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 13:03:35.9970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1BdVvr2fxK+z+qD0cWVxvr+WFxrTiWwipDm75fF3XatCuE9hUn+MBh2khIJJtVuQJDGtsW0murJa8qGXtR6jK1vklVXzozVNTamnsxHTh54= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8696 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 902AB10001F X-Rspam-User: X-Stat-Signature: b5q5qo1ynqcd64zkthz1ccduh8u8k1x8 X-Rspamd-Server: rspam01 X-HE-Tag: 1712754332-465162 X-HE-Meta: U2FsdGVkX1+/Xe1o9RCRt5qsprBDbWemF5hkzFNrR54WH8CxzA/GkZxlGP8z3PUEGZzf7VdWPs8i78MudWLdez5+einbI7obFsYSBIPYN5JpBwiaQSVVLEyekTcCxctxbv3F0L7wGA3ICgX1jeZQ8c1ce4Xi4YrgTsCFE9UnJ5Qc482gTLgEMK8gWtR4xvOZMatuyu63Duj5Li95x8Mza488z3ZLa9lK2j0jMtYWYob+qgSVj2WgGt5xW9z/yk7z5V7rUQLZyqTvJje22MjNvKmjC8JWBtY/lCHQNLBIk94wgI74aaRKuU6CuYzPIxG2rPP9hq6jtaBYTDg/IOjIQbunMsyx6Kdr0tjPQ6E30lDVlB0kPXTi9awd4QTc0Vsx4nAOa7MJhYd3gPHW8m67id9ukwtEZkMYSsJWF4on0HaeqctIFiZEsR3U2xCW7l9f1qBRxSzyfED9HnIFpNqxcRdZxGqbiNbkfrIiOZxo6V2uEpRWaaGr/LHKi2eoFJ2AL/jAPFD9exZCt4LAFUuuOA7qlio+3ayx8Y1R3cCuRJSkA7v9cBNitn4s9iCuoWfeecAwxTNVlFL2AI1MJhJPAzSR4JDsMtkXaRC77+w1EkkhFHFiMVzInU7Ehs9KUdQtIi84FUR61rrp+CQiIszodS7LnoaWMeV0Ek3gBAI49bFagfPQ/lPr1iQKAdABk//z91Yaopyf8PiSOc8XEdgUbttnnW+yNWLvg66CGPpmkmtuhU88bq+61dwjWsU/Ll+dwympfNI/CWW0xvqheZULelylytx2Er4Tt3L0Eo8YH9mEcfAbtVYzGEhr84xZTQwzeQE3oN76WbezG1sbQXeUHGzBB/OFyLCGFoK1kmg5mGT5Z1dsgvS88pigeFWTbhE6Zx/6V0LCQrVXYDlXl9FOBsgUmylvDgA3ru5DWQHegPc40bVzdlvCJjtlovg9X9PKWN6BVEqcPU4Bi1g4jtU OTG/XJ6G ScYis6kdw3UFek9GEWjEdnvIXVQKBWjvPJlU7YJHDQroyIX0CNdrJhch85ByBDYHPKYRLVEFjPGuZoM2V9sntiMAud/hYyQgRZMQExTUZ/ejqmFiY/y6MEN1gVU/5zZYQVU5OrvmgMN1vv63RXD+GW08w/b6aaU5csHotGatrlkh0vcNV5DgFxOMiKXqrUSwEIsNsebtQyvqurAxoZKyr8oY4jHFx/yeV023R5X4yDAhqPsWxzfNbYrRWN9SoYXOyYme0xyRHSCgJT911iRgSITb4akBBBE9zCAGpbu6ewDm4DIcz97m3KmuOH+BOE22Oeo04lbkeTK4R6XIE7mNMC4JiCfBsbAOW0APuiQyb00Hrd54YUL677K7CyEJueR1KmWhZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Przemek Kitszel Date: Wed, 10 Apr 2024 15:01:32 +0200 > On 4/10/24 13:49, Alexander Lobakin wrote: >> From: Przemek Kitszel >> Date: Tue, 9 Apr 2024 12:58:33 +0200 >> >>> On 4/8/24 11:09, Alexander Lobakin wrote: >>>> From: Przemek Kitszel >>>> Date: Fri, 5 Apr 2024 12:32:55 +0200 >>>> >>>>> On 4/4/24 17:44, Alexander Lobakin wrote: >>>>>> Add a couple intuitive helpers to hide Rx buffer implementation >>>>>> details >>>> >>>> [...] >>>> >>>>>> +struct libeth_fqe { >>>>>> +    struct page        *page; >>>>>> +    u32            offset; >>>>>> +    u32            truesize; >>>>>> +} __aligned_largest; >>>>>> + >>>>>> +/** >>>>>> + * struct libeth_fq - structure representing a buffer queue >>>>>> + * @fp: hotpath part of the structure >>>>>> + * @pp: &page_pool for buffer management >>>>>> + * @fqes: array of Rx buffers >>>>>> + * @truesize: size to allocate per buffer, w/overhead >>>>>> + * @count: number of descriptors/buffers the queue has >>>>>> + * @buf_len: HW-writeable length per each buffer >>>>>> + * @nid: ID of the closest NUMA node with memory >>>>>> + */ >>>>>> +struct libeth_fq { >>>>>> +    struct_group_tagged(libeth_fq_fp, fp, >>>>>> +        struct page_pool    *pp; >>>>>> +        struct libeth_fqe    *fqes; >>>>>> + >>>>>> +        u32            truesize; >>>>>> +        u32            count; >>>>>> +    ); >>>>>> + >>>>>> +    /* Cold fields */ >>>>>> +    u32            buf_len; >>>>>> +    int            nid; >>>>>> +}; >>>>> >>>>> [...] >>>>> >>>>> Could you please unpack the meaning of `fq` and `fqe` acronyms here? >>>> >>>> Rx: >>>> >>>> RQ -- receive queue, on which you get Rx DMA complete descriptors >>>> FQ -- fill queue, the one you fill with free buffers >>>>     FQE -- fill queue element, i.e. smth like "iavf_rx_buffer" or >>>> whatever >>>> >>>> Tx: >>>> >>>> SQ -- send queue, the one you fill with buffers to transmit >>>>     SQE -- send queue element, i.e. "iavf_tx_buffer" >>>> CQ -- completion queue, on which you get Tx DMA complete descriptors >>>> >>>> XDPSQ, XSkRQ etc. -- same as above, but for XDP / XSk >>>> >>>> I know that rxq, txq, bufq, complq is more common since it's been used >>>> for years, but I like these "new" ones more :> >>>> >>> >>> Thank you, that sounds right. If you happen to sent v10, a bit of code >>> comment with this info would be useful ;) >> >> The current kdoc in front of each struct and function declaration is not >> enough? :D >> >> Thanks, >> Olek > > I've asked my initial question just after reading it thrice, without > your reply `FQE` was as meaningful as `ABC` In the commit: + * struct libeth_fqe - structure representing an Rx buffer :z or you want me to expand FQ, FQE etc. abbrevs in the kdoc? Thanks, Olek