From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC42C6FD1C for ; Wed, 22 Mar 2023 11:38:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC5B06B0071; Wed, 22 Mar 2023 07:38:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E61F16B0072; Wed, 22 Mar 2023 07:38:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D16C76B007B; Wed, 22 Mar 2023 07:38:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C1D8B6B0071 for ; Wed, 22 Mar 2023 07:38:40 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 90C20C0379 for ; Wed, 22 Mar 2023 11:38:40 +0000 (UTC) X-FDA: 80596336800.30.DF44E1C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 86DA64001F for ; Wed, 22 Mar 2023 11:38:38 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XkC+hBDP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9S0qNlnP; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679485118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ACmf/e6GIqWgaiPzBNT4x7+Kv9jhlsP3bBI1WXiL5sQ=; b=ZpkbC+b+n/BoH+ogZ33HFStdDOswoeKoB7HT2oqBAXb+5a960iI3BCAEE2HYNxeZ0iHc6M I6LW2jaqe6ndRcj2S/BvSo5CzYf+A3lIZKgvoaabk++/v2ukWGa6ae/cm8WRsSlB3jh2jc lQJJU1zBvi3mJIWyoaLaYtQHd76JWnI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XkC+hBDP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9S0qNlnP; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679485118; a=rsa-sha256; cv=none; b=zFuQIx6bj2j9RvWOZQQs/Dh6LJvw/e314KNNJc00qUkvlkpWUn6GLFn19UaIgtE4ZivsYa qpgGRoTBu8+ILrJYT0VxExBXAGn6PdZO/rracxUrFnHOHAtr+b2VoEv3Xp/CTDv67CKb2b eykOEitdnFNL0iM434R75G84bJRyA5k= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E1F2120D14; Wed, 22 Mar 2023 11:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679485116; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACmf/e6GIqWgaiPzBNT4x7+Kv9jhlsP3bBI1WXiL5sQ=; b=XkC+hBDP49DG9KapLMUn6yj/98rHMFj5kGMMw0VFNmL5Hz4juw+9zhPhVFrs4DtrkA2aqC Zvunu5IOqgA0eBM25BHbf+C5cozKTb18fzC3ptVp7GDjQX2y3cOiJ371yheex4mMR853zf ZHLJbLLF1hbeG13yisFzfhnWgVEoanE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679485116; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACmf/e6GIqWgaiPzBNT4x7+Kv9jhlsP3bBI1WXiL5sQ=; b=9S0qNlnP2O19sv9CyAM3LZu7cViiQHMM77jSkLNC6ivxHw9kmUw4glf35QHY2lmYWqKwGr IQ5/FN6/Q/L02sDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B9D2613416; Wed, 22 Mar 2023 11:38:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id leajLLzoGmTfPAAAMHmgww (envelope-from ); Wed, 22 Mar 2023 11:38:36 +0000 Message-ID: Date: Wed, 22 Mar 2023 12:38:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 02/14] mm/page_alloc: add helper for checking if check_pages_enabled Content-Language: en-US To: Mike Rapoport , Andrew Morton Cc: David Hildenbrand , Doug Berger , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230321170513.2401534-1-rppt@kernel.org> <20230321170513.2401534-3-rppt@kernel.org> From: Vlastimil Babka In-Reply-To: <20230321170513.2401534-3-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 86DA64001F X-Stat-Signature: mpm8pb69wnrenuntwbbs1jog17455s8f X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679485118-656099 X-HE-Meta: U2FsdGVkX18to9DehvwJ2LRMNOyknaCryCROJ5s/rAzZ5FcBJXAsUo9SiZqn6HT+9MUHPEjPVX8S9dGunlawRBFPAn1KIqG9kKCbA+8LAIZvLTgagXXHI9mUWsBqwCsnlFcHDdNADL43hbXb/ci7n55J5Pld6H0sAhRmSvQhxTd73154SN9ATeVv/04XdGNWN7aFPimhE64uua9vW58Gc+ODAF9LazSdwx7ASQUmCaM1BSI03GwItIL2kqvLMt7BLRdJ1TKRB0n2KEkBXTm8wdbgzy3lYj2YfLENfae40jhMGHGxv7z+Wm2NCY3+TyARQTvBY7CEL21+p+zzOah7GQw2CTYqm/VXvRQQWEpTia8JJngk+x4kNLjCIK02xYwhkkX7o6ACrVA12B6gzjj03mro9cnvpgdSf0jykuMaiKoNFtU1weIYgWV7rVw3AhcK47oON3CCazLlgxEtKE/w76nt2euKG3OD8ALNPuP5GdEyd9gPOohDe01Co/ZIf7QWc3LGnbdoLW1t3ecD9ZnFbL0re9WyToJq+lE1BSh8xsIus5DywN5SVAk/Xr355YFyG1p+oaJsa9+TitoVQIsjxBUX/1//M7p795/3VXRsvMLZddaxmVCqwqMoXS7x/rK5YyrKeq/WRP2J1qhmCJjfuo0linAVajxY6DezWYhnnR23J111GzCAd6iaSvWqvpdjzz/M7jC+AXBRxrj3mYbCauzgb6p3u2O6dQjEA1a+Fhkj+h++1/aBBPGZMyCtut2oyWzhwf3QUlptM2Eczpt4peA5MvI48KqVv+m1QuLJw0oO6Cl8ejPqWoQ6UNTdiPn+wXcm55/CRvQUz2arqYPe7dXJXsMz195/5ef+psNx4StaB9usj+4hEH5/De2pWco+scMTF573F2ViH3DCWxgaT/eF1PytSRViWqhT+DwWrhQ5Fvr+QLtZr7r4OFmFGptOI9LSVY23xVnDG78lUIX aAiquNiJ OKKcGUBnjjjOdwPWQv/pb0m5onhQqHHERnCYvPsSB7mdcVhYgah1gILy68k6hZGvf2OyTcg75ltJb2zx6Yrz0b3DAfPlptYi1m6nCwc4WLM50SvI+PaPyAkhTuwJetAHqTEVN/p9yT8V4yIAhyvOkaRPX3rGYl39msWXDPWAPh+AbNTDIgUyYcCq2AQw4MuJ1o06QaLwDYzdXSYe2QK9LRWe8cahVLyBnIrSUvGkgDcQPlhtX1vNcug6xm5s4t3qVAUX54JfnSZl0G5l1zJ/XjFF4lOv5chFKnA49MqFKj4zGmsjdNiMntb0xtCTmG8J773rnG0C4pe/vdy17Zy2gwKhgKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/21/23 18:05, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Instead of duplicating long static_branch_enabled(&check_pages_enabled) > wrap it in a helper function is_check_pages_enabled() > > Signed-off-by: Mike Rapoport (IBM) > Reviewed-by: David Hildenbrand Reviewed-by: Vlastimil Babka > --- > mm/page_alloc.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 87d760236dba..e1149d54d738 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -245,6 +245,11 @@ EXPORT_SYMBOL(init_on_free); > /* perform sanity checks on struct pages being allocated or freed */ > static DEFINE_STATIC_KEY_MAYBE(CONFIG_DEBUG_VM, check_pages_enabled); > > +static inline bool is_check_pages_enabled(void) > +{ > + return static_branch_unlikely(&check_pages_enabled); > +} > + > static bool _init_on_alloc_enabled_early __read_mostly > = IS_ENABLED(CONFIG_INIT_ON_ALLOC_DEFAULT_ON); > static int __init early_init_on_alloc(char *buf) > @@ -1443,7 +1448,7 @@ static __always_inline bool free_pages_prepare(struct page *page, > for (i = 1; i < (1 << order); i++) { > if (compound) > bad += free_tail_pages_check(page, page + i); > - if (static_branch_unlikely(&check_pages_enabled)) { > + if (is_check_pages_enabled()) { > if (unlikely(free_page_is_bad(page + i))) { > bad++; > continue; > @@ -1456,7 +1461,7 @@ static __always_inline bool free_pages_prepare(struct page *page, > page->mapping = NULL; > if (memcg_kmem_online() && PageMemcgKmem(page)) > __memcg_kmem_uncharge_page(page, order); > - if (static_branch_unlikely(&check_pages_enabled)) { > + if (is_check_pages_enabled()) { > if (free_page_is_bad(page)) > bad++; > if (bad) > @@ -2366,7 +2371,7 @@ static int check_new_page(struct page *page) > > static inline bool check_new_pages(struct page *page, unsigned int order) > { > - if (static_branch_unlikely(&check_pages_enabled)) { > + if (is_check_pages_enabled()) { > for (int i = 0; i < (1 << order); i++) { > struct page *p = page + i; >