From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84BEC35FE7 for ; Wed, 18 Sep 2024 05:47:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4288B6B0089; Wed, 18 Sep 2024 01:47:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B1A46B008A; Wed, 18 Sep 2024 01:47:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22B876B008C; Wed, 18 Sep 2024 01:47:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F3E2E6B0089 for ; Wed, 18 Sep 2024 01:47:10 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8E612A0290 for ; Wed, 18 Sep 2024 05:47:10 +0000 (UTC) X-FDA: 82576775820.09.38CE362 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf25.hostedemail.com (Postfix) with ESMTP id 838C1A000B for ; Wed, 18 Sep 2024 05:47:08 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=g3MPvTni; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf25.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726638305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iKJ2Z2LF++Va2+fKB+g4dCwU0h2IjZbNElFAVxljPHo=; b=HK4O62GNbCSpnPcxltPwJVh1aw7aNCcDAO32NfpYnUpNwvPCOEbffe23sZ2cz2YiPBxNO2 hJOzs4qgE4rw/QSKlM2lK1y+BEvRdEVf6+8+gajpnXVE7GJFqUQMwlwLwman8mIEz8r6xJ zM94tK8w+WuVoaDW6w8T0rz1G2L9Vhw= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1726638305; a=rsa-sha256; cv=pass; b=jzQq7DIS5QI4NZMK3KFGXvDtOxE4I+SmahAOJHomvAI4OQFhMpanFgnM3FqPzkmIzYP5Ix OT7FnQUMwYOM+7PyGuBV+g7Vl2vRHQ1YaSgdvi7JZYOnZsjYYQlB+FXUJ+p4+G8SoeBFE5 BgfKZaaWYIy+8HpLwG4BAfgFF0I67Dk= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=g3MPvTni; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf25.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Seal: i=1; a=rsa-sha256; t=1726638415; cv=none; d=zohomail.com; s=zohoarc; b=CtvDb63jnSh7rbvw0/3klU52TLpnQFs8yitcqDtFjnJahWGmEYW3C8yEDm86hIkLQ7rJ+DxPxd23vitqgZsr+9Wfk6cLyx+KUUnJKygVM8TPjMu3R+xrol0/4uHTs1/sCxBuZqXnZmSNpDSO2nGDFynCorfr45bUpdfMcyNKaew= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726638415; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=iKJ2Z2LF++Va2+fKB+g4dCwU0h2IjZbNElFAVxljPHo=; b=mieqEgagifQExr0ga5CipvX+m4jrc0R2tKcKgwfCgq/3fFjOa439/xqGKjkX54MoD4hCR68iSYvZmAVLe3YJPkxzzmemoh2Hf4Z2sbFcL71QroHwOtjHhDpGeF2f1UYEeFdsFxxWt9btftdDYtCfyaNX9kZw7VNzwzwf/Qdhyvo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1726638415; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=iKJ2Z2LF++Va2+fKB+g4dCwU0h2IjZbNElFAVxljPHo=; b=g3MPvTniKk5CTLWzjGex0HInh9u1TynnkxifDx4T3cvMYZAbwyWcsTHnEj5qrLtA XQzopDSYrRpIThWLdYXkPx2oeiw+WGwcyXfQKcC3OYLq/yhN6dtg+ROYGmqXh6qyylF xtlQ/DujJH1BirGaTp0DTEvqM+ywCLCw5K2nSAzA= Received: by mx.zohomail.com with SMTPS id 1726638414435979.5166100226369; Tue, 17 Sep 2024 22:46:54 -0700 (PDT) Message-ID: Date: Wed, 18 Sep 2024 10:46:47 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, John Hubbard Subject: Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value To: Shuah Khan , Andrew Morton , Shuah Khan , David Hildenbrand , Peter Xu References: <20240912103151.1520254-1-usama.anjum@collabora.com> <3cb9d266-4d4b-4031-8603-da7fd9e3ad47@collabora.com> <0b847784-a95f-4ed5-a0fb-1b7b4023df13@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <0b847784-a95f-4ed5-a0fb-1b7b4023df13@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 838C1A000B X-Stat-Signature: dqowe4byk6kdcnth1boyom7y8fonguyu X-Rspam-User: X-HE-Tag: 1726638428-482620 X-HE-Meta: U2FsdGVkX1/qQcMzAClwV4lNfhiSqQCGSYdn1wWPJWChKVIzFy8fhtPQzGOBfkliMa55V54gXNGtcRJVAoFzrHsRM6p9/zRE14lyMErKStZazF3QuLAkTnMHAJ5LR5Xh5OZJwVjil5BfyQL1+qhWu+vXbRcLUGTq0E8mJK3MoD6/fnANwK5D4niH0RVZar+ctyklQMbZqzBhun/spccyrzP2f7lSH34wSWMqHRTVCWhPcqFj/M5ctfdxFS4xaX1t/3ZltYU25CbKOiNnQrXIMz8hSAWLuF+Q+8A6rbIFNkLvgsTRBVHNvm6vb7Z/YPLjTT6SsT5GeTU7O7MBBozdPj7hQITvuvRRmgPZn7mbgmDBXpbmktvp4SM/16MPV3BzBK1CNAkOEblH16CTi5uSKzinszPZnaWqj3bzqX0mBAMCw45/o5A1TFkwuvnYxBlLOYiPJMuw9dJ2qfT1zLxjABFX4JEDEnVCPvZz0UrnkIonaDh8ZY+pOIPk3WJ95xXOjYauysLttJfk/KCImOYBNp8ikV64v4xSK4AebFDnsuZ01y/ee3sXhkej3Oxr8M1hui8g/crwk91lFUtQOpipJO/WhQkaJdDX4QVzRsRyAb0rT35S4yp3IKWX/HQTHynhhrqemFHbPtI+s3rLIQWS03P+UBzuzMgpB/bmsiVCQOklrdGuX7LGJ+oYfWMygDR5yOwXI22dEEMEcBtJ+ssuq4bPCU0N/pwen7p6QmfitmTYKzI0eyoy9BkX7W4Duf/hrfCM901FQ6nnfc43Saxcw5gMGTi6mKVORX/C8qFSDx5g9HH7EPZdNL9HhrfQygJHtJQXHjjwo4EX+jUc+nsnzSjXXOYWYExjdiBcIT6iW5VjHkWB/LChcw28nBLp1MuE0MCYOclGkJxK3WYTTPaX19e/N6HmFHRmr6ymPnkCxJWSx4TzyRuM/jbay5IrmZqdmqtYADkKslIpSF3nSK4 mVA157aX ixRB9uedoVXrBXiNqjI8Cpxg9yshRl82ozOtmI9nbYGRZpCTgkswNENaol3MR/gws/DvnnSmOtz5Ni5N9G+RodRaU7HQgT3H50vFs7ilfrPjX1OawkMqfy8RKixuS6G/GxhkYFSet2c+jKwxvnYf+2/7prnjcZ+v0Z1NNIoBiYVjNRAZrPgS7YNQHgbn3OikPHjte0gNklU3dXt1b08GRAFkJyC0lSjN72dtSB4cnjddIvOmfBu+S4FYognKGbQLgtyhp5nWffnkXXDtzZ3oMgufGoHq9f0e2//XkFbsrcpTHbfOo1smx5FmbpxYDHsaJyNTaSxPA4ogpGYBO5xLR5GpAD6W6ncNEEbMAd4jZdwaCEho= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/18/24 10:46 AM, Muhammad Usama Anjum wrote: > On 9/17/24 6:56 AM, Shuah Khan wrote: >> On 9/16/24 00:32, Muhammad Usama Anjum wrote: >>> On 9/12/24 8:44 PM, Shuah Khan wrote: >>>> On 9/12/24 04:31, Muhammad Usama Anjum wrote: >>>>> The value of __NR_userfaultfd was changed to 282 when >>>>> asm-generic/unistd.h was included. It makes the test to fail every time >>>>> as the correct number of this syscall on x86_64 is 323. Fix the header >>>>> to asm/unistd.h. >>>>> >>>> >>>> "please elaborate every time" - I just built on my x86_64 and built >>>> just fine. >>> The build isn't broken. >>> >>>> I am not saying this isn't a problem, it is good to >>>> understand why and how it is failing before making the change. >>> I mean to say that the test is failing at run time because the correct >>> userfaultfd syscall isn't being found with __NR_userfaultfd = 282. >>> _NR_userfaultfd's value depends on the header. When asm-generic/unistd.h >>> is included, its value (282) is wrong. I've tested on x86_64. >>> >> >> Okay - how do you know this is wrong? can you provide more details. >> >> git grep _NR_userfaultfd >> include/uapi/asm-generic/unistd.h:#define __NR_userfaultfd 282 >> include/uapi/asm-generic/unistd.h:__SYSCALL(__NR_userfaultfd, >> sys_userfaultfd) >> tools/include/uapi/asm-generic/unistd.h:#define __NR_userfaultfd 282 >> >>> The fix is simple. Add the correct header which has _NR_userfaultfd = >>> 323. > > grep -rnIF "#define __NR_userfaultfd" > tools/include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 > arch/x86/include/generated/uapi/asm/unistd_32.h:374:#define > __NR_userfaultfd 374 > arch/x86/include/generated/uapi/asm/unistd_64.h:327:#define > __NR_userfaultfd 323 > arch/x86/include/generated/uapi/asm/unistd_x32.h:282:#define > __NR_userfaultfd (__X32_SYSCALL_BIT + 323) > arch/arm/include/generated/uapi/asm/unistd-eabi.h:347:#define > __NR_userfaultfd (__NR_SYSCALL_BASE + 388) > arch/arm/include/generated/uapi/asm/unistd-oabi.h:359:#define > __NR_userfaultfd (__NR_SYSCALL_BASE + 388) > include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 > > The number is dependent on the architecture. The above data shows that: > x86 374 > x86_64 323 > > I'm unable to find the history of why it is set to 282 in unistd.h and > when this problem happened. Does anybody has understanding of this? > >> >> I need more details on this number. >> >> thanks, >> -- Shuah > -- BR, Muhammad Usama Anjum