From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBC1C433EF for ; Thu, 21 Apr 2022 16:47:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98BB36B0082; Thu, 21 Apr 2022 12:47:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93B6A6B0083; Thu, 21 Apr 2022 12:47:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DB1E6B0085; Thu, 21 Apr 2022 12:47:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 6EA026B0082 for ; Thu, 21 Apr 2022 12:47:43 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3E035210DD for ; Thu, 21 Apr 2022 16:47:43 +0000 (UTC) X-FDA: 79381467606.09.1ED135E Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf22.hostedemail.com (Postfix) with ESMTP id 26E0EC0024 for ; Thu, 21 Apr 2022 16:47:41 +0000 (UTC) Received: by mail-wm1-f52.google.com with SMTP id bg25so2849089wmb.4 for ; Thu, 21 Apr 2022 09:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=TSBE+75DEItnElqK6i/9Llmt2S09XqfUaLkR6TjRbyo=; b=NXb7KRvWuPLwtdKDNwdZHcukQ9NuizddPugTM4tliMQvmLXPN1STsxMbESzFB6OjBb T0cjMh+liiDry+aW7ahUc3C6tGFvR5E4aj79ra6iTlNzdMhzUErpmpPnEni9BnZ9vOSX 2mmhQ6KobQJWeEulTngmjSbJQJLQiS77r2oLiASzrwMGfk2bcvDHGYWK5Ap/sV3Mw8LX uKbJC/tlZDHWscq3LuA9iaRm4NQPfDr+2qV8HZa96prxedIg+lCt4FM6gUq3xIx16YKL Bw6BruhZlC4hlVmbYthpwobkw3iewSzb5ZvhVJpQIJuQB9kPCUPBE0bbysLX87aQkOzY 3srA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=TSBE+75DEItnElqK6i/9Llmt2S09XqfUaLkR6TjRbyo=; b=EeIPU8KWJlpXX2ZVzncgDXGt28lmNby7Zumy3dO2RpFt+b0xDhTmSNS3kFxMiC09DO znP+yXl+RcUZp9yx3ZSg0RYLnd+mQ433Jo8CwKkXRb3z09MEhGcHo2IDxxCmi8cakZ/i KgaV6mcrKtV/SILfFCTUwRBiPFnJmgt14mDUKueUkSGvR4fLZWemNbZdOPbkYK0PoAf/ P6yyBKlmasJAID6gUM2CcJmfbgfJE+f7aHrgizT3igrxI69ldHcb0nU9OYNc1FDBzkvt do8GBUBscUDvQolxa7ddXcn7IHyRlI6Zlot2HgwP1BL4xpa0KwMd3lbxTzt64FCTsmcm YjfQ== X-Gm-Message-State: AOAM531v+F19+T4F8ZVPIhC2EHRaFhQx19g06/fIdys/KWSmCYllJawn svIMnHlN4S9ZBxCtO25QOiglHQ== X-Google-Smtp-Source: ABdhPJzOCephvK5l4jzG/E57jouUNpfO0ypqRAA/i0utRt/u5B9jDkk6ogV5WOtk3t8EIkLiIXsmZQ== X-Received: by 2002:a05:600c:3ca3:b0:392:990b:af11 with SMTP id bg35-20020a05600c3ca300b00392990baf11mr211439wmb.173.1650559660823; Thu, 21 Apr 2022 09:47:40 -0700 (PDT) Received: from ?IPV6:2001:861:44c0:66c0:35ba:2677:956:980d? ([2001:861:44c0:66c0:35ba:2677:956:980d]) by smtp.gmail.com with ESMTPSA id f13-20020a0560001a8d00b0020aab7cefc4sm2649396wry.46.2022.04.21.09.47.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 09:47:40 -0700 (PDT) Message-ID: Date: Thu, 21 Apr 2022 18:47:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings Content-Language: en-US To: kernel test robot , Sandor Yu Cc: kbuild-all@lists.01.org, Linux Memory Management List , Robert Foss , Shengjiu Wang , Andrzej Hajda , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <202204212311.TnfpcTGm-lkp@intel.com> From: Neil Armstrong Organization: Baylibre In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 26E0EC0024 X-Stat-Signature: zbzeokrks919zn4e7gk9fdw1rj3pxh55 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=NXb7KRvW; spf=pass (imf22.hostedemail.com: domain of narmstrong@baylibre.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=narmstrong@baylibre.com; dmarc=none X-Rspamd-Server: rspam01 X-HE-Tag: 1650559661-356460 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21/04/2022 17:09, kernel test robot wrote: > From: kernel test robot > > drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94 > drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112 > > > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > CC: Sandor Yu > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 65eb92e4c9f0a962656f131521f4fbc0d24c9d4c > commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver > :::::: branch date: 8 hours ago > :::::: commit date: 2 days ago > > drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c > @@ -77,7 +77,6 @@ static int audio_hw_params(struct device > struct hdmi_codec_params *params) > { > struct snd_dw_hdmi *dw = dev_get_drvdata(dev); > - int ret = 0; > u8 ca; > > dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate); > @@ -91,7 +90,7 @@ static int audio_hw_params(struct device > params->iec.status[0] & IEC958_AES0_NONAUDIO); > dw_hdmi_set_sample_width(dw->data.hdmi, params->sample_width); > > - return ret; > + return 0; > } > > static void audio_shutdown(struct device *dev, void *data) > @@ -102,14 +101,13 @@ static int audio_mute_stream(struct devi > bool enable, int direction) > { > struct snd_dw_hdmi *dw = dev_get_drvdata(dev); > - int ret = 0; > > if (!enable) > dw_hdmi_audio_enable(dw->data.hdmi); > else > dw_hdmi_audio_disable(dw->data.hdmi); > > - return ret; > + return 0; > } > > static int audio_get_eld(struct device *dev, void *data, Reviewed-by: Neil Armstrong