From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Shu Han <ebpqwerty472123@gmail.com>
Cc: akpm@linux-foundation.org, paul@paul-moore.com,
jmorris@namei.org, serge@hallyn.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] mm: move security_file_mmap() back into do_mmap()
Date: Wed, 25 Sep 2024 09:55:41 +0100 [thread overview]
Message-ID: <b124f2d4-c2fa-4285-a4f0-b07304f778fc@lucifer.local> (raw)
In-Reply-To: <64882dd5-5efd-4912-ab3d-0e6ee76380cf@lucifer.local>
On Wed, Sep 25, 2024 at 09:44:40AM GMT, Lorenzo Stoakes wrote:
> TL;DR: NACK because you sent two conflicting non-RFC patches as
> 'alternatives', which is not how development on-list works. Please resend
> maybe one of these as an RFC...
[snip]
> On Wed, Sep 25, 2024 at 04:16:28PM GMT, Shu Han wrote:
> > This patch moves the security_file_mmap() back into do_mmap(), which
> > revert the commit 8b3ec6814c83d76b85bd13badc48552836c24839
> > ("take security_mmap_file() outside of ->mmap_sem"). Below is the reason.
>
[snip]
Having said all the previous stuff - do_mmap() and mmap_region() very badly
need at the very least comments to explain how the interfaces differ and
what is provided (including in security terms).
Perhaps we need to go a bit further and audit how exactly they're used.
I'll add that to my TODO list!
next prev parent reply other threads:[~2024-09-25 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 8:16 Shu Han
2024-09-25 8:44 ` Lorenzo Stoakes
2024-09-25 8:55 ` Lorenzo Stoakes [this message]
2024-09-25 9:48 ` Shu Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b124f2d4-c2fa-4285-a4f0-b07304f778fc@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=ebpqwerty472123@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox