From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C686C33C9E for ; Tue, 14 Jan 2020 18:27:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 87835222C3 for ; Tue, 14 Jan 2020 18:27:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87835222C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 20F5D8E0006; Tue, 14 Jan 2020 13:27:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C03F8E0003; Tue, 14 Jan 2020 13:27:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FDC48E0006; Tue, 14 Jan 2020 13:27:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id EE8EF8E0003 for ; Tue, 14 Jan 2020 13:27:31 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id C8C642C89 for ; Tue, 14 Jan 2020 18:27:31 +0000 (UTC) X-FDA: 76377072702.10.lock85_419856a73094d X-HE-Tag: lock85_419856a73094d X-Filterd-Recvd-Size: 3080 Received: from out4436.biz.mail.alibaba.com (out4436.biz.mail.alibaba.com [47.88.44.36]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jan 2020 18:27:30 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04427;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0TnkVkCH_1579026434; Received: from US-143344MP.local(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0TnkVkCH_1579026434) by smtp.aliyun-inc.com(127.0.0.1); Wed, 15 Jan 2020 02:27:17 +0800 Subject: Re: [PATCH 2/2] mm/mempolicy: Skip walking HUGETLB vma if MPOL_MF_STRICT is specified alone To: Li Xinhai , "linux-mm@kvack.org" Cc: akpm , mhocko , Mike Kravetz , n-horiguchi References: <1578993378-10860-1-git-send-email-lixinhai.lxh@gmail.com> <1578993378-10860-2-git-send-email-lixinhai.lxh@gmail.com> <2020011422092314671410@gmail.com> From: Yang Shi Message-ID: Date: Tue, 14 Jan 2020 10:27:13 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2020011422092314671410@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/14/20 6:09 AM, Li Xinhai wrote: > Add cc to > Yang Shi > Naoya Horiguchi > , who has been worked on this part > > On 2020-01-14=C2=A0at 17:16=C2=A0Li Xinhai=C2=A0wrote: >> Checking MPOL_MF_STRICT is ignored for HUGETLB vma according to mbind = man >> page: >> >> Notes >> MPOL_MF_STRICT is ignored on huge page mappings. >> >> If MPOL_MF_STRICT is specified alone without any MOVE flag, we should >> indicate, from test_walk, that walking this vma should be skipped even= if >> there are misplaced pages. >> >> Signed-off-by: Li Xinhai >> Cc: Michal Hocko >> Cc: Mike Kravetz >> --- >> mm/mempolicy.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/mm/mempolicy.c b/mm/mempolicy.c >> index 067cf7d..c117b5f 100644 >> --- a/mm/mempolicy.c >> +++ b/mm/mempolicy.c >> @@ -656,6 +656,13 @@ static int queue_pages_test_walk(unsigned long st= art, unsigned long end, >> return 1; >> } >> >> + /* MPOL_MF_STRICT is ignored for huge page, skip checking >> + *=C2=A0 misplaced pages >> + */ >> + if ((flags & MPOL_MF_VALID) =3D=3D MPOL_MF_STRICT && >> + is_vm_hugetlb_page(vma)) >> + return 1; It makes some sense to me.=C2=A0 We do save some effort by not=20 acquiring/releasing ptl and walking page tables. Reviewed-by: Yang Shi >> /* queue pages from current vma */ >> if (flags & MPOL_MF_VALID) >> return 0; >> -- >> 1.8.3.1 > >