From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B02A4E77188 for ; Fri, 10 Jan 2025 08:14:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEEA48D0002; Fri, 10 Jan 2025 03:14:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4F228D0001; Fri, 10 Jan 2025 03:14:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B52FE8D0002; Fri, 10 Jan 2025 03:14:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 89D5F8D0001 for ; Fri, 10 Jan 2025 03:14:57 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3BF10120880 for ; Fri, 10 Jan 2025 08:14:57 +0000 (UTC) X-FDA: 82990831434.27.F7217A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id A84FCC0010 for ; Fri, 10 Jan 2025 08:14:54 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CD7FkxTt; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736496894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=byJiHXajGWib5D6AAppEFYrozYieWdJ98xjWWQFd7Vg=; b=jV5GzzWzhd22t8jiupxXwjMhGtbyqQI+ZL4F3Z8kh5y/rqE6ph+c6z9NcLJCDcWk4RhrSK RTgi2tRYj9Un8wlGeCgwmqqAid6L93EgXld5Vx7TeB/IOImV4Ur9lZibcvEIO9c4gJMQ9R dOZSOPLOczYs1L1iVY1siBZeoACKHWw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736496894; a=rsa-sha256; cv=none; b=JU6yG363Rj+8WoBrOag0q0R724ui7wHSoWzbjM7XTDPeZElWERWI2S/2o10QAqwa1ZqtVM XwhNPQ0J0oOnsJfEZt/CVw09Cs/7BWB7WzgM4a8rxngp6QLQMpipor3wJJsQQbYdXm4ZND RJKMH5tGnobAIP5lhzVhhFm7d33X+ak= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CD7FkxTt; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736496894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=byJiHXajGWib5D6AAppEFYrozYieWdJ98xjWWQFd7Vg=; b=CD7FkxTtFd4MS2hc9lpGXHb8jDiuS9ZJ8vQLN+NR59AtzqK5DWFhXGGazsYUflaUGxWjl+ Kr6gAqoyt62kRx/hhwEU8afLWVf1qrnuNzmYfUgtRcqBDNSgFKb0kGdFAhatk1Yk1pqr8G gXXWhtrOPCL06g7dnAl19TYeS+TS2Co= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-73-QWGutxl4PeyPgQoewgPqHg-1; Fri, 10 Jan 2025 03:14:50 -0500 X-MC-Unique: QWGutxl4PeyPgQoewgPqHg-1 X-Mimecast-MFC-AGG-ID: QWGutxl4PeyPgQoewgPqHg Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43624b08181so8690955e9.0 for ; Fri, 10 Jan 2025 00:14:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736496890; x=1737101690; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=byJiHXajGWib5D6AAppEFYrozYieWdJ98xjWWQFd7Vg=; b=iDh/p/2iahGvFh7Kx3KEFhUMteNwMwKI9pATyVtQvU1SsvE8xD8WKTu0Y4pqxSW1n6 zLF04DhZhj8qN3qz1VZr2GvJ6iMgvQwpaM28o9gMjG1ZdRbCQOxAMCGkwoVHBdsxaPL0 D3iUMmLwNi8daZeJhYg1sVVPva6WoVEY6WeCP2CMlbr4bKvtLMJ+HbEjxF85pGhhu62W i2HtGirmS3O6rAVxRDee+yS3gM2V1R/U7w0OKzIU08AkCKgcNX8xYV5sXMxBTnfrMsKo Hpnld49zumux8zP93OKHUsV5LGbs3td+MCK+eGuvl2ixuu8s0JANbS9bcQRmyfjoEKKp yUEQ== X-Gm-Message-State: AOJu0YyFZZi9dHA1fOINAcJ2ERYLNdkmqiELXW/70aHeYQjaEN43drbQ 5sxWO/1a27i0JaVsAy1NRLiiv+WvgyhabE+1v3dNO+YZBJTbhB5/50zpWbKBkVJqUpHfWHAkHqO moU2CMp2m9Y/rC9wx1OjZYC9FwUIDN6JVlXjPJLsuuXde6T5X X-Gm-Gg: ASbGncs9/bK6LoGAOCcsweo9RBsGgzV7YxoelT1VFl3JR1DJ1DfU0LkFLZUb+I4h6fj tk/FVePhRhr2gCN1ryT/vwhrgP7AZqlhnr8fugFmKq0PdheUoIIVSLRGPJwM4YDEqv2APqnCLqV D3Db+NEIudB0iR1N/ng9fP/eG1Im8isGwqFCf2JT2mZV4zu+bAqfyXCpH1/9lIgq7/Rl6Z8xiq8 OBSFe1/790G8q2f7Ir+XgWA2GBHK36S0Wax1O5WavJqggZMd0otNLm8PwCiiOj5Yw/G5rBOvTbg +52DoPQ6CBKx1V1CIrnRWRIZQPQvViYYbmBP6cvqBubdi3Xj9GVDqggdYsEFo7tqY3gM69yw807 pUPzO+IP5 X-Received: by 2002:a05:600c:492f:b0:434:ea1a:e30c with SMTP id 5b1f17b1804b1-436e8849debmr55170015e9.13.1736496889701; Fri, 10 Jan 2025 00:14:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHu2/KWZJXePrGJBskpcIH5RpS86fIWOpZfXtRTHQL6uqKyKXRl8gbefOgzFv2pGsK+AJr+FA== X-Received: by 2002:a05:600c:492f:b0:434:ea1a:e30c with SMTP id 5b1f17b1804b1-436e8849debmr55169755e9.13.1736496889279; Fri, 10 Jan 2025 00:14:49 -0800 (PST) Received: from ?IPV6:2003:cb:c708:e100:4f41:ff29:a59f:8c7a? (p200300cbc708e1004f41ff29a59f8c7a.dip0.t-ipconnect.de. [2003:cb:c708:e100:4f41:ff29:a59f:8c7a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9df958dsm44247475e9.17.2025.01.10.00.14.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 00:14:48 -0800 (PST) Message-ID: Date: Fri, 10 Jan 2025 09:14:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: prevent reuse of isolated free hugepages To: yangge1116@126.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn References: <1736477766-23525-1-git-send-email-yangge1116@126.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1736477766-23525-1-git-send-email-yangge1116@126.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZtyxIyCoKgUQXMLTFE-zT6lAYElbAJGUdM35chQNJp8_1736496890 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A84FCC0010 X-Stat-Signature: ehmb8u76hggzwkdg9cip58zq6yuh7n97 X-Rspam-User: X-HE-Tag: 1736496894-611687 X-HE-Meta: U2FsdGVkX1/6w9UOPRUkxXHjxtSzZDMXEzqDfqs07PG6KKCdufs6J5iSdpbokbMd1RMRnh/+t9VWUKOG72zgzZkTPoRDJAc0KThLOBI+Hdo+KBMi5yJc49+yMWwWkZY6iJZpDPQnbFVzHUAPBun4yt7yIGb1rwzZ+5qFq2Lo220ssN393l1vzZRMfx+tb7+fgm4oL410l3K8SSPryGotaLYMnLmZ5YRPKXjWmOiERvziwN/DsiCyp2EqabRTSMdEjHHgxuOhUSzDj42lryafUA+YEdg5jy2Y5tWZdx/4TKB1SdG3bc/I8zKjGu0uZbFNbf0TSjka5O1n4xU0K7NrRUq65tcOh3ojQOW5AOvXB6jyoRl+kn3v9FtrEK9uzLeNRXYOW0/as9pW8mIGUXPz0Yt7PocuVLbe93MWK82DVJK2NDX0F6fb5ZTxpBbLGM/O2RAR0ylr0iO98l70+mQZwzLxGraxcBOyuOuzQqzd8Ewk95NHp0o6KCS2nltdr29MJo+5MG6OLfSvdCkRdmRmGbz3PfqobEQpOV9jXqAHTSsRUAqesZKOA0gBkOpstLXxlOy80x8BYTF07G4zXd1mUsxSSB63shqTWHnxxTwW7A71LGs6QDVYPax5mcTcjlcmxHLkmunm2a1MQ3hsXIRx3qGiphxIxcqg3ht5xBA97v1VlU3JTa0W80ll26H5wgEFccDexZJEq98B/DQNkdlnV/o1RmqIKF8Fp47HuOJBSmHRcl6kXT6e7rUkv1rGfOiGOCW8OWYGZ9yO/hGDkgywcyogAc8nzfxbcOs+OR58Cuiq0yaSV2i4x/SWH4lYI1SKlRzWAZn0jEsWOPy6XTU/WyvXKX7ws3xVHDP4iIR5T/UCTKUqom0FEMkf+BQxxhXLIkpEMmYLJ91Gjq7Vjz5VL5KaHtAeVlobpgOq56Mtu/aBaNkRtOuRQVEVuk+9ftcvN/GzcJkO3lCguxC+qkW mDYPLkJI LkbqhVFm4REaAwx4bRotdnenUAdyuKOM1xBUHl9B28Ve3pNWTfOL7QXZ/bklQ/TWqfo+qjcvKLscCDtk5eiXAxrAvhIwZyY0WSqAePdbJsTqb3hmgtUlGas4hxxBtFnsYxH8TqmAtqDGKi20njXj8SjSYxG7VWfrIBpYA5/I5cVQV6tAJG6Q/gWsBMEm4Dg/3HmfR3whUu4za5L0eT4BaMHYkduhNecMf2LW9+Qgb7Q55aWOThsfv12i4bQKC7HnyQlh9fmNWxYiCr69YySJQcjKs6zbVMkQrn+sZXcRmCIwYxEyr+oVh9o+p+8aD1r0fZ6JjbJLgcROLGyB4BVXCY7Cyjy5HMzo3IxyZ36y9BsiL+G9Pw7kRAi8TJI0dg22FR5DeruE8WBzXeOR5WDCq/fAcziedR5I+cCqFkCzjFW9dIcEXHjTjkyEoN8ectaArr02WqZMTyYLT0+UxXe5zfbjwRwrCHHjc9RcM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.01.25 03:56, yangge1116@126.com wrote: > From: yangge > > When there are free hugetlb folios in the hugetlb pool, during the > migration of in-use hugetlb folios, new folios is allocated from > the free hugetlb pool. After the migration is completed, the old > folios are released back to the free hugetlb pool. However, after > the old folios are released to the free hugetlb pool, they may be > reallocated. When replace_free_hugepage_folios() is executed later, > it cannot release these old folios back to the buddy system. > > As discussed with David in [1], when alloc_contig_range() is used > to migrate multiple in-use hugetlb pages, it can lead to the issue > described above. For example: > > [huge 0] [huge 1] > > To migrate huge 0, we obtain huge x from the pool. After the migration > is completed, we return the now-freed huge 0 back to the pool. When > it's time to migrate huge 1, we can simply reuse the now-freed huge 0 > from the pool. As a result, when replace_free_hugepage_folios() is > executed, it cannot release huge 0 back to the buddy system. > > To slove the proble above, we should prevent reuse of isolated free > hugepages. s/slove/solve/ s/proble/problem/ > > Link: https://lore.kernel.org/lkml/1734503588-16254-1-git-send-email-yangge1116@126.com/ > Fixes: 08d312ee4c0a ("mm: replace free hugepage folios after migration") The commit id is not stable yet. $ git tag --contains 08d312ee4c0a mm-everything-2025-01-09-06-44 next-20250110 We should squash this into the original fix. Can you resend the whole thing and merge the patch descriptions? > Signed-off-by: yangge > --- > mm/hugetlb.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 9a55960..e5f9999 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -48,6 +48,7 @@ > #include > #include "internal.h" > #include "hugetlb_vmemmap.h" > +#include > > int hugetlb_max_hstate __read_mostly; > unsigned int default_hstate_idx; > @@ -1273,6 +1274,9 @@ static struct folio *dequeue_hugetlb_folio_node_exact(struct hstate *h, > if (folio_test_hwpoison(folio)) > continue; > > + if (is_migrate_isolate_page(&folio->page)) > + continue; > + > list_move(&folio->lru, &h->hugepage_activelist); > folio_ref_unfreeze(folio, 1); > folio_clear_hugetlb_freed(folio); Sorry for not getting back to your previous mail, this week was a bit crazy. This will work reliably if the huge page does not span more than a single page block. Assuming it would span multiple ones, we might have only isolated the last etc. pageblock. For the common cases it might do, but not for all cases unfortunately (especially not gigantic pages, but I recall we skip them during alloc_contig_pages(); I recall some oddities on ppc even without gigantic pages involved). One option would be to stare at all involved pageblocks, although a bit nasty ... let me think about this. -- Cheers, David / dhildenb