From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35AC5C00528 for ; Thu, 27 Jul 2023 18:45:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF7096B0072; Thu, 27 Jul 2023 14:45:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA7046B0074; Thu, 27 Jul 2023 14:45:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6EB06B0075; Thu, 27 Jul 2023 14:45:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 930676B0072 for ; Thu, 27 Jul 2023 14:45:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 52D1740671 for ; Thu, 27 Jul 2023 18:45:54 +0000 (UTC) X-FDA: 81058271028.25.13C0D31 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf22.hostedemail.com (Postfix) with ESMTP id 43C67C000D for ; Thu, 27 Jul 2023 18:45:51 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=zh8FeBjD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690483552; a=rsa-sha256; cv=none; b=KOAGlrRNkU8bSsw4rKJGl+Ix2h62lqbgTW5e2D8lZcdVqHfmD5LG0WFvL4uzlRoPTEUWQg ZFB4iAsABeMW4n8ilHTCPjvuSCmUjRMu0lzlc8ojF/GwX6QxKEL0cBio5mOpTEJkyZ5N95 /34biztuTYoVV7ocj0L0gFenICvss9M= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=zh8FeBjD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690483552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xHqQdtYyIKnXn6qUgFeRTtspxRDzyjax3eG0j/WwVz4=; b=PXWVP9Qakvd9PqjMbvNjEfmnSxchAn3FSTQY872swnvv0LnIeFy3a/Kxa7+3NWO525Zj8u mNZMikvJwwa9n5b57ZvWYhZlhEmQhhE/jUzG2ByAQO5fOHE9BNzYZA47YNNc/4sDUO6msA k/NfyxQoabFk099LuQ8gp2AmA8O7imY= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-584034c706dso13538677b3.1 for ; Thu, 27 Jul 2023 11:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690483551; x=1691088351; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=xHqQdtYyIKnXn6qUgFeRTtspxRDzyjax3eG0j/WwVz4=; b=zh8FeBjDQPL/RFGJ70RfZmhjLnD8uo8vBA+9VWjPEUsiu1t3viexxnpmTYeRQ8XS5T 7dOfj7lPalLleT3SLnPmViwBYrnv9gfMeClC+MKzyOXyJeBjIxR2jF786VUWVvRfa0Hu qKNBCOPvemAItG6umswXKAwg4UnOx0uUw2Vjy4cnpCZpMFnj9sKrxQmF0qzf9vuY7gRk dWIorUrO7l2m0FqtGLHkCn2wrWnhZmttDJVgMfdNOl8/F1D3exXv/xuNbFsXSWYgxa1Z pHhbyBLF00evV9u21d0Ca2zi4MXF/TU0XuJMEhUgg9/E82EWRyVamNepRLKtRdZKRnUj J7xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690483551; x=1691088351; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xHqQdtYyIKnXn6qUgFeRTtspxRDzyjax3eG0j/WwVz4=; b=UELsuAKim0y4nZp2KvHlTybDshUaySdKnjWcQm8SG7fYzBWliNrb/OOb+z258INAB4 VwMBGrfQIK8IaXHfTG2hKCGu6iuuldu6tvamzGQd/U1OzaN5l/ZSppWpxyUfo4zoU0vJ CM9ri0PyU0SebNoFGjFkUmoEChcE62KzNl/ii4h7VmlDUNfT72N7iqeZbMnhebhhNBAo Ze6X/9jiKJATSFpS9QmA+jJ0Sklr+Eehtkp++McjS8TJoHc3ms5K2YzuXdyLop7H0cFL GGeyA1QMms85HhefnrcKnND9oZ9csgPrz7ypo7UPyjd/gSkMF3S3nhhhqMr8S9RDPNdJ oc8g== X-Gm-Message-State: ABy/qLY55EKVA/jpHEG+FJi3mWRKNlvNdYYoKQqlMpNPDLLT2jzOCMCZ WwYTFHH2vzX+yAv9JMUM3aY8GQ== X-Google-Smtp-Source: APBJJlFh+/7L8UPelmuN+xS5LpMKXzgv8aDs7ZmvYMo0Qd7Cz+1PS7CAOfoClCp8nwSuDxsp2pJlnw== X-Received: by 2002:a0d:fec3:0:b0:565:ba4e:84fc with SMTP id o186-20020a0dfec3000000b00565ba4e84fcmr84674ywf.50.1690483550907; Thu, 27 Jul 2023 11:45:50 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id q64-20020a815c43000000b005837633d9cbsm562742ywb.64.2023.07.27.11.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 11:45:50 -0700 (PDT) Date: Thu, 27 Jul 2023 11:45:41 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: David Howells cc: Andrew Morton , Hugh Dickins , Christoph Hellwig , Jens Axboe , Al Viro , John Hubbard , David Hildenbrand , Matthew Wilcox , Chuck Lever , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] shmem: Fix splice of a missing page In-Reply-To: <175119.1690476440@warthog.procyon.org.uk> Message-ID: References: <20230727093529.f235377fabec606e16c20679@linux-foundation.org> <20230727161016.169066-1-dhowells@redhat.com> <20230727161016.169066-2-dhowells@redhat.com> <175119.1690476440@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 43C67C000D X-Stat-Signature: drq9yw1wapeet81yamww81uqodtikukb X-HE-Tag: 1690483551-92704 X-HE-Meta: U2FsdGVkX1+oIFgKs/8I8HQAnySflrT1VrELXG5d6CgdMRKJDm3g7wKjqC0W+KuAVzsOU5O6mXtflw1heOh4t7CLe/bDDK58l93WC5zG5CXM1AGSQf7fvvakKYyAl5K/oO9adxYU08UDgIJi0AWV8L0VTLQ4Q6jmaYE+/mqY7XJJ6j+MLbEsnqDzJ+Bx71g/R66dVEWRb+rVKsQNwsaiRaHd+qidBontXHJprfcDlBLjv6dfmLNqlSkNFQh0ZyCk/sNvo6XEei3JElryZaF4OiP6iXotEUKV2oUwQGtkxMPCJaIHNUqZWD+elqEWJMxsk0pY0B3oIkM6+SCzJ5zscZOoN2OoXAdevae4hk/KfJe4TOY2ECw/roj5vKgOwqytnrcpGN5+s/yNBryBRiL1VdCHPjhMryNwpWJfyR3mpd8RUAHCPM5ARtLRLDPUJpbpYnoIDGePWylNyqNFkx2IuFRo1+m1J5CuNUXEpfiV1CcDAlaXFwh9ZHRO5zUN6UXiv9JjVqaDddk0gJSIxM9R3vWXWkoxDyYBqLW9tBVra2+Y2QSOqB+y1spCpqVvWSKVR5Lpoj1sYZY6D6+LZnzaeBMaiKo/x4eAi/m466Vr+7p1wr6kuiEx8IkPlGACpSCkQoM9/kpf6kJBYf2ZcANdoCUTUIwJ++7MFyInlRb3fFR6jPP0U1T7usW4VM7COtUs9WgFZE6s1ksPXioVa346ycgbI4qJ+iQ8Wq+AAXOqPRjeQbTaEX0t2sdezYVNNB0rb34SaS8DMOyN3KV2nrPt1e1CgUc5LAoI90RltL+Cr2tlxs61PbYoqPEkTLxvAHvw6IXhOXsP/PENRJ8aR31KTjEpG2jPi8cFVcGzaDFm21qkTz9EWESPpSG8tHRfEq8TSWaVGwnxNNE+/VHWMzgYUmRF4EO4PxvqM1lsAqN8wgnPxQsKgg72IkkNnIpBxpzmCB8RdUTxXsvflf60ygG hVj7emve 6Fymh5BwN+AjQ+9otAmyLi6pqQv5lVIV87s6mQoAFIFmOLtmPCDkEF3cZvY0N9sGacvBbLPrZQPQq0EE+OFGYxpYGAgYUohPOObofUQnmY/CRWNVBXyftB2GnysJK18zp/6KKui+5DzYAG0f4Se72ztA2tRM7AxMHxcStTCtr7Kds+Iwh/kHzp6Kkl0Xv5ALQ/Sn/2kwK+PHnBs1stcRm1nUAwQ3XkmJXEsw4HGfGhlteXv/kWEYR6R2F7NvR65CT4rsfXL6yTAV+LqfCYUlvIIuiGj3ek5iokgtBm8dSrphrsXIoDtOJGeocVE6uWgcVbzV1Pa+jUyYI7HKwe9By+i4BQm7ElIYPlNEr+EFLPKw9b/o0WYTj2mJDSwGD9cutq/V9jRsOgKpsdslmA1Cvuvz/pIs+JM9M1BebcKC1vA4jxO3mwWT0t2PV8findiExlJHaEazUupP19S2ZkJDshfI32ppQ27DzawcZUNp+hgCsiTALD6MkFNVLuUR0ed4X1DwJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 27 Jul 2023, David Howells wrote: > Andrew Morton wrote: > > > This is already in mm-unstable (and hence linux-next) via Hugh's > > "shmem: minor fixes to splice-read implementation" > > (https://lkml.kernel.org/r/32c72c9c-72a8-115f-407d-f0148f368@google.com) > > And I've already reviewed it:-) I'm not sure whether that ":-)" is implying (good-natured) denial. You reviewed the original on 17 April, when Jens took it into his tree; then it vanished in a rewrite, and you didn't respond when I asked about that on 28 June; then you were Cc'ed when I sent it to Andrew on 23 July (where I explained about dropping two mods but keeping your Reviewed-by). This version that Andrew has in mm-unstable includes the hwpoison fix that we agreed on before, in addition to the len -> part fix. Hugh