From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1119AC46467 for ; Thu, 5 Jan 2023 01:42:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98F848E0003; Wed, 4 Jan 2023 20:42:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93EB38E0001; Wed, 4 Jan 2023 20:42:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 807408E0003; Wed, 4 Jan 2023 20:42:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 733A88E0001 for ; Wed, 4 Jan 2023 20:42:15 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4D43E1601F9 for ; Thu, 5 Jan 2023 01:42:15 +0000 (UTC) X-FDA: 80319045030.29.D0BDB55 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf22.hostedemail.com (Postfix) with ESMTP id B1B0DC000C for ; Thu, 5 Jan 2023 01:42:12 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=gtIa7MIV; spf=pass (imf22.hostedemail.com: domain of rientjes@google.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672882932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hUrfx5rymV6PAvjGCkeIctTq/mmMCexOy9WfgvwN1Yg=; b=LDTncFBvjF2uALS+HqeHlXEeXytZ17D+8AKp7lMXjqmDAXhxpJJzh75fX0huRCWP13UaMG EqWGaH/XfkLH1OgR470gDXFYln3XWs7tZXDojCTcUMDhj4YeIfTrPqJeQFO4dkdy3faelQ v957v/d9fancrfbXpxEuKAYXiuq31CY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=gtIa7MIV; spf=pass (imf22.hostedemail.com: domain of rientjes@google.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672882932; a=rsa-sha256; cv=none; b=JxNLyHnU0SlQuFvVO60f/pAzsVAEPpvwIGp7bgj2qpWvtc/3i/f8GSmBNZbk6AacdgHsgB ZfHtEtCKY9mEEXTJ1VmvRSV7Az4jN3BLoBqm5TwfIcV5hVybQvzYDhwOcvjhayx/x1rEW4 xwH+82nO/dXDwGVAMyRAM+WMEjTaGRI= Received: by mail-pg1-f182.google.com with SMTP id s67so14258443pgs.3 for ; Wed, 04 Jan 2023 17:42:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=hUrfx5rymV6PAvjGCkeIctTq/mmMCexOy9WfgvwN1Yg=; b=gtIa7MIVyvGMax/CEKEhY/D/ZiZmkvm0uNj297J+blrWhmKvjxfJHG5Z9jXEgIskts vz5mkXbYrV0lJmBZyLTFXFwiy2ejJ/J5kDvGMOUWFX1/5Qe7AlBMf1APcdunfrDmOEg4 qHXsClzZuMiG0/tLMAdJ/P9truPq8u9PHcMNNfZlj2VfUmP031eOYYftEy66RZs1Kgy3 Jhmobu5DaESqXDtE0MBS35YlBisuDInr8UYg4CQVnPppDXtRcoDoDwYs95jkyROk/ck1 DhixM7ZZmxeNrr81wZCxSjmH0mkBiZMFmQBa8EEObfKklE5YByuPDr6Hh1f9luh8a4d1 3KsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hUrfx5rymV6PAvjGCkeIctTq/mmMCexOy9WfgvwN1Yg=; b=Enxnq6Xs0UWpa4x62oQzaJeSDbkx1szsJbBW4RBwR2JU8BqKeGLiw23ttWl8979qqO 6iZGvtDrKRPPLMdZBBZfV8YDhirhLl5OKbi/ha5bLXOtpvfg1m4Fw0Is/fJIl8ZT97VT hyK90n1+lmlYebvikvBemZr8JdEe3RGWK4o1BT3xKjNAgfNZZAmsTpUKrY/N73axwVTM 0M56qMY4Rvh1nrtKu2/1k5MPFxs+9Vxib9nYs18umLm0eXsg1gpvkDaj0WgrSTA+DDnj F/IfDzfGbXWZfK9emxsywqyV4KyyK4p5deiwnhm/1jISsngBgOnE28rJbAkKSD+oFmQk rcQA== X-Gm-Message-State: AFqh2krVicED0/vf/p5P1iUt1pOZQEmjEafa/Y9yGfOh11vbMym38Kxp Z9UFczX3+fLy9+oqjqYzREOP3Q== X-Google-Smtp-Source: AMrXdXuvgTarXCqrA23rBkL31VEvzXqUxRYkMRYM1V7m9460cS0WvKQF9e6nBxAyfny75qm+ijKFKg== X-Received: by 2002:a62:e413:0:b0:582:13b5:d735 with SMTP id r19-20020a62e413000000b0058213b5d735mr62623pfh.0.1672882931539; Wed, 04 Jan 2023 17:42:11 -0800 (PST) Received: from [2620:15c:29:203:fc97:724c:15bb:25c7] ([2620:15c:29:203:fc97:724c:15bb:25c7]) by smtp.gmail.com with ESMTPSA id p5-20020a622905000000b005749f5d9d07sm23726355pfp.99.2023.01.04.17.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 17:42:10 -0800 (PST) Date: Wed, 4 Jan 2023 17:42:10 -0800 (PST) From: David Rientjes To: Feng Tang cc: Andrew Morton , Vlastimil Babka , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Vincenzo Frascino , linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 -mm 2/2] mm/kasan: simplify and refine kasan_cache code In-Reply-To: <20230104060605.930910-2-feng.tang@intel.com> Message-ID: References: <20230104060605.930910-1-feng.tang@intel.com> <20230104060605.930910-2-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: B1B0DC000C X-Stat-Signature: 4e1j1kjn17erpisg8pf5xr9qfhupuxkx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672882932-140376 X-HE-Meta: U2FsdGVkX199zdV2Xx6f3b7FyhgQNvvdOf2QMYVgRcD5tZjYXnqm5XMFzykTGK/43I3kHWVHGzvM0F5sBkXJ3XcJ0RltdD+21lTx4SOnmR0IryE6/CoW4Qs2zoEheAhmvGPedhGH3LXTK/rlHEm71JqGIclc6buqR3OtkMM7phNqekp9m1TvQc5Mbf11TWQzFY5pX5RIdKiRqvP6jPV+9krrl+oQKIs6UTLY0acvXliU/f+SRTTfJ5sl8Ov/ImJPkIAoJoSEvBo5WAQQrvVznemmXPKb9T6IITY1W7kmQSDazlcuL3cy5YTwBlPQfQgm73xqOnJGNKGO5z2DMIN4mTeUdwPc9tFNV65i8hYbhNdGDADY/eES0n+C7UoH/BbR4CW1k0iPzNtpFM1iARbgz7dYMgp9VE4/GczOT5dkDh6ZIiNwQua1tzZgfR0a1C80jkfIWphTE6o8g8GfwUvMyY2zqRW/3APSjLOxc/ErKfSKcot41oHK7kpxrXBlKUJZCnjJBag954XtiQQkvZaZiMluhKbv0R+7BWV5ySJTgbkazmwlpIHwCAabfZP2jSK75WQ62KYO5qqsEnLszP9MnrcKkKYC3QKvrUo4FZEcp2XT5E+x77WInWoxObtfJJ5g1GZuweOU/kNM65Nd6RxgfpOz63McT9+6kb9uh+eNL+z+D6/UizYNaVh46mdAoqjXLy5ehW21+em+PePIs0hvLogEUruMhaBXImD65nkHMymhjsOA4bYqNO6HxVZz9OPHLFg/+cqbt+oV5+uXYQ1K3K8PJRIvEzyQSHkgWBFemO2lJmB9fn2+rOkY2kA7Np69VsBykKy5C1UZJfbrbik/G1eLfdYjo5O/Ih3m4IlRoVWEcmnuhGRXmiLhIT8+ATrBZT6k6zr0vn97MriOL5bf2NhNS2ljrOs8YXgA+X0R4fwwe1WsmUO9WdzUw1kT2Jy9fd91tfeOSsMuC+782Pn ktMGTOD/ +qCT4OtUrTq2Qav6ILsEfK9PYC6kJt414T1nRL+VzrmUsERoGGxU4bk+qu0XyqWhPf+20RqggTKiUOgL02GYhLNqAzENkBUA1/qlKCssh2gMHojB4TaEnY3Nk+kVLYSReyhSbMxMjUe5EEH0VUEdKxeN6aBH2xZsScKrx/TR1Lb3tWult2r4dmUUClfCJEZJmPvLEbtky2OMCrHgfayApjE9S/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 4 Jan 2023, Feng Tang wrote: > struct 'kasan_cache' has a member 'is_kmalloc' indicating whether > its host kmem_cache is a kmalloc cache. With newly introduced > is_kmalloc_cache() helper, 'is_kmalloc' and its related function can > be replaced and removed. > > Also 'kasan_cache' is only needed by KASAN generic mode, and not by > SW/HW tag modes, so refine its protection macro accordingly, suggested > by Andrey Konoval. > > Signed-off-by: Feng Tang > Reviewed-by: Andrey Konovalov Acked-by: David Rientjes