From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2581CC43460 for ; Wed, 19 May 2021 15:30:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B415F610E9 for ; Wed, 19 May 2021 15:30:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B415F610E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 48BE76B0036; Wed, 19 May 2021 11:30:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 450EB6B006E; Wed, 19 May 2021 11:30:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B6A46B0070; Wed, 19 May 2021 11:30:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id EF8636B0036 for ; Wed, 19 May 2021 11:30:42 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 80DA5A2CA for ; Wed, 19 May 2021 15:30:42 +0000 (UTC) X-FDA: 78158367924.32.048A48E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 9D55F40F8C2F for ; Wed, 19 May 2021 15:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621438241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nLqovgw38I1s9PDFvH/lHxAGHLB7WoNm6rgCI8LOhXw=; b=SRUVI418eFsJmlroDrLWKjHVT3457l+J78puyiTbYCgqhV6JuCcht0z6rGyKMErnXNu29J osTRiuhfuGgCvMpG12Z2cGge72ugGtAqy+76YFEg62oRUTqpXypo9t09SJK2AFHF1ihxo2 zpKac8ev0BPeyyDm8997VSdFZ2jkeSs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-SgvzcU2OPOCVXM2UzuIovA-1; Wed, 19 May 2021 11:30:37 -0400 X-MC-Unique: SgvzcU2OPOCVXM2UzuIovA-1 Received: by mail-wr1-f69.google.com with SMTP id d12-20020adfc3cc0000b029011166e2f1a7so6319288wrg.19 for ; Wed, 19 May 2021 08:30:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=nLqovgw38I1s9PDFvH/lHxAGHLB7WoNm6rgCI8LOhXw=; b=GMmzP+7hb2qcx/GS5r/PEgWSbs9Wum1tvXboNEs8ULj9y6zxN1I8BVhBBHDgkzLxef RMkEifVVb2LAED8UEsqzL+TeMxcz5RT3U6js6PFjFncTCZpwTHd4PflNv/8Ubk1VYgIH 7RbpEofKIuQQyxwMG/FLQg6qMkGUGqXCJ41EOtpeAowMCwRX2/mcZt6yTypBFhxzBptH USaicXjYKi1CY9t6AGf004NxCCswCXnBSL37Zy9X+HNVNQvy79B2wlxyO2eh73/jtSdo NaQwre/UzfVuqJF4oWWNjvxmwL9XU6mCp8RhR9QtmpsJlaJbraYgtvHUYA6j170kydbz HA9w== X-Gm-Message-State: AOAM5333vaeiPouz7F6N78OieMyskK+EyANgsUgt07R2mlwncuIJWOXd JUhcs2pY9KUB3O1vdaPKhfOrxFPnEXHtanUjplhgJ8oFEZ4M3WFafRDEPpfyF+EnGZvNO9NdVbP Inv1Kelsju0o= X-Received: by 2002:adf:d231:: with SMTP id k17mr14840656wrh.78.1621438236702; Wed, 19 May 2021 08:30:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRYuEK43nmO1YHfcCigSmsZAamcj+zdpnL50T0osnmkHiq2E9iWd2Tk5z17BC+S2plYI7zeg== X-Received: by 2002:adf:d231:: with SMTP id k17mr14840631wrh.78.1621438236516; Wed, 19 May 2021 08:30:36 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6694.dip0.t-ipconnect.de. [91.12.102.148]) by smtp.gmail.com with ESMTPSA id 6sm24696940wry.60.2021.05.19.08.30.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 08:30:36 -0700 (PDT) Subject: Re: [PATCH] mm, page_alloc: really disable DEBUG_PAGEALLOC with hibernation To: Krzysztof Kozlowski , Andrew Morton , Akinobu Mita , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Vlastimil Babka , Michal Hocko , "Rafael J . Wysocki" , Andrea Righi , Guilherme Piccoli References: <20210519152804.27063-1-krzysztof.kozlowski@canonical.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 19 May 2021 17:30:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210519152804.27063-1-krzysztof.kozlowski@canonical.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9D55F40F8C2F Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SRUVI418; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: itramhsuqe5563jr4sz3pokurjkjzgtg X-HE-Tag: 1621438241-338870 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.05.21 17:28, Krzysztof Kozlowski wrote: > The documentation of DEBUG_PAGEALLOC states that it cannot be used with > hibernation, however the Kconfig entry would allow it if > ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC. > > Fixes: ee3b4290aec0 ("generic debug pagealloc: build fix") > Signed-off-by: Krzysztof Kozlowski > --- > mm/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > index 1e73717802f8..0ace5b2a9d04 100644 > --- a/mm/Kconfig.debug > +++ b/mm/Kconfig.debug > @@ -11,7 +11,7 @@ config PAGE_EXTENSION > config DEBUG_PAGEALLOC > bool "Debug page memory allocations" > depends on DEBUG_KERNEL > - depends on !HIBERNATION || ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC > + depends on !HIBERNATION && ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC > select PAGE_POISONING if !ARCH_SUPPORTS_DEBUG_PAGEALLOC > help > Unmap pages from the kernel linear mapping after free_pages(). > I remember this should be working now, as we temporarily map the pages in the direct map when hibernating? -- Thanks, David / dhildenb