From: David Hildenbrand <david@redhat.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Akinobu Mita <akinobu.mita@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Vlastimil Babka <vbabka@suse.cz>,
Michal Hocko <mhocko@kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Andrea Righi <andrea.righi@canonical.com>,
Guilherme Piccoli <gpiccoli@canonical.com>
Subject: Re: [PATCH] mm, page_alloc: really disable DEBUG_PAGEALLOC with hibernation
Date: Wed, 19 May 2021 17:30:35 +0200 [thread overview]
Message-ID: <b0cf875b-6ff5-2b5c-8b3d-6dc6c75b8be8@redhat.com> (raw)
In-Reply-To: <20210519152804.27063-1-krzysztof.kozlowski@canonical.com>
On 19.05.21 17:28, Krzysztof Kozlowski wrote:
> The documentation of DEBUG_PAGEALLOC states that it cannot be used with
> hibernation, however the Kconfig entry would allow it if
> ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC.
>
> Fixes: ee3b4290aec0 ("generic debug pagealloc: build fix")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> mm/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index 1e73717802f8..0ace5b2a9d04 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -11,7 +11,7 @@ config PAGE_EXTENSION
> config DEBUG_PAGEALLOC
> bool "Debug page memory allocations"
> depends on DEBUG_KERNEL
> - depends on !HIBERNATION || ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC
> + depends on !HIBERNATION && ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC
> select PAGE_POISONING if !ARCH_SUPPORTS_DEBUG_PAGEALLOC
> help
> Unmap pages from the kernel linear mapping after free_pages().
>
I remember this should be working now, as we temporarily map the pages
in the direct map when hibernating?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-05-19 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 15:28 Krzysztof Kozlowski
2021-05-19 15:30 ` David Hildenbrand [this message]
2021-05-19 15:42 ` Krzysztof Kozlowski
2021-05-19 15:48 ` Vlastimil Babka
2021-05-19 17:57 ` Krzysztof Kozlowski
2021-05-19 15:38 ` Vlastimil Babka
2021-05-19 15:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0cf875b-6ff5-2b5c-8b3d-6dc6c75b8be8@redhat.com \
--to=david@redhat.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrea.righi@canonical.com \
--cc=gpiccoli@canonical.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox