From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B556C27C75 for ; Thu, 13 Jun 2024 08:49:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3DDA6B00B4; Thu, 13 Jun 2024 04:49:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEF786B00B5; Thu, 13 Jun 2024 04:49:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8E9A6B00B6; Thu, 13 Jun 2024 04:49:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 881C16B00B4 for ; Thu, 13 Jun 2024 04:49:12 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 44A741A1961 for ; Thu, 13 Jun 2024 08:49:12 +0000 (UTC) X-FDA: 82225240944.03.A799D6A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 008F0A0003 for ; Thu, 13 Jun 2024 08:49:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=azQjMvZ0; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718268549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RS6J5KVthkxaXdiN8zOh9Jm9h30XS9QZ8/1gEQNIBB8=; b=vhGT/IskDjQV6fAO4oEOdVhh/pqKI3sG3QhM4DcOiLzO96ngVwI5o5Izk3LZsDzfs3fKf2 3fSyctDRTL/+By6M10EAZXd8niIXPoYGLUQgXRxMbORyNCxq7r3es5J2YvVhJUbGHiA4Dw GN/cT5z1f7sXb6vb+bAIK7ZaWDkQr8E= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=azQjMvZ0; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718268549; a=rsa-sha256; cv=none; b=pn+siskhvjAJYu3YuQciTjXiRBCIaPt+Z/TuWfzmLHjQ2Qg6uAvKQNl8LmPy4CXsp+FFa8 CNosIfCRXMKkcGSSzKFaDxTx8099LBAmJViGRX49eOyyWV+umgVuBniF3VHdNK+e22B3vq ttKV237pv2HXDGtD8eZHw4Uz4VoW2Xg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718268549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RS6J5KVthkxaXdiN8zOh9Jm9h30XS9QZ8/1gEQNIBB8=; b=azQjMvZ0r9Fs8u+GJXtsGjMW8ebB8JcJ4fyPIQmKsiSH+TBl7p/GGEwazKoa/0PfiK30UG JOy0+du8OdJV6sQHZjwchi7vducaiUZRfx5fC3uiSssMxTuvG7+hSWtWg752JeelWlyXYO GFIcnoESliv4JfmQcMRaXb4n3fmAvmQ= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-r4HsAl3FPlyqddB6MNW6gA-1; Thu, 13 Jun 2024 04:49:04 -0400 X-MC-Unique: r4HsAl3FPlyqddB6MNW6gA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ec063ce179so3784661fa.0 for ; Thu, 13 Jun 2024 01:49:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718268543; x=1718873343; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RS6J5KVthkxaXdiN8zOh9Jm9h30XS9QZ8/1gEQNIBB8=; b=vjEuOdUDhAikqYnURCwksY5dGJCTaHJ1i3JHnsYALEnZuSyXF+iwN8fxvgtNMMtF91 BM2HU/dXkPI77EP9kRfWw45uh7+yckZ1YGW20dqU4+58txVn1NqZ9Hbzs0Ke07CpKtwD wQVpLqxBwHUlGkxlzXb9JfK6xDDqEi3ee1tkM3+BW+QOm2VJnQgidlSh2qjzxw7+Hf8j 4Trmh0MnVKenClqn0jg2ps1pPQfEYjtqniRwd6g90GB3EDLe8ipUz1PhQcDdNqVWxLPP ZHY4AaMwSoZc0U5mq3Vo6ZizsDHKctegDO7BzWmOQ+1R6L2+70FKKA/VZe6OsB+WoZff BJ3A== X-Forwarded-Encrypted: i=1; AJvYcCXdKb7BaRsfILsj2aGUDNVbM40mauTpAwvzOA6tfxH5QbwJjZ6ehh6VayQauHMLCFKXhRhHqRuQukpf2nuNgXNzfb8= X-Gm-Message-State: AOJu0YxwQClKL7rZcBniaVacRyI0w8i67sl8xrmPxZJIQMGyFBWSYZhq +swum7IHgHHWSXUHNqPe302MCgf/3AZuQCpFImU9+aflnzDZOMnNCm2s3z3yVWp9+06UKxmaRQd HxixS2sVLIrPJzRCTby7mz7Scn7n5y34DPA0aVrHxuQiNWRJD X-Received: by 2002:a2e:b5ac:0:b0:2eb:e266:f9ba with SMTP id 38308e7fff4ca-2ebfc9bf1d0mr30399651fa.23.1718268543141; Thu, 13 Jun 2024 01:49:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQrOECpZJiDC6UibcycHJLnTZes27jrpaCziueHA/tENV8SzOy4iwATn/1UI/gv+kqf1DsMg== X-Received: by 2002:a2e:b5ac:0:b0:2eb:e266:f9ba with SMTP id 38308e7fff4ca-2ebfc9bf1d0mr30399431fa.23.1718268542648; Thu, 13 Jun 2024 01:49:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:fe00:10fe:298:6bf1:d163? (p200300cbc703fe0010fe02986bf1d163.dip0.t-ipconnect.de. [2003:cb:c703:fe00:10fe:298:6bf1:d163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-423034f4129sm7677795e9.14.2024.06.13.01.49.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 01:49:02 -0700 (PDT) Message-ID: Date: Thu, 13 Jun 2024 10:49:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 3/3] mm: remove folio_test_anon(folio)==false path in __folio_add_anon_rmap() To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: chrisl@kernel.org, linux-kernel@vger.kernel.org, mhocko@suse.com, ryan.roberts@arm.com, baolin.wang@linux.alibaba.com, yosryahmed@google.com, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, ying.huang@intel.com, yuzhao@google.com References: <20240613000721.23093-1-21cnbao@gmail.com> <20240613000721.23093-4-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: jqsnpdjbkbrbpdu34b9tpptrhg83wdji X-Rspam-User: X-Rspamd-Queue-Id: 008F0A0003 X-Rspamd-Server: rspam02 X-HE-Tag: 1718268549-860190 X-HE-Meta: U2FsdGVkX19ghP0CUwjWn5/RcBM210kMFigHoHsQBehZjj0jwqIPZEnIfHJDt9OYwiGvwqSPnr4lXfK117DsFwZ2LFjVzjqRanaWL4bm1wdqbZ+J9AX4mVUiHAfTNh4zofObUD3jn4aOtGtiSD1yqeE25UKuJteuYj4r4Mps+HA7Gz9Rvkk5aQ1x3f057zx6gnWbJJpg67/0Yqqq0y4g4pvOoAcAjtYIwhgDG4s8s7N2T1rdLQFxwwGfn23/EBu8QtdLVoEtxEvHLXJeBQXQYeED81eXZBtk03ivulU21cg09HcyK9wDGMhMajB+npIVS8kQ1cVJqlhqjLBh6u8FFWqIXEBOcb/0FA5QC8cnYvNCFJK5VE0Qw6mpqMGyVl0U3EDv5Q9ecRNMfLQMzbYMCJqEj4VVdZ5wNiSC5100QuBvco4pLsLIcjVJz/R+qQOt1kM2mRJvTR7Ladc7GEceCYQ9t1s8Ib0nvENLLYS9XIEsQiFBbUk0oQYJP6eWf8TewUvf5QYa+eELIFrD/ApEwm9maShByS9M0e9TCJDmzGjgOZtUwl6frjx/vRmIMt7NwgftTIrsibCfIcD6y4+RhkwRgwyWLnbjUZR80J2OoGpXEvHUMERzGf9eSKtBmBWE8WGt3bqQYlWPxtKDa5ahYSbRyJlJAUpnGyyWxj8F0AWSvZfAYTjD3chYyOALHlZ4wXOI3bqeTrKtU736M+Xsj+Y6g9qvjBj68EAqj7bPWMn9i/UtgrCgXjvr8Ij5oIYD75xb6VoiledDpXHW5QTS3Nwzd4328eTsCyKwMhWTAXvwy4/MS/EiQts++QbtIfOsaHYSB3zWjIcfDGofToK+/0oCPJ/kvmeg8QMSmZJxY55j79MRwunrw9abDDKYf6hqnZ2ss3DvyACVQfacfIgDRbefYp6hxctIs5Efa8sIL+SP4ezCZaWRtgRZtFkgSumLbvhURfzA6FsL66GodNd 4wO1UMzF TqQYtLrONcxlzKO0iaSi1WSfGCIEgrOhPG6Nuf210jKF5olL5t80ctmjj4L6UfF4iuWV0c65dAhydzwdRGjYD9jIymyIzSvNo8vNjJLeCR6vS+Msbj3T1OOlm21KNPEa1rSqGzfC8Joum+Tfzm04G3+LPDaiPCR7dnve7H3a2EI16GvaJvvz1oEz0qCmhBJmoI0rvbMiu/EXTbtWyziIDRotBKAY4jrIuoEhzcH//MIZACe/ZXC45xQ3ITqekW1ATAHY054+vO4u7UQJ2d7KD5E8gTV8xeze0mCJ66O7pXzRS+URz9v3SpXEGdK2+KlacU/FccyH7VfpNdz3bC9qD9q3p0MbykHXzfhAJsU0gmo89P3ylJPE5Zu2bI5zftMiKiJEU72NysbZNAUsnWV8THzoQzf7y1+kugdvMMeNzCwOtVjSPSHs5Ny+fVIYxQmj8E6g5QNa7O96aekifZGXALOirAJRTR23iEGpGWqye34CVC8s9gRTNrJrdBifV56VKEYjd8HLmxuYnMqDSsEGGuORGXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.06.24 10:46, Barry Song wrote: > On Thu, Jun 13, 2024 at 12:08 PM Barry Song <21cnbao@gmail.com> wrote: >> >> From: Barry Song >> >> The folio_test_anon(folio)==false case within do_swap_page() has been >> relocated to folio_add_new_anon_rmap(). Additionally, two other callers >> consistently pass anonymous folios. >> >> stack 1: >> remove_migration_pmd >> -> folio_add_anon_rmap_pmd >> -> __folio_add_anon_rmap >> >> stack 2: >> __split_huge_pmd_locked >> -> folio_add_anon_rmap_ptes >> -> __folio_add_anon_rmap >> >> __folio_add_anon_rmap() only needs to handle the cases >> folio_test_anon(folio)==true now. > > My team reported a case where swapoff() is calling > folio_add_anon_rmap_pte *not* folio_add_anon_rmap_ptes > with one new anon (!folio_test_anon(folio)). > > I will double check all folio_add_anon_rmap_pte() cases. Right, swapoff() path is a bit special (e.g., we don't do any kind of batching on the swapoff() path). But we should never get a new large anon folio there, or could that now happen? -- Cheers, David / dhildenb