From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93CBDC5AD49 for ; Fri, 6 Jun 2025 08:53:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE4656B0089; Fri, 6 Jun 2025 04:53:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBC3E6B008A; Fri, 6 Jun 2025 04:53:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAAAF6B008C; Fri, 6 Jun 2025 04:53:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BED8B6B0089 for ; Fri, 6 Jun 2025 04:53:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7A1B1BB98D for ; Fri, 6 Jun 2025 08:53:00 +0000 (UTC) X-FDA: 83524360920.17.8FC6040 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 1F9051C000B for ; Fri, 6 Jun 2025 08:52:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fUM/u55L"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749199978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BSNIELC8nNKrkXIMtRqAiZPiLFomBjrC8F+yQdB52u4=; b=oBclsujaoRLv1gEF91uqSNdHNLKEsfBAGX9yjKMLg3W9yVHaBI0hCgqAj4Bl3CD8nDu6ix ZdSScu1+dnIkJN5OBHCYRC/KDPzX0tDglqIPnf9rFP4sK4SqHlAJnsRSgZM8Q6RrCOEpre NbbNpRKs3g1g56qZiUvRuLjlPp20E+M= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fUM/u55L"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749199978; a=rsa-sha256; cv=none; b=1Nl5UFIAqVx6n8iOTtmBcXYLs1NerZFDS0xD97FcJ2dd3MtAZtMeDrZ4xigr1bbOPMhBZc BWH9erTnOkOi4mnrYom28v424coKeAK2vcS2QMcdaSOtaEhSLyo0SiI0BWPQx4jBPWahKx V+sP1swMupwWv0/Am4FgRWpWxmPOVeY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749199977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BSNIELC8nNKrkXIMtRqAiZPiLFomBjrC8F+yQdB52u4=; b=fUM/u55LEKE00n306kWabsgs6eq9TKlj8mM7rTBqkbP9smWA+/wuEAXw4+sTjyIP0w9WKW 6WQqX5UAurZyxjYRpKhtWAd1fDDed8VUEpjr/BzPMvgP5p/dgZxqzZloaSaPxpJEgPuET9 wj7oZ8/yHt0+3uQ/C1KGJxf6zN1hzaM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-78-dcPCR9ylP1W_9fHaHfqF1w-1; Fri, 06 Jun 2025 04:52:56 -0400 X-MC-Unique: dcPCR9ylP1W_9fHaHfqF1w-1 X-Mimecast-MFC-AGG-ID: dcPCR9ylP1W_9fHaHfqF1w_1749199975 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-450de98b28eso14896345e9.0 for ; Fri, 06 Jun 2025 01:52:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749199975; x=1749804775; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BSNIELC8nNKrkXIMtRqAiZPiLFomBjrC8F+yQdB52u4=; b=k38qlvOLkfYlqoxZN/My1a4E9gnsmWW+yBGE0ZiTKMzb7DfnQfVGzacrLyDP7mUMUp rrWQxmwh0TdRCX15/WEwpnRKRhpY9u2IzTQjtMqTX3eAgOeSRtDzWcgbcF2E452oyrpC m539IdIHlvl/YFWmRQURFWIbu6w5+Mkguo4fKpIbm5P2xbExb78Ep9l6mVHGFSmalfdW wgrr/k1Q0qSvOTBJzoCnX3tgKDHsulN7T0Mp+EqjXD/wSdXGi5lSqKXDE/0b441uk78k owT0Hexwvjzj1kyFEdYzsUqvbsaxFlxR1IjyOiQg27C41DjSBG+gfQ1YuWzwyHola1w9 nNWA== X-Forwarded-Encrypted: i=1; AJvYcCXMW9g2OF1OJHGo0yRNQm7NEChwoGmB71LSdepKcMGelz4Dp6jtn2obbIjpbOvlAh9QoLeypt8HfQ==@kvack.org X-Gm-Message-State: AOJu0YwazUZiqhOPnNU0Lsx9NdpG5v6tXSivNtUq2SnvS3cHglfrXFPs TIT44Ml8UkXytqyWiN6q6mJAdBLLKpVMU1hNUdZy64oc0gU01E52OF9k0KY1NiW/nkV6QZHmFUy iC1j50rGpM3I7poOIzs0uHpOpFIAvoBvBEjYy0CfvDEqB2lic0XqJ X-Gm-Gg: ASbGncsq/B7mvyZzypoqJCYwG5NAYLm0yK0AmM7/Mm7ox1yShWstirUUnewJvNXUqpO 9AL2fPEaglnOTd37jnf5q5dhl5mmvHP3mNiFT0SSZ+Ok7YMgJq6btIV4IwoFkjwubB4eMI6FJQy +16xyORXsxphA+vilhBALmQMW+U/8Vp+6HBeKV5gdOYUJRW2lcn6GjDMFKjSTxJ5zm7Zq/nPDmK oEAi/kP5uu3lprH8LvSYQF/6TXhTp8eV/JhZTdw8ctjl49ATfR2cd5Kmixlt6TWfnekSvOFNHVL p2MbvdWm/jfLn2fmlw9K0oXXw3+BuSzPPCz1u3+YyWJ49TW3bF11j3+i3xs8Gv1Cx20MNN/7L+f 4ePQoEE6NE10jPR+AwNxI0lYaRWsv2+w= X-Received: by 2002:a05:600c:1d05:b0:43b:c592:7e16 with SMTP id 5b1f17b1804b1-451f844f896mr71608225e9.3.1749199974977; Fri, 06 Jun 2025 01:52:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMNS7e3m8Ldb89F+T85l6hGoyO36C/NX/9a6I0ZGg63okF2E2lORvWNNQqjZJAPa3vHAB3qw== X-Received: by 2002:a05:600c:1d05:b0:43b:c592:7e16 with SMTP id 5b1f17b1804b1-451f844f896mr71607845e9.3.1749199974576; Fri, 06 Jun 2025 01:52:54 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4521375b60fsm16912665e9.40.2025.06.06.01.52.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 01:52:54 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 10:52:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] mm/huge_memory: don't mark refcounted pages special in vmf_insert_folio_pmd() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams References: <20250603211634.2925015-1-david@redhat.com> <20250603211634.2925015-2-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SqVQse3G6FLZg5xVhd6tOywZ-2AU2-Vq8hboFcMW6to_1749199975 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1F9051C000B X-Stat-Signature: omjzwkrhr1qzeto466fgpuab9htpr7uq X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749199977-497569 X-HE-Meta: U2FsdGVkX18J3VJ1NdtA6B23KeUDk+gyW/x7admdVJYLXYqiGbt0NAE9rb3f3DJR3L9VzfyMgggCWe4uyeil+zW42AoJpjZVbKGUgj6O5JLaaUDyDR5UudCtMe9CY7tgkzxJwYacv/sf/Sz4Bgo8m2wf2gOAJJh7QseTiqm5ogIlieFMBoRAIzwdE5C2Z7JpJxgM1bh/HWYba0siUPoyqErW5BrlqijBP5WZPTVxyEpdzbzytXzocx1zmbQ3Y9smg5ixTh1tzu3cUy5ljhb5boHNPESAQI+jY0p3N6hf/+P/hxMuX8UCH5rnaN0m/wxqfOCjMRo/Xt06Kx+h/1phYHuA766NUrf/EFPCg9GT1D3RazhOhaH0Q/Ljm9k63Keu19mAF/oPMm7PwbdZrqGeDVEVQUPhgggswHbFgfNEefdXvCb5ONphWxD5Tu18CaT0jXhkkQZqYcAPwUIDOtXGfOvSqZfhAKsAGitAme4dtpg2how0NfJvMzp1c+Vj/lPDk0a8BEY0focJS2mVeco1NrxClFit/UUtU+XbG0swdLXN0w+TNHifBeTL9xY/aFBzOfm6gX8xBE4emGzqXbIsqqFT+IjELDSxxowE2Sw/8fTzZdcpIZprU0/43vhRMqHg2hBC+JwdAF4WV2mmumLwzULyNeYYf+smi5mPzPaXKibx8zOrEvec1c79eVhBoN8Xf8AgP68Rt7Dy8JiMpT/kmAgugWuVDUqj8q1zR5cayMpgfAkM28O/Gubo/ccrGZslOLVnIKF4IywY7aRT1ZZFDlu7VV42c5fAaxrs1do+I1IqnZ/v80K8/rCs6m9+BNXDAWhjNm0cHe1A5MQaQetFs6Uv8xQuS2Jqta2moWUCPt/pWDAmLR+80F3wCyUngyqJ1s5aX0iyYlyRBRjIVT71POVHz9iAXBjEUXmxwDUByjm0knBIb8nX99O6wwdpU+4sWWuMcoI32KdT9PvTiQu NNMjLtHw ECYt5n7olTryozC1Qkb8yWvtZ2p1Rwj2kUNFGGZRlsoc0h3SCO8pZJEFakfGnm3KAvHmdZYW5Iwm+kqklSIKNc+uyviv8jL6UHMBC5fPOWNRat9m2yrq9fIlSZigepZA4unrwDweA7hCKakgqaDlYMvGdZcHORxCOI587ldmgwcn8Nd6HkSG2eCYpozgUyDHA7+Bb+rkwGoP1xWdJ2F2aOrvmkkRp+SeYPTfuuA6de1xn6Nd0WhQmmvYMn3CPDY4CdsrEIZkB4w3ApesDAVyxYLqsU67UJi0Nj7YRGq4zaSt39W8ln7JBZPfYENPM4nnC0pKJYA7Q9+Mgy/kWI4lckOGNCvqBV9s1lHARXTEgiUBbujsWNpaPuc4Mt5X8F6aetr+YQVYtJnBUKrnk/OjgJu1OeExaihLTDCN87YiJ+iOov1T/z3n2CxmkVsgSsS2GCa+QbaxZ4ley+gk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.25 10:26, Oscar Salvador wrote: > On Fri, Jun 06, 2025 at 10:23:11AM +0200, David Hildenbrand wrote: >> See my reply to Dan. >> >> Yet another boolean, yuck. Passing the folio and the pfn, yuck. >> >> (I have a strong opinion here ;) ) > > ok, I see it was already considered. No more questions then ;-) Yeah, the first version I had did exactly that (second boolean), and I concluded that we are simply not "inserting PFNs". Especially the second patch is much clearer on the pud_none() handling (similar to insert_page_into_pte_locked() where we only have exactly one such check) I'll have some follow-up patches planned that will add more pfn-specific and folio-specific sanity checks. -- Cheers, David / dhildenb