From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA857D3E783 for ; Wed, 6 Nov 2024 02:19:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5641F6B00AE; Tue, 5 Nov 2024 21:19:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 513DC6B00AF; Tue, 5 Nov 2024 21:19:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4017C6B00B0; Tue, 5 Nov 2024 21:19:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 22CE36B00AE for ; Tue, 5 Nov 2024 21:19:53 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A1E41418FD for ; Wed, 6 Nov 2024 02:19:52 +0000 (UTC) X-FDA: 82754062944.13.D36AE81 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf11.hostedemail.com (Postfix) with ESMTP id 29AB640012 for ; Wed, 6 Nov 2024 02:19:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MfZfTSqK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of hughd@google.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730859531; a=rsa-sha256; cv=none; b=yALZa1qsDkWe1VkkqBV8275SOlE6qpJOk2lZenPOIUVdv/BaWWWL/MEgrJOja6bawusJ5E d70+JgWdGk55OUxt+Ux/TWr9gTQ8bb/EoFyXimDuu/SIrc/PKRD7k/Bd7Qw5H9rqMQqOt3 nrodmorOn5GBZi97HHIdHORQf/62crA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MfZfTSqK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of hughd@google.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730859531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dMwHZbqveg3qfQOk6hXWoEkDSZ7gjetBd5tA/0pn/RI=; b=Fx59g9ZOTNEmMYE+H7wDRgO82Iz9J3jkoRY+D9kvOGwA1kbr7Am91XaGIuyyes4ae4oMz+ MmsUovEHG3ZoksSiejdcl2BvL7xt64sNsRQzIOYyfB1VJL9bd0oM+wbaXGZg7n5g8URvgl FNjVx1PI9jfvXN4EC5g+yxv/FOxUzcs= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-21116b187c4so43877965ad.3 for ; Tue, 05 Nov 2024 18:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730859588; x=1731464388; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=dMwHZbqveg3qfQOk6hXWoEkDSZ7gjetBd5tA/0pn/RI=; b=MfZfTSqK+7UV5NipJ2/cUYCbBy58lw6vKZcDi6+9vJE0Tjd0GVeRiamfSaSgDneHmX LiIHR1jxMu5zWugS5vUSnAlICB/BN1YNB2ZgVmuvLK+GRKI9LaiPRlMKflULHhgHKdZ+ /oms9K02eQV0nc6OIE6VX4I7Hp1QFeZclsJ3LxdMvB7zRj3SbT73nBZy+uAPmSawR38A Sdg8wPUK6mNZ052oYWwrXnH0a5HgBhiwNEwXsCJDgxnpBLubQM4LzeCd5ti9WWEqeo8f YjbWk5GpnIwW2HWK3ErKJx+ywb/W7M2r1DliEtTcy/L1O3N2db0Nnyyow2xBiizCk3Rr EtuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730859588; x=1731464388; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dMwHZbqveg3qfQOk6hXWoEkDSZ7gjetBd5tA/0pn/RI=; b=D4Zft+J2ZOxYz9NZ7zXtKyxrL5iMi46tLy8lChXtDLQheWnMd8aYB6wXyxKpHpy8bw xZ8e/2NX5sWEozjJDGHEBLDCHY/0urRydF7cgJvajhg5s+i1spFL3z+bVXPbkd2AqvEd nxlCCoZqB/y8sijBpZIo2yai2Ipq+dpKNGoRfYq63QRAfHdKEOrsPeprwNtwzZmTh4sr e/2bR1aJPLaJ750aZrvqDZGd/IaxiV/CuA1HL6vb2BJLTd5huIx1Lcep9BPgLo0bfztU YHOStFHZ5HI76xA5Zcv/gxekP/DUMCpkXNzq5r2kQ9gJgxxQ/NyLJD74gLfkapShG0j6 4clw== X-Forwarded-Encrypted: i=1; AJvYcCX0XCMmXciuZ5zuCue812U5aBYAEazFFvnc8mrFQ0TLCr2QHaw1ESEF9ANb9sxp78aOy93qWIO3qw==@kvack.org X-Gm-Message-State: AOJu0YxGjNm5LUL4LWIfPqVhfoj5NXiF55Ysf4K3Q79HfmCwaLOsigM2 c/jKygqPH73lYmhY6HhffB4yRLdtSriEJmKi4YZAwO0JMLKFX0ugy62wsIQ5DA== X-Google-Smtp-Source: AGHT+IEx7//yPBQ3NT/CkT68ddSvV9UoTv2LGlCxfnUWr1gNgfBvRseUNmE7hQwH0O970Uk23pjQ7A== X-Received: by 2002:a17:902:e5c3:b0:20c:aae9:7bf8 with SMTP id d9443c01a7336-2111af1cfe3mr222576525ad.5.1730859588402; Tue, 05 Nov 2024 18:19:48 -0800 (PST) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21105707e43sm85878085ad.97.2024.11.05.18.19.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2024 18:19:47 -0800 (PST) Date: Tue, 5 Nov 2024 18:19:38 -0800 (PST) From: Hugh Dickins To: Roman Gushchin cc: Sean Christopherson , Hugh Dickins , Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Matthew Wilcox , Shakeel Butt Subject: Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare() In-Reply-To: Message-ID: References: <20241021173455.2691973-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Queue-Id: 29AB640012 X-Rspamd-Server: rspam11 X-Stat-Signature: ckrqb8uzkbc3ngbfifn9oahqmm6ixape X-HE-Tag: 1730859547-388408 X-HE-Meta: U2FsdGVkX1/oJjFm6bdIxmllCrK18HiWyISpFWjCcHVXFv2wfPcBOnpYLnfWV9jxhRQvO/2FneCUE0jn2v7BEWQ43yYoQbBfs1MMTItoBUGu9fvasA3q66UDsDhSLThmQ4wyHL4YITYruRsmgafYWuJVhDqzpTWuxBIja7LNb0v6NaCEzfBITgALdcru9sURGwlKqRwMClAtKlTTxvQnOSpJpUjl4jkvUP9NKiU8Ps+P9Cq2zG2lLutTcgDTiMylzB72FlFaNY1uUOJXQqNqWcux1083xaoXEAFpgfKIIrS/J5NZ9RUx0j4n6UWogL/PHMqlAc03CIjt5FGP1N4HAfofXWrvDlT076F6Omiy1yS751zpmdjm/H/Do1WZg1fgEPyGJXX7GoldE/l9dwNnzDmcZ+EImNv9mt121Qxs1oUZDIjxZD07DaYDfDFEe+Cyj9VkEXl/3MZlgorMj+8zefQB7fua0lOHUoq01YgN/rzCZrUnCvJkIcoCuBk2TY7/CfVLDXDcXBFEQiq0ljn6CxSu88tE2lmplAsxFtUgLpsyk3V+hcY01Yp8m89JG021dVwalNYu0M1Xnx/xhukMVWWI2Y0VC4mX4qTEVKWCzqAw62arCXWjb8vJcosJgqKhEnP+E4Gu/wl1lqTS5cKqdfOPCrqKw2CrwrpEasm2Q9RrVBLWt9NlKSEf1YQSzTpmr8sLy+v31KWuGUuzsih+PzhgHoQ+v8A+wyK/euNaHoOdLsamyS+9krFQHjEZKW1/aqhfa/M4VfpTkTAVkBfEuQdCCgEiLbVdblFC4kkJOfs6tVIdwVTkKJVdO6nHH7zy0AU5Ek4gQ+oBLbN6I+tCIfHcJwD9kfpGQU8FbQpdWu8Tb7VAlnMzrsPQuA695NuHn2YYInc3WAnoXROzyzwNujnK1yxurbZSaQId3Z2wCwFa8TWl11XPTDA+Nlye7NX6vFc6VPjnnql3GmXRvXt TIpp9zaw Ddds9KtOJLc2Sw22O8OW+OP94N4lhIV02OqwE34NB0380xhAZHi2A751Qafjt9cSHmjUhpFTeAlYTv6k/dULbfm56/eaOdC9ay0jcvOvogwT6idOtFrsb59wZ63Wu3XbhYsZXU1N/zOw39zKTLhkTZUj8W2PBcO8gg6G7ZEb3in3hVyREqqooQZrx6ACC/m+3TdH4hof/krW33lUw18w4KkfKhByontFH5U65ytRwYQ/mjljEyfmICBqaKcq/PYbQ9KyusspMyb6svoQsy90A7wI96o9bpYWdDdHt7UqBpb9jU6Y7uHB8j5jI9fe8rO9DASKFvlh2Zzowovlo+aDtuswnbjhXYSN1Qv4j0f2WX7qAWVrLVWXkW6AD2dvu2cOhBsgJY98vkcVnt1Fx1S+zGZ/cNGt37414tBXz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 6 Nov 2024, Roman Gushchin wrote: > On Tue, Nov 05, 2024 at 05:09:13PM -0800, Sean Christopherson wrote: > > On Tue, Oct 22, 2024, Roman Gushchin wrote: > > > On Mon, Oct 21, 2024 at 12:49:28PM -0700, Hugh Dickins wrote: > > > > On Mon, 21 Oct 2024, Roman Gushchin wrote: > > > > I don't think there's any need to change your text, but > > > > let me remind us that any "Bad page" report stops that page from being > > > > allocated again (because it's in an undefined, potentially dangerous > > > > state): so does amount to a small memory leak even if otherwise harmless. > > > > > > It looks like I need to post v3 as soon as I get a publicly available > > > syzkaller report, so I'll add this to the commit log. > > > > Today is your lucky day :-) > > I've been waiting for it for a long time :) > Thanks for forwarding it my way! > > I'm still not sure what the conclusion of our discussion was. My understanding > is that my fix is not that pretty, but there are no better immediate ideas, only > long-term improvement projects. Does it matches everybody else's understanding? Yes, that matches my understanding, and my Acked-by stands: thanks a lot for keeping on this, Roman and Sean. Hugh > > If so, I'll prepare a v3 with an updated link. Otherwise, please, let me know. > > Thanks!