From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5588BC52D6F for ; Wed, 21 Aug 2024 21:05:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE3546B0157; Wed, 21 Aug 2024 17:05:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D92996B015B; Wed, 21 Aug 2024 17:05:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C33B36B01A9; Wed, 21 Aug 2024 17:05:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A53246B0157 for ; Wed, 21 Aug 2024 17:05:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4244280283 for ; Wed, 21 Aug 2024 21:05:16 +0000 (UTC) X-FDA: 82477483032.11.D805C2A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 04CC240025 for ; Wed, 21 Aug 2024 21:05:13 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e8Dc62Wi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724274254; a=rsa-sha256; cv=none; b=kvHGxVoso7egbHjv3P07TV6HEQFvwBVonW08y39vFa8JoaMlxuEwanScg+ssnlTqwEX5pJ vD3Kxw0jnzSkOHaw5Z+YXzYDMArx7ZarnwkrlLrKGjtjGqCVtDxWmnVtXZ3RCDIr6e9DTe v3TZEH36zoXAPCHqdYQ+DCrcwc4SgLs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e8Dc62Wi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724274254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ei69pG5c87v28f1GZcn95pauWyp5DyCXkZglfCBpUIc=; b=5VlV7T5LgDXWKHRy294AO0ktCwonJrHqTpwpHpfXlfcHFemzOP8xS/gTe/bO8dgCw1ElYs N0XxM4ei10XO+JfPBoGaAJQ9zH0T+Lm8HpfSTpXtzmjW6MLPI+PKcPSJrwLm8Zw2p+MWtk qM58wfl4VOGFuLXFI5VfPfvjetNkZOA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724274313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ei69pG5c87v28f1GZcn95pauWyp5DyCXkZglfCBpUIc=; b=e8Dc62WizBtPbbH/ZeTcj1+1OVWml3iKg42QDSVw0drxdnw7/+rzI/yo6i9ZUfvfyJd9az UtLqdQWPpIOplXdXoG1n3x+YBjpafDYxS42O8pRXRTscBXvO12Nxswb7fdBF5xI6fmfGCX 0BpHUfmocjm0Tx3d8gdwqQo8G21KabI= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-YW4pR5_GNSiSIJmO3Ls3WA-1; Wed, 21 Aug 2024 17:05:12 -0400 X-MC-Unique: YW4pR5_GNSiSIJmO3Ls3WA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-52fcf2b5287so77122e87.0 for ; Wed, 21 Aug 2024 14:05:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724274311; x=1724879111; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ei69pG5c87v28f1GZcn95pauWyp5DyCXkZglfCBpUIc=; b=BnmNi7bkMR5WCTrHaN3TNAJ737E2PLePoBN/aXe3mF30r3InSwqNz1YTtDSfbNI+7W hIgiQOAoyxJrndR+wQsXvoI4siPQ9ZlW4/+J3oX12PZ+ghA7rTyUkXxolzN9IZUj206N thKNch3cDEGayPErq+zyPmgqT5H875WxoCTHq47Lj9fifgilcfTS06GQB9Ze1qLputIP MPDVjTzWLdZZSbuViNxNOPciMqfSKMPvXVvrCVD+YnESwcXZrX0WIsZ5M74CkMU5adCY utMA3sRzRTKn3YE1qZX8eazcvjvLsS5D+RRBXS5YqjG6xspXlmBojzeKszXzqJ1zHbPs ksxw== X-Forwarded-Encrypted: i=1; AJvYcCXWzrfZyoKxPwG82cR9Nz0fbZb2W7hmUG8dzcrUXpn69Fns62aqRsfmg1UP+xyxg5r7hhoFEkUbAA==@kvack.org X-Gm-Message-State: AOJu0Yy2aiPlaoB0ONyI6eMDeoK0Iep4JKD1bh7JIsz4o49oGx/XbzRr edqR+e+fcwj2iZ/nQbOYnkIRljkSC1xbvNpYQJRFWm6jE/1XgkLKAlxXncSqUzW1KHmHGD8nVov Jk41blSnUiTaGMtfOQP6i0R2pGtKvl/+2PhlhDyYeY64bdCTEd+0aookCc9Y= X-Received: by 2002:a05:6512:6c4:b0:52f:c14e:2533 with SMTP id 2adb3069b0e04-53348591263mr2267925e87.48.1724274310628; Wed, 21 Aug 2024 14:05:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHscwlaQAFNCG689AEI2Agp5FOy+CmlqZylo1s+dB8WDsIuFzaUZwZgwVvMZGAsxaqJSRkjBQ== X-Received: by 2002:a05:6512:6c4:b0:52f:c14e:2533 with SMTP id 2adb3069b0e04-53348591263mr2267903e87.48.1724274309593; Wed, 21 Aug 2024 14:05:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:4300:16d5:c5b:8388:a734? (p200300cbc705430016d50c5b8388a734.dip0.t-ipconnect.de. [2003:cb:c705:4300:16d5:c5b:8388:a734]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ac5161dd0sm1827845e9.21.2024.08.21.14.05.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 14:05:09 -0700 (PDT) Message-ID: Date: Wed, 21 Aug 2024 23:05:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm: Support only one page_type per page To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, Kent Overstreet References: <20240821173914.2270383-1-willy@infradead.org> <20240821173914.2270383-4-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240821173914.2270383-4-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 04CC240025 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: m4e8w7b5qfuy3qnw59e3k51z9k8khqfg X-HE-Tag: 1724274313-851279 X-HE-Meta: U2FsdGVkX18eTqMASxCWEfBgKA877fsR0oBsT4dLXyB5EezfqYBFDgRGq34qAZHZsdX7Fq0jvvU2cZkZcFN5ep85xLcxgfTEHjhmM0FnlqaZG+LAt3KYf35VCoe8jfSpS24JAnSACPNAdJgSvjfO/6S/ehrQAgMDWuEee5zcY+ApPACdSFfB2U3h5+VfgtfNWOLdxniKKAyCPHk/c/v0kG+wKGe4aBKqas3ttALyhBgIDIk/+6f7sZJM1Zqc0++OXWO+TeGNJwYoFwkoC69ms9d35FFKsONfnGd6duQvFfBe0TiCc4QGG1+p++CmY3JBTt7lNijdtsgmomttK4FI97dIH+ynWh5RDuW0YUiMFMXxqZRWu5JUnmLGDRiOehgJgY5tVLUzAHDMeZDlMLZMbfCblwI7XT3HkQFiSDaA2ZE1uF+NYxyvbjd2H53wqRqSR12Zydsn/jggvIUsKhGTnA8EyUN55QIfvgBoT2Ys9ndmzFO54K1QUQPXqbjLSWEbT1JNd4YrzFioEfrV0X8FRsY5116oprqi9WltTNQhRGnXfxyRUdAt36+mToaoi5yy8k09rwb77k3khduUuQdWIaU934La1D5eXnMeL5QOUhvczuX7NZfTIi5y+yCuOI3Gp48wv4ANz+5iVC3gUOEZ9ynnlqfz9z35CWOot0cFFEXxYfFHODbEBDa4VqDA9Mrkk6OWmaWVqoZf7zbe/Sin3ktKuhmTmua561kyAKj9+c1eTnsVsjBRCEGT+B2r/GJcs/MTftJv9rqtNJoZgWOOtCmnFV8S3Oseu49zo/tDMeiQpa77mNL8RSiE0guDiehsGd7y6i2hg87yXG+L4xf3N8Xfqd3dqwWIk46bwolOz47bYv3THNYTIUxJAkZ3doNrQ8j3MnMpI49vqPnVrrAL5Jhbm+QxfPFHMtTxZ8Bx/lCw85q6Ialv37a8Tk0pep6HP81D3v+Agamy5BVFw9l F9fBAtMX ucjAt1zZSNluK8FEAYFAkKbLIaZt1Z9dwTj6V7WRyr9E/BB37uI9fkvZdtr9CHrPlGh1aO7+YCVRopMxfe06yIAFkLmV4uxcwH7iu1Sj3kBHfsvhAjokPiWEJGBlTQ3a3ibd4eDzwCfotjBj8Bm3V0NK15WE6VFVPUSfH3F518j7Yjhs9WwL2P+dInIYd3KXdhaoL2hya83jClDRUSIh9TJHwsVFEGD1oNF8k1ijVczkxxOGIXC/gxnWkmEGX45AFb05IzQIutdHGULCeQNZ4ERZHLYY8rpq4pxl1GMwH93eT/P2XHlUj8zV8+elHnQG/bqt3QCasq+ahzzbBv17o/B/gI5VVQSgIJ6v7fnAawNK1BMFd+x7ZUayxFGFnUj/IJY4pVfpmMx39s6KMRf06McKc+uqq6UVTMtVlJCqNdOc5w5GZszI4VmatlgQMwoP3buRzXEbb3yVy+g2HmGm0g/uBQo3a8mMhXEbOFihJ/hsGVfNl2czmk5FvGpLYV+UdmLaSMIIOvcRsjLs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.08.24 19:39, Matthew Wilcox (Oracle) wrote: > By using a few values in the top byte, users of page_type can store up > to 24 bits of additional data in page_type. It also reduces the code > size as (with replacement of READ_ONCE() with data_race()), the kernel > can check just a single byte. eg: > > ffffffff811e3a79: 8b 47 30 mov 0x30(%rdi),%eax > ffffffff811e3a7c: 55 push %rbp > ffffffff811e3a7d: 48 89 e5 mov %rsp,%rbp > ffffffff811e3a80: 25 00 00 00 82 and $0x82000000,%eax > ffffffff811e3a85: 3d 00 00 00 80 cmp $0x80000000,%eax > ffffffff811e3a8a: 74 4d je ffffffff811e3ad9 > > becomes: > > ffffffff811e3a69: 80 7f 33 f5 cmpb $0xf5,0x33(%rdi) > ffffffff811e3a6d: 55 push %rbp > ffffffff811e3a6e: 48 89 e5 mov %rsp,%rbp > ffffffff811e3a71: 74 4d je ffffffff811e3ac0 > > replacing three instructions with one. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: David Hildenbrand -- Cheers, David / dhildenb