From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD24C433EF for ; Thu, 23 Jun 2022 18:48:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C60828E0183; Thu, 23 Jun 2022 14:48:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C103B8E0144; Thu, 23 Jun 2022 14:48:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD7A58E0183; Thu, 23 Jun 2022 14:48:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9EB538E0144 for ; Thu, 23 Jun 2022 14:48:01 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7895635B10 for ; Thu, 23 Jun 2022 18:47:56 +0000 (UTC) X-FDA: 79610384952.08.7DF665A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 478EC14002D for ; Thu, 23 Jun 2022 18:47:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656010046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bLAm3pMxOh+9zY21Oi845s3fU5zLtsAou6fuo/Fr2Z4=; b=duFKbtBCPiitPeBs2FIjpdzmeWSOO5PO7rX1Y7959lRRmlvSsqTM7XIsC3Gj/QBunBZ5GH O3WAhEcFVGdcQWBxcuVyMgd+iqAe9HhdNaekkO2Bh1kw/vI02md7YeQdMkMpMxCqzVzBlA EHfVpkqph664XqnZkCdJYcjYIKGG+J0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-282-oHXh_Y30MQa5CeAmYhC6Ow-1; Thu, 23 Jun 2022 14:47:25 -0400 X-MC-Unique: oHXh_Y30MQa5CeAmYhC6Ow-1 Received: by mail-wr1-f71.google.com with SMTP id n5-20020adf8b05000000b00219ece7272bso4387wra.8 for ; Thu, 23 Jun 2022 11:47:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=bLAm3pMxOh+9zY21Oi845s3fU5zLtsAou6fuo/Fr2Z4=; b=vDiJZtxPrje5U44d4weEVCtmK1hYBs9QuHyExzgiQnD+U8u1N74DZVF66/9YKL1AwT Oz/2FFFJRXkySurvWxAJPkEwYeTpaP2u8m2JOXE0Wkkco6u4ApGRG9Jqah81CjOVtASo sHvjpnj5CrlHOZ3UnSOyq0JzVY5Z1MR6J9b82ySUHylT9sqbDsG7uJHy2X6f/LaD/s29 f+OZ2le1GCh2zPrnamCu1+ffu/1ONxYZTF3g1yQqMGM0c3dvdS72ntjTt/NWpXFF+lZi XiB6Eb+COdJw6ZMUV1Vtk6yXgAVvw9IjSVMktCeJvbjHx2FIqK615x7igkOxg2KuUAAR 0aaw== X-Gm-Message-State: AJIora9cvFA3BHjLfkJqlJh1X7cCcXb4tfw2XfuuCGCmEiWn2pf5/jDx ESLtlxs8/IAt6GIqMTwi+tDu6vsO49cvYgbpXy6eCGvl3jGABblC1W655QqRPzBvAgi6/eRWqpt xwzahi+9ND0M= X-Received: by 2002:a7b:c242:0:b0:3a0:1acc:4893 with SMTP id b2-20020a7bc242000000b003a01acc4893mr5974865wmj.66.1656010044520; Thu, 23 Jun 2022 11:47:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t/VUf72rhZDrZZIGKZe7nO+zIr5UrHo8zc6e2z0WNLhkOCYb4WSIBQqaJSjp9/jUHkySkmQg== X-Received: by 2002:a7b:c242:0:b0:3a0:1acc:4893 with SMTP id b2-20020a7bc242000000b003a01acc4893mr5974842wmj.66.1656010044308; Thu, 23 Jun 2022 11:47:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:b100:7694:f34e:d0dd:95e7? (p200300cbc704b1007694f34ed0dd95e7.dip0.t-ipconnect.de. [2003:cb:c704:b100:7694:f34e:d0dd:95e7]) by smtp.gmail.com with ESMTPSA id q13-20020adfcd8d000000b00219b391c2d2sm195465wrj.36.2022.06.23.11.47.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jun 2022 11:47:23 -0700 (PDT) Message-ID: Date: Thu, 23 Jun 2022 20:47:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v10 15/69] damon: convert __damon_va_three_regions to use the VMA iterator To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "damon @ lists . linux . dev" , SeongJae Park References: <20220621204632.3370049-1-Liam.Howlett@oracle.com> <20220621204632.3370049-16-Liam.Howlett@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220621204632.3370049-16-Liam.Howlett@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656010074; a=rsa-sha256; cv=none; b=ElEtj8/fgNc4jsRl4VOwieamhMwhiIXL1XJZJ4mIda14qSLmI39m7XlN4VJsH6a/CZlDhM kjmuiCWUH4wlao/vzThPG5fzukNsxdX5W0L2MsWd5SjA78vR7431DOSanZEir4QRwVRRD6 Sh1oIKYtGynn2NOeNZDXrsAh/9NDXSU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=duFKbtBC; spf=none (imf09.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656010074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bLAm3pMxOh+9zY21Oi845s3fU5zLtsAou6fuo/Fr2Z4=; b=rxusg/lDetS1bGDoPienWFLlQXtd75z+LnvP7mFpT49ytlW6XYOyAtCkgR3wdVbOej75QT 35h6/xmZifr7hkSqAUML176IkPRheIQRegt7Hu7KF6YcN0OwXNzkqMUHtSBgfXPb8I0Zi9 YPBMRFwCGFskDLO/LtG+brjvkSEwotY= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 478EC14002D Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=duFKbtBC; spf=none (imf09.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Stat-Signature: sagjgsgig75diqrwhzz7j636gcc8ix3h X-HE-Tag: 1656010072-582424 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.06.22 22:46, Liam Howlett wrote: > From: "Liam R. Howlett" > > This rather specialised walk can use the VMA iterator. If this proves to > be too slow, we can write a custom routine to find the two largest gaps, > but it will be somewhat complicated, so let's see if we need it first. > > Update the kunit test case to use the maple tree. This also fixes an > issue with the kunit testcase not adding the last VMA to the list. > > Link: https://lkml.kernel.org/r/20220504011215.661968-1-Liam.Howlett@oracle.com > Fixes: 17ccae8bb5c9 (mm/damon: add kunit tests) > Signed-off-by: Liam R. Howlett > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: SeongJae Park > Cc: Catalin Marinas > Cc: David Howells > Cc: Vlastimil Babka > Cc: Will Deacon > Cc: Davidlohr Bueso > Signed-off-by: Andrew Morton > --- Nothing jumped at me Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb