From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19FACC5AE59 for ; Thu, 5 Jun 2025 07:49:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 955C96B0572; Thu, 5 Jun 2025 03:49:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92E066B0575; Thu, 5 Jun 2025 03:49:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 844DC6B0576; Thu, 5 Jun 2025 03:49:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6657E6B0572 for ; Thu, 5 Jun 2025 03:49:36 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8C5BA1A1CF1 for ; Thu, 5 Jun 2025 07:49:35 +0000 (UTC) X-FDA: 83520572310.12.F5178D1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 0A27B16000A for ; Thu, 5 Jun 2025 07:49:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NowytLcs; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749109773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wRyOEDXETxIkKIFfjZs2P8W26KRROUKYMIqAGAlgFBI=; b=4SRDDzhLgBpQyoUJmps5ngpbxUXYKEXpUK+AfFPYFg7lStSwT9m0XBWXRzgDa+wtvLSsIx kWpsIbdCHrWY/vq6QKXeXxp1uBoJz6fGqdoVNJj/CvVOjIwHXNH0HskQ1XMB3eR8DxNaPa /Wpo/dbWa5c8E5W+eIxkO9hwnvQoTOU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NowytLcs; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749109773; a=rsa-sha256; cv=none; b=FeBkjEFwMnz1UkdSZVHmdv7QOlddC1eihZ5k0fyQw+zsBhNpbCld1vxTmuodL58b+JFCIt bhsU1f8a3QaQElW1D74mTKjKYL3qqR8t9li65JtY0Tg6ScYQvZ0ibF4xjACOuCYyOv8WTW LM4xezqE5W8fLo9MGES2gnbzgWWHspw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749109772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wRyOEDXETxIkKIFfjZs2P8W26KRROUKYMIqAGAlgFBI=; b=NowytLcsipHKwm7oPPfmpRgNvDdyifc2L6gmpnIWy5slMAFquTA1189rf6hViMLxrhN1Q/ DADv3VbsXfkFsY8f4cZ734ZXwfY0oWFqsCuNN88+kK5PZAg8AXFQAiuL4wwB6njLQ+A+De EK/noR0U8MpGax70X5o+/C4QpC0xnY0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-nzK3rXJgOFGopQEMUrmpOg-1; Thu, 05 Jun 2025 03:49:31 -0400 X-MC-Unique: nzK3rXJgOFGopQEMUrmpOg-1 X-Mimecast-MFC-AGG-ID: nzK3rXJgOFGopQEMUrmpOg_1749109770 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450d6768d4dso3821525e9.2 for ; Thu, 05 Jun 2025 00:49:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749109770; x=1749714570; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wRyOEDXETxIkKIFfjZs2P8W26KRROUKYMIqAGAlgFBI=; b=FQmg0vSQ5sZt6pOcp2LTjI6P4MJCfzqmWGNEfoejz7PS+oS3xyKV8JXk9bgHa6FsxI 1iy+f22Ty83BuEvyUoXk0aahxWkjxZAtQmcUK3MFRlQcqhDpkRkybbv4PV/a1LPV+MsR qv9BSmzX0HQLoBrN628K3xoczrYXF3/578JZkp2ZPEhIliW/Pr58tY13glSW6vLXPfDR f36acLm/DuuAnuJ0SnUSRyQlUORL5UJg7MGgPNuENXKDefAveG6oKe9r3KGYsP35wTtY w6zWB9I9u4XyhOaUNA8HmZYPlSmQtlTWNidyi7xLCV9YyxfK9bvqX6Yg5VszBpWp2ywb sz9w== X-Forwarded-Encrypted: i=1; AJvYcCVKGiZRrKZDDTm7STw1njyUkFPWC2s2eBrtZZOU/dQ8Oy7OjrIiIqTpg8mllgoqN03/tiZ9B1r5dw==@kvack.org X-Gm-Message-State: AOJu0YxXMrP+zNf43EMmaTdsJJ+fBUbGQ/mUu4zRPsmcuU2i0DNsVDdn aUhF3GPUNrkTfrqf1t44GdROEzF2EELtBCJokLS917PS08tyyVbkzzsyQsPWZIWzKD18q8Z44E+ whXvwD/vEmJv4iuFLlt9qZ3+qH4R6CBCBu6cSygAmeWga/VXE23zgBo3+Rkz0 X-Gm-Gg: ASbGncu7AXIJA31u5yz2DubLwfI9/PZoPhMGQhP97tbQS0u6GX4rsALC3KcROkywC0a VGrIMgX7wYJWmIMKg3iraIgauFG+AdOSPP+hO+7XNSUHRmvmD8FDTF7bOwjTx+buwZ+z1EhE0Np LYM5ZKbJggnw7zuIKd0a4A//jl8TkcHJOu4ZJZIBZSn9ifdk6TWPoAPBpyQ6rq2SdSDKpxdipVN Z+9pzxWDvOGydR1nWjsVJz+uyCE42+DKZwQtwrsl5LOwu7enG3mD9NcBrmoLskhAMnwiQuejYpJ WwrUbOnVB6d3SUjSB5ez4r51x53AJhnylRRlw2g9AwRGOZHuGqL7v4ywxlh0Kfgs7B8HtPt3Kca FyT4T9g1XUhi9G3rkxupwDSdcplnyjHNHrUR5 X-Received: by 2002:a05:600c:3106:b0:441:b3eb:570a with SMTP id 5b1f17b1804b1-451f0a6a94bmr54009395e9.2.1749109770011; Thu, 05 Jun 2025 00:49:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZsjcg/PLPpLyQGdb23N26umjiH63blsW4LCsG+AuyVl004iXQAfjzXr57lLLdanZJ4s608g== X-Received: by 2002:a05:600c:3106:b0:441:b3eb:570a with SMTP id 5b1f17b1804b1-451f0a6a94bmr54009085e9.2.1749109769586; Thu, 05 Jun 2025 00:49:29 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2? (p200300d82f27ec004f4d0d38ba979aa2.dip0.t-ipconnect.de. [2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451fb22a7f2sm9315935e9.37.2025.06.05.00.49.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 00:49:29 -0700 (PDT) Message-ID: Date: Thu, 5 Jun 2025 09:49:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk To: Christoph Hellwig , Dan Williams Cc: Alistair Popple , linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, jgg@ziepe.ca, willy@infradead.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@groves.net References: <1799c6772825e1401e7ccad81a10646118201953.1748500293.git-series.apopple@nvidia.com> <6840f9ed3785a_249110084@dwillia2-xfh.jf.intel.com.notmuch> <20250605074637.GA7727@lst.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605074637.GA7727@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qbn1Kn28gvCnO2SJ9ZwBC1JHClP2KlpVF5aTH1fySBc_1749109770 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 47og6odr7whx8f5tfwrfxgx8pcha79da X-Rspamd-Queue-Id: 0A27B16000A X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749109772-570591 X-HE-Meta: U2FsdGVkX18Dz4pYlxjC0fJ7xaovQhIjFtm6pLDtygVpOorGKPTvz+ToxW8plGEyxDVkKtzroBW25DN+uoKRvaDCQIk9nVfgEfQCJ3wPRNjM7ptAGv0voq45TugxVTBC/IU+gPUjzxueynXL3VkJ8iBFbvm+kJrxDNE7JiSkKKey5ATVnS6RcgYVabYJbuiPFzYg9a9DUkYswoTbANBPRb9ndEtip20Z3GmRx4xCG2M+g6g/oouM2+lHnI7ZwaJgID/uaYmlxQsUMSPdbf3ALBY4nhrTk03BiTor0e5paluvooM1pOMUBddEXtDVKJ9O0M7T5CsscWZxuwGy3Ltaxu6H61vaN6ZL6Jj+iKMpYsrsBdGmmNHG/9+mMymS5Q/HtnaRfL/7Bs1eHkq4HoIOtBYSHtyGCX2XivFc1kNSP5kHlnKXtNl1DbZisSY3V1o+IRlYaAckXUOdun8gBdndKcwZXh2jr5rEsGve29vpqdoGdyzNIAChcYZ2M9uL2noljljehsDuR6h/YxRie+s/KIiRIaFnaOvlzMVGbeaFPLcMmQ61HE4hlAnWGm8P8Wtd0WIKewVC4FX+0Y9OkX8DADQ0DV84gASE9h7ZAnDvTWhfi1F3wfqt6BJzf6gJWqzCCpWaXAzHxx2PJvVl973vu1iKoTnfJveB2WB+G6jygNe4N6Yi/1WVPqGeAVKuLa58EPcZkIGPK8LMxtcedc+zDl18Y/BesBqyA2oIfl8KLEKqJLVqV7bHLtkflV7LSUbRh75huOZ8z6/p4GiFLi2/P+lLdnY+bEorTG9+HvnkGkcApGCWCr0hWLJCuDmNkhHQYVP6rggIODZi6GDpTMYm24S6mCALjpKEnVXC1kHXDM6qAlO00QwpJCKNwDPUNelt53frEG8NOzLduFdAV9DepE/fd28U421pSm7OUxlhkJZv9fg9sg38d9adsi0CHub3qyZjxutpF4ZZTE+e156 XSQ5/65T nZ+gmYYKL+Pdrb5650YQh6jWr8cvbBDYtmMJq0raKHfnpz/hqwVgHnsSWAWZ/RzTvfbQzcqZxI9Uq4iYhn+PEwqwgXWGMfbsM4OZv37BcHjH/yp3Cvc+oqosOBXObdFvdnvy6UWXUJxn5+qaKyAaBfQAyDiISTOmOZk2WCYAu9GX70OEtriPJm6vjVQvw/z1UE1JHBh+UJFcaRdEHsyrAewMvNU6+f5MLaptt5OOe0r7+JrL2NQPTfYyibgtTbF6h8sY6/Vk4UpcE3pFMPby1BAwjk9lYDUWC2iVkEnBYVewzNhr1L5U20zrv7nJaL3G5TCEcJcpXyroOwyP5HS8kqsgiOh8bFtjo+AUMg/JhIoYXdqK074qlXN6e0xSPnR5+jAfzKuxE3qjUdO24/dHSyhAIQIh+Rf1XmwuUUzwI14Ggwi+/Ueb+IufBFsZMrE9iIpJHbMXxvMVoEELAocNGMMGzD1LteHVtH3Op X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 09:46, Christoph Hellwig wrote: > On Wed, Jun 04, 2025 at 06:59:09PM -0700, Dan Williams wrote: >> +/* return normal pages backed by the page allocator */ >> +static inline struct page *vm_normal_gfp_pmd(struct vm_area_struct *vma, >> + unsigned long addr, pmd_t pmd) >> +{ >> + struct page *page = vm_normal_page_pmd(vma, addr, pmd); >> + >> + if (!is_devdax_page(page) && !is_fsdax_page(page)) >> + return page; >> + return NULL; > > If you go for this make it more straight forward by having the > normal path in the main flow: > > if (is_devdax_page(page) || is_fsdax_page(page)) > return NULL; > return page; +1 But I'd defer introducing that for now if avoidable. I find the naming rather ... suboptimal :) -- Cheers, David / dhildenb