From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93AD7C28B28 for ; Sat, 15 Mar 2025 09:31:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 681B1280003; Sat, 15 Mar 2025 05:31:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62F41280002; Sat, 15 Mar 2025 05:31:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A990280003; Sat, 15 Mar 2025 05:31:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 29D68280002 for ; Sat, 15 Mar 2025 05:31:49 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 98757AAE72 for ; Sat, 15 Mar 2025 09:31:49 +0000 (UTC) X-FDA: 83223268338.11.DF4E879 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf12.hostedemail.com (Postfix) with ESMTP id 9D8F340004 for ; Sat, 15 Mar 2025 09:31:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NTZJrNVl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.216.65 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742031107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E6fPl07TqZvI8KI3J541d5RAVfir/XDW72psEfNM9l4=; b=UFJMbj4VFBFx8u2hSr724m0eB+zBhfsHszm3fw/pjzsEAIDzYicLx59AlNS9aa7kjM3lMT fPlHL+HzCsgg7ukx/DmCA4RnqMLhk696LRoRp3wwSQIbcp1WMx6M1jVMYXKp2Yi09W4aHl zpGDkql8SwotEhHFDv1yTB+QOkM1RNA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742031107; a=rsa-sha256; cv=none; b=L7S8F2v0IDO+Ir2POsuxOqX6tbl3tJ6J9wU5GYHvfEpX3iMislh8ZlymwJG96u1UDYDT/X 7885A7qrUILVsuo/FLHjYHfB+htkmBxTdPEfh18GZDNk85j4+RQQwnGElI4967jqJfwgZ9 cvnIyy0arxX0+XmjaFrvmH1IqTFgKS0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NTZJrNVl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.216.65 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com Received: by mail-pj1-f65.google.com with SMTP id 98e67ed59e1d1-2f9b9c0088fso694985a91.0 for ; Sat, 15 Mar 2025 02:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742031106; x=1742635906; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E6fPl07TqZvI8KI3J541d5RAVfir/XDW72psEfNM9l4=; b=NTZJrNVl7i/qru4oVGXBefggpz+gsbMBdYa7g51lymhGXwi/Xv3Z68A9GCGg5Rv1vE d+BQgueMOpXDdbFGh1+jwCvm+eqqzKp9+6jzXwNYSq/kRx1tHO8/z4Qf3qaYU4Byu3yS BnbOS9OM5Ruf9iNWaqB3DLTp8jNVlqmh7a/gC6STCutxLbIB/leTcgipc7FHaI3wD+8M be0YqN0HlA1ipahYVtjlYI+BBt+SwOxhNCEiyynFjQaQ1ywohRGHnjNcanyEoDCs89p9 jTcDEdZ0Itsa5FHR+B8wemp4C4DKDy5Mivx9JotIAz2IgLL4qjoe8I2OL5yMzyK+CYp2 gk1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742031106; x=1742635906; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E6fPl07TqZvI8KI3J541d5RAVfir/XDW72psEfNM9l4=; b=veMGAxtP1nPChfZ0num2nxblxYIwpWzGrMslcXfV0687PbU4gMn5Rpbxifll6/Y5Bd KK+GuVo7bYh7Ip6iberHYHltiCIspLs64cVkm77KV9q8sop++d5fH4ZkP+2RhsM+hkgj Wz6k9uHWd2vFHIWCLX33dxmvFmcVa+Y1XT7OVqAC+vadwPyld8n0a07x1fC0dXFAlF5r ysq3A7ODwZHIc/23qhGU12TEdCa8bLGlouCoGeEL28gX82E/KILbA+HvNOjQPHY5zttR EYecycKhmbhr2m5AMk9tG8BqWptG5Tu54qsStni0mMzWf1FCxZ2jq3GnjPMuwkm0U3Qh PMvQ== X-Forwarded-Encrypted: i=1; AJvYcCVNIvsVLwhF6Dt8ssZQ9Ht6VKCDPx/V+A1Xify8ZbUZyqGIjvgpHhJxlL4+bBCffbW+8lB1lclUqw==@kvack.org X-Gm-Message-State: AOJu0Yxm+eg6/vEVr1ixRxDd738OgSW+OMZJbV5SouSVDBRIvHICsIbv 5dPveP2Qlduq77PztjxOBpVUbP+oEQeuh5GLEFzNOQ/tn9FOm4v6 X-Gm-Gg: ASbGncs8Y2o0OiFiglH1qyEXFluhdUiH3wjEgPxPGgF8vg4vMW0uk1VtaGDv2a07cEE ZQfl5zHqw++BmNcoShVzCoAi52X7Rv74A6bWRHavFaAvZ2cwrDG/Uhiq4Qki4+PN/0XqLMIoqM7 3Kgbcg0n42Ettadjnx9hSeyzbhAQX8nMrBTKqIoVRIiDP6CkHdueIbV9SdJPR+lJFXlKbzDkjwL Vo5aRjPtHDZwMx/3WhwKHcIgRsg434kqNEXsdoWGa0EuR0AjQbRJn4xuB13VAU/XI5Y0PhY/BZe V45kMq6PkRqxU94IJHz8LK1g0JHyiVpDxASpiZDEid3XTBiE6uz/5voBI4mr12n1Y738KWjdChj KC84YyKpdc5iSBx6WCfGWMm9U58fTup0d X-Google-Smtp-Source: AGHT+IHMKmDOMILytbSWMK7guB7TYp01XHN80NPMKwIikDzXh+u/oIxsZsN603rsFkMlSGLRJRzKVQ== X-Received: by 2002:a17:90a:d003:b0:2ff:53d6:2b82 with SMTP id 98e67ed59e1d1-30135f4e5f5mr12411785a91.11.1742031106303; Sat, 15 Mar 2025 02:31:46 -0700 (PDT) Received: from ?IPV6:2409:8a55:301b:e120:9067:2f1e:9768:2c54? ([2409:8a55:301b:e120:9067:2f1e:9768:2c54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-301534f49d7sm2380310a91.8.2025.03.15.02.31.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Mar 2025 02:31:45 -0700 (PDT) Message-ID: Date: Sat, 15 Mar 2025 17:31:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/3] page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org References: <20250314-page-pool-track-dma-v1-0-c212e57a74c2@redhat.com> <20250314-page-pool-track-dma-v1-2-c212e57a74c2@redhat.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: <20250314-page-pool-track-dma-v1-2-c212e57a74c2@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9D8F340004 X-Stat-Signature: y87x7g9g7h3nomn5aof6wi5iqzftxatn X-HE-Tag: 1742031107-841969 X-HE-Meta: U2FsdGVkX1+zVlJd60oTOdxOOO8l+lsehT8ubXwUE2yQqtaBMvHQHZTtPdWYP7M+PAaO8VesmwvXLlTxAd0Z4Lry+qtC0SSVi/Tu39iWwZSiGuVLf058NVZzcDuX1LdDgahzDYcLNMxBltfXvfK7lJs/U/BvGHGDyjFUTILIfkQ4AzNfKkCUvocq2EzQ8RpKiD3IZdNdZP5G/PkDVeHZEFv+XlGko+O0pbX9FR9oSgXB8117fLJ/LfbQhnesRxGKsIx+2h9jxoBgc4kIJcfKF18gfQwmqXj9EnCw0snRvpjO0kb3R5mvRB1ACN40hjw6qwFc4JOOXj8J8ozDNx8n8APhc32y8/bidWykKm+h6PN28pDIIwpfOCU0s/GnjEnn7YQsi7uOgg/RCPRWcIL3BMDsLMVrsqFHOcqL33YaQVgW7ugNrTHkcAHz4mMCwGZLiw0JnTPCph8o9PmQvCBuBsnGjkD4Z2ZVNCM0vfgUa//q3zwQfm6z6CX7YbFvLu7oikHRKuSwtmDzHjqJgJ6w1VPOdOk3MF+9saxjyjRbz7pWGvn47yDPiM1PGbimWr0IEXtL0f4tlb7P3pVvQ5PqQIOi0heg7mLpAMub0bLVbpnibF7u7CsRfUjgz3GrkeUoYFIT4UwERKFFEnVj8YjdUq2kr2VnlU5CP0Ps6a4B2aUOZ273tLabT87O7gXObMh1dUbRaarqo4d3ub7e+rAkusGf+d2dV/bjHdfcTzz0RDUw+hGY/5wUVRx18ioA2Oam/mB2h4SdCdUhjtU4UP5wTYUx/SZMvPK86TqATtAon6+wvkwGT2jN+dinVg4vxl3HqeiZJTOGJ5Cp0X4RZOOZZ3nc/K8RTgCtvh3bvpnD59YxIRf05g/TnarqyIGRBzxoKQNQ730AayGIdYfPostBUj0wnp0sn4Xm1FBBWtQPAecGKH2VS5NrA3M8yhsd4F4tyCGybCAkBEscS7Bn7bJ jJFSIbpj rczX4CaYXWc0QP/7QQpOQLN4bwHimcrwJtD1nbKvNCsBOjSEugBGsDlblMqV/CiBMdKqQrvWCAeFgoNiXUp/PnUhNNPHHtCLDpqBjaXQmOZ1PwZ89ENbrtfcUAOyltB7jJopSiNRm4LqXnCC65GCUUrBpxkIUYzwNHNJLZEsdGsyVM5d2wfyQaWwOVIgflNGsxC5H9238mDEM2qhVpe/sR6zsV7Tu/rqs6JNybLzotMzhgLAwzlvlP9RnqUmNLOmNUjJbmgrNaFQ+UO0BzHV0+kqpI1Afz1pZuMO+QG8aT3qYN7CuGsiUiUPUcBdHuD5RzrIC8vt79Y9d1x80GaNRbaf3LfF30LnjTJUVav+ArBr5Br3JEDE9IPEG1lW3h/voG49Gf69sZ/uqmQOU+IqB6v+JKgi+fK5FRWVPlvlxcyzTuKlF8lyAUM9gVTJJfWc5b0tcUXOmbWVH9qRqi/q1F4vykchBVrCgboc7+OZiiY2506YPWFCmVoOh02cWvHxhsLdmayEX1AZjgLgqnB5jgPxkEQwwmmM60/qXRa49ZuZeaFv9JraZdrXaBU8QGi7BmaG5h3EBqNifyEfsk2O0gMAYrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001504, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/14/2025 6:10 PM, Toke Høiland-Jørgensen wrote: > Change the single-bit booleans for dma_sync into an unsigned long with > BIT() definitions so that a subsequent patch can write them both with a > singe WRITE_ONCE() on teardown. Also move the check for the sync_cpu > side into __page_pool_dma_sync_for_cpu() so it can be disabled for > non-netmem providers as well. I guess this patch is for the preparation of disabling the page_pool_dma_sync_for_cpu() related API on teardown? It seems unnecessary that page_pool_dma_sync_for_cpu() related API need to be disabled on teardown as page_pool_dma_sync_for_cpu() has the same calling assumption as the alloc API, which is not supposed to be called by the drivers when page_pool_destroy() is called.