From: Yunsheng Lin <yunshenglin0825@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Simon Horman" <horms@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mina Almasry" <almasrymina@google.com>,
"Yonglong Liu" <liuyonglong@huawei.com>,
"Yunsheng Lin" <linyunsheng@huawei.com>,
"Pavel Begunkov" <asml.silence@gmail.com>,
"Matthew Wilcox" <willy@infradead.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH net-next 2/3] page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap
Date: Sat, 15 Mar 2025 17:31:29 +0800 [thread overview]
Message-ID: <b0636b00-e721-4f21-b1c5-74391a36a3be@gmail.com> (raw)
In-Reply-To: <20250314-page-pool-track-dma-v1-2-c212e57a74c2@redhat.com>
On 3/14/2025 6:10 PM, Toke Høiland-Jørgensen wrote:
> Change the single-bit booleans for dma_sync into an unsigned long with
> BIT() definitions so that a subsequent patch can write them both with a
> singe WRITE_ONCE() on teardown. Also move the check for the sync_cpu
> side into __page_pool_dma_sync_for_cpu() so it can be disabled for
> non-netmem providers as well.
I guess this patch is for the preparation of disabling the
page_pool_dma_sync_for_cpu() related API on teardown?
It seems unnecessary that page_pool_dma_sync_for_cpu() related API need
to be disabled on teardown as page_pool_dma_sync_for_cpu() has the same
calling assumption as the alloc API, which is not supposed to be called
by the drivers when page_pool_destroy() is called.
next prev parent reply other threads:[~2025-03-15 9:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 10:10 [PATCH net-next 0/3] Fix late DMA unmap crash for page pool Toke Høiland-Jørgensen
2025-03-14 10:10 ` [PATCH net-next 1/3] page_pool: Move pp_magic check into helper functions Toke Høiland-Jørgensen
2025-03-21 17:16 ` Mina Almasry
2025-03-14 10:10 ` [PATCH net-next 2/3] page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap Toke Høiland-Jørgensen
2025-03-15 9:31 ` Yunsheng Lin [this message]
2025-03-17 14:55 ` Toke Høiland-Jørgensen
2025-03-21 23:13 ` Mina Almasry
2025-03-14 10:10 ` [PATCH net-next 3/3] page_pool: Track DMA-mapped pages and unmap them when destroying the pool Toke Høiland-Jørgensen
2025-03-15 9:46 ` Yunsheng Lin
2025-03-17 15:16 ` Toke Høiland-Jørgensen
2025-03-18 12:39 ` Yunsheng Lin
2025-03-18 20:55 ` Toke Høiland-Jørgensen
2025-03-19 11:06 ` Yunsheng Lin
2025-03-19 12:18 ` Toke Høiland-Jørgensen
2025-03-20 11:17 ` Yunsheng Lin
2025-03-20 14:34 ` Toke Høiland-Jørgensen
2025-03-20 2:32 ` Solar Designer
2025-03-20 14:37 ` Toke Høiland-Jørgensen
2025-03-17 2:02 ` [PATCH net-next 0/3] Fix late DMA unmap crash for page pool Yonglong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0636b00-e721-4f21-b1c5-74391a36a3be@gmail.com \
--to=yunshenglin0825@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=toke@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox