From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B9F2C4345F for ; Wed, 24 Apr 2024 10:40:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B22AB6B026C; Wed, 24 Apr 2024 06:40:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD1B16B026D; Wed, 24 Apr 2024 06:40:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 999266B026E; Wed, 24 Apr 2024 06:40:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 738C56B026C for ; Wed, 24 Apr 2024 06:40:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C8F42A1AED for ; Wed, 24 Apr 2024 10:40:13 +0000 (UTC) X-FDA: 82044080706.22.C7F3397 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id E766C20007 for ; Wed, 24 Apr 2024 10:40:11 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713955212; a=rsa-sha256; cv=none; b=czEulQMaRNy1qXwwuWcrFQ9XCKMBwL4K7DnGuO2+Pecw5B+NTdy7VRatsE1qgg0R8sOGmn 19rhQtN+oWe9HjZ2NttXxP9Y83GZy6e0tA+gD4lOk6aFJOrxT24D+hKOZ1NIK/oaCvR3D4 hUyxAljfXlADtAlu+y6hC4a3ZusiUM4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713955212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p43ecGq307xK4f/OIBRDF6TUDmVWPZB4zHFOKFPrjy4=; b=bz5e44UgTsA7NkxCmfCRILfyKn0bbQvB8Pw3/MJrYgTcy2Fka9ehgc9b3FwTgdCmgrwGTC Qi3/VrauV4qMQzmuKHpdhU47fp6+ghxBZRJmy02TydyrNkoQeJjptXz0z3wtWaK5z76Vjg 2Lx7EttEDRNwS9bRwGlkWedJ+Yw/hVA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D54B2339; Wed, 24 Apr 2024 03:40:38 -0700 (PDT) Received: from [10.1.25.156] (unknown [10.1.25.156]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 647B53F73F; Wed, 24 Apr 2024 03:40:09 -0700 (PDT) Message-ID: Date: Wed, 24 Apr 2024 11:40:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 5/5] selftests/mm: soft-dirty should fail if a testcase fails Content-Language: en-GB To: Muhammad Usama Anjum , David Hildenbrand , Catalin Marinas , Will Deacon , Andrew Morton , Shuah Khan , Joey Gouly , Ard Biesheuvel , Mark Rutland , Anshuman Khandual , Shivansh Vij Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20240419074344.2643212-1-ryan.roberts@arm.com> <20240419074344.2643212-6-ryan.roberts@arm.com> <6a08436e-c984-43aa-bbfa-05cfea34516a@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E766C20007 X-Stat-Signature: ok71wriyzkgoya5rh3oqetyj7exfqytf X-Rspam-User: X-HE-Tag: 1713955211-520699 X-HE-Meta: U2FsdGVkX1/VOfDNYxA3RSgiV5KxTwKHKFmvcJWP8BXxZA8LW/zGb03kIDF4HjfvoXPJJHn7PACGhLiL35hjy+1F5zvLk9TchIsGlGUDHY5hFq8isXCw481puIpIA4NUs8v0obhi68CPmKlBKM64wGmv/nTZqFi+3ITV9fE1gWY0u2MDRyGmNpBhothTYu3DjFv4FgFljELQeL2Nke4TKsXq9VLfuUSmbdHRM1+UeX0aeOhvBiuXgXpLEhNwAV5FdfkUgHCUgVcxgwde7GIe2gPTaa2jFYkWxdDVB0YI45HxdoGNRhGvigyPjhFYZmxdih8HO0fDV+cgITJK/Nk9jfzzXpYq3/9nkVfWavuJin5pOs0rAZA9eQFBq1woE1hJNywzeIEjaNdw7EJUpzg+7E88uYGM7bHoCWcxQn0wJ3pOI5kgOc6Da15KvWqs72NcSFbqTyM6ioOU9eFOevpZw3vQg8nNcyjJCImhrXoDHftnKpSi8f/qBI3ywdiuqK315k//5XAkFFxPqiyx+ul6rUBjGRomWLRrOklG2iFXkf0LJk/FXuy8av5NIWlULF0bvj3oF3597yHcEXDE3ImXDLLfwngMs2UhNqVRYCBBvuHRZyHON+U8YAwmL7h3ZBB7p/fI2zbyZLK6+zQU8dLqD/TtI4WJccAXwUP/iEj+q1/tCz3svAr2H9IVXsTiXE2RT3w6oa394k0o9yGDlH4jDg2RXnDZhtwOwBGYeEfDYq4qWxy2uHT0woCVQh32YnK7dgqJh0X9xFJccQ/R7hE9JVWpV9a9nF1mS/tRkmYsqpQInWek0mvYZbSMxltW/zntsWQbsypy6C/GnmuPXifXnuIAeeE1Plu4xCd6cPm2LfCbstIP4qNe78lglc1xPYH/VPXyNjp8e0lKI21FQWIKr+i09I8JltA8eUQgs0+lozU8E9vBKqD09tg22Tlt71vJi5NJy9kVfHvS/2HW6V8 mjYxJmHe yZUp0WlOYkwO5dS5oE8f9EVOWUtcWyNtK0Yhf++7wOk2Gnz+n/MP8078XepV3c+3jGyKk+xP//S83HQYWIe86fVnHvJ36K0CPMcrYzKWwkK1tBFtz/yF+IDprIZqnWq677ss5Iw5E42p1gxsG7Me/c368r+T5Kv2VsjlkDugjM2qbbJFV1zKP9YJDl1S4o1wp5guBBa7FNHc4qQI+Gs4VXT2FXXFwQ4ETU5anNIVFkTDY5ntZhGYjTVNnLxpTGQPc81b0Z8W4Im7uUimgcfJQ3ThqrDE7M9jbf8mmJNLbV0ORdLmpMJ1p5d4bUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23/04/2024 09:44, Muhammad Usama Anjum wrote: > On 4/23/24 1:24 PM, Ryan Roberts wrote: >> On 22/04/2024 10:33, David Hildenbrand wrote: >>> On 19.04.24 09:43, Ryan Roberts wrote: >>>> Previously soft-dirty was unconditionally exiting with success, even if >>>> one of it's testcases failed. Let's fix that so that failure can be >>>> reported to automated systems properly. >>>> >>>> Signed-off-by: Ryan Roberts > Reviewed-by: Muhammad Usama Anjum Thanks! > >>>> --- >>>>   tools/testing/selftests/mm/soft-dirty.c | 2 +- >>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/tools/testing/selftests/mm/soft-dirty.c >>>> b/tools/testing/selftests/mm/soft-dirty.c >>>> index 7dbfa53d93a0..bdfa5d085f00 100644 >>>> --- a/tools/testing/selftests/mm/soft-dirty.c >>>> +++ b/tools/testing/selftests/mm/soft-dirty.c >>>> @@ -209,5 +209,5 @@ int main(int argc, char **argv) >>>> >>>>       close(pagemap_fd); >>>> >>>> -    return ksft_exit_pass(); >>>> +    ksft_finished(); >>>>   } >>>> -- >>>> 2.25.1 >>>> >>> >>> Guess that makes sense independent of all the other stuff? >> >> Yes definitely. What's the process here? Do I need to re-post as a stand-alone >> patch? Or perhaps, Shuah, you could take this into your tree as is? > She can. But if she misses it or you want to post v2 of this current > series, you can just send this one separately. Usually I try to send > separate patches for trivial and discussion required patches so that there > isn't confusion of this kind. Thanks - I'll do that. > >> >>> >>> Reviewed-by: David Hildenbrand >> >> Thanks! >> >> >> >