From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50518E7716A for ; Tue, 17 Dec 2024 10:00:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C06186B00B5; Tue, 17 Dec 2024 05:00:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB57A6B00C6; Tue, 17 Dec 2024 05:00:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2FAA6B00C5; Tue, 17 Dec 2024 05:00:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7EE996B00B4 for ; Tue, 17 Dec 2024 05:00:06 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 09FEA1C6E9B for ; Tue, 17 Dec 2024 10:00:06 +0000 (UTC) X-FDA: 82904003406.09.2A151D2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf27.hostedemail.com (Postfix) with ESMTP id 11E9140010 for ; Tue, 17 Dec 2024 09:59:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OKffFEaN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=7ZSEQb9Q; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OKffFEaN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=7ZSEQb9Q; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734429575; a=rsa-sha256; cv=none; b=4Vb+1T7nqyVrz14t9H4qkExn0lXZnc4wL/XlPH+BUPg+zL+LIivRUtouHVkv0EzsiMWy/L 8AeFqyuwcjuzvengk4mggOorlWsq3au+OkNy720oPj9x2crrjTEBe8z7VAHumJmXJlIq2i IsVtoGbyfyVmPiyeoJKysVHKCdWGQCc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OKffFEaN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=7ZSEQb9Q; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OKffFEaN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=7ZSEQb9Q; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734429575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IX72Ag/8IIGl3Wz7CEvCFtdkTS0+bzcHv2Ag32FMstU=; b=tyY1bjoGW4XYe/oHrWkqBBZnqTt5TqfRTZXZzle7gZ352YgxJxzrABKt4DKYKmYAUlGmk+ wQcA1BKdpAoHNL+QTz1UF8FgMJU6S6kahEB6vb2EHepU3XP/DuKd2F3ZgSelGEAw/Fc1cr vuCmcmnCtupxy8nzkDiyNChidsXH9tg= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7083E210F0; Tue, 17 Dec 2024 10:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1734429602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IX72Ag/8IIGl3Wz7CEvCFtdkTS0+bzcHv2Ag32FMstU=; b=OKffFEaNmRra9tkiQkDgjUYALpxvCaFdWapVG5rp2VNwk99GYSL81o3I0yjkrVLBzZQn2s tuO6Zz4d+41b4y1yEIcX47atVTm8vwWQ8sV+SB27MtvyLTmIq3v86IceaIBwpRb5jcCvNJ ZLxHDA9Qdw7ESK0Bnk/hDjmtpG7cRpE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1734429602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IX72Ag/8IIGl3Wz7CEvCFtdkTS0+bzcHv2Ag32FMstU=; b=7ZSEQb9Qs7GAsN/oCt9UPlqnJHioqzcFI5uBy7EC7Ol0mxuQhD8wHgHDTwYHBO6FYLVh0V PQbtxWFj3KDFu2AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1734429602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IX72Ag/8IIGl3Wz7CEvCFtdkTS0+bzcHv2Ag32FMstU=; b=OKffFEaNmRra9tkiQkDgjUYALpxvCaFdWapVG5rp2VNwk99GYSL81o3I0yjkrVLBzZQn2s tuO6Zz4d+41b4y1yEIcX47atVTm8vwWQ8sV+SB27MtvyLTmIq3v86IceaIBwpRb5jcCvNJ ZLxHDA9Qdw7ESK0Bnk/hDjmtpG7cRpE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1734429602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IX72Ag/8IIGl3Wz7CEvCFtdkTS0+bzcHv2Ag32FMstU=; b=7ZSEQb9Qs7GAsN/oCt9UPlqnJHioqzcFI5uBy7EC7Ol0mxuQhD8wHgHDTwYHBO6FYLVh0V PQbtxWFj3KDFu2AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D2E8513A3C; Tue, 17 Dec 2024 10:00:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1CiIMaFLYWfUOQAAD6G6ig (envelope-from ); Tue, 17 Dec 2024 10:00:01 +0000 Message-ID: Date: Tue, 17 Dec 2024 11:00:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 03/11] fs/buffer: add iteration support for block_read_full_folio() To: Luis Chamberlain , willy@infradead.org, hch@lst.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org Cc: john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com References: <20241214031050.1337920-1-mcgrof@kernel.org> <20241214031050.1337920-4-mcgrof@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20241214031050.1337920-4-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 11E9140010 X-Stat-Signature: rooj8ruyum9m13ijcszkpeiia8xsdwx7 X-Rspam-User: X-HE-Tag: 1734429569-34850 X-HE-Meta: U2FsdGVkX19NtGVdk0kaS1J5+kqCxs6Bom9yNZcG30w+8qMSvDbKpJ3a7P4lP+PBcuaZES9xkNci6CdGquq5HL6E5ZUFWP+mNjd7MKEKuD0Lz8hBuNj+gaNADgppqZQ+pVP/3z84sswFBFtX7eED6j4lQpsUV0zLttx4Eu+y0CPH6j1xvaKmQy+52GFnR0xqEnd+WIOZsfGfaC2KW0uNhmR54JbmPDdJ0y5CPQLYOHXTpgHY/kTnU3KcxWKDSIma1DsyLPz4hrUbX51pzdxZQiqnOIFnDEy8YyD/TF/k/gvBsDtHZ0vjysngSkzS5AOvNrjWaz0rVvTmUDwuAquEJCZm1RBeTukr35Q15U2GZmhU7wgH2rrd/V9EWBDOlo9nGWOVEnM7CThPLrLN5h56AMh+DLENpuBHtq02lJ5qbUylj9ZQrhZw/Ib/al0Iegvbds9frlejfIHf9WPga8SZUawwGKxhiqC9BbQW3ffdJNIZrar4t0riOfU1iaid7rB0YJEvazSX7C6ZXLPpA4p3HfB337ehtUW0y2vb0isks5/uRMFlk+gPm7/gqaWExLSAGzOIf97ecmhavo7xfyt0nbUhwYB4nYwoUx3JC/eeS4BmHQN4lXJNtI+SKQRrI6LsdE6R6ObXdAn3JqxHZ8SaaJ/aC9gbA1Y4Y6c6EVbI3Qji0HINy2FaxL2tq9OUTsCBkiQhbXJjDVK1VT2CZjKxFO34re1OWq/nJr36jRShTpAUb9S2Cfgl94IfyLPLKh3fzLhxNCw8k4qes7lLg5BtQ+Yit5hboPHA8bYc1MfyK/59ECrJ5m9Nv3+pLyh5Ho5jz84nf5sBeeYEhnlpMFXdJfb/MnLBmmD4LJzqc/TyDIHlT+Z65ooSEmCp159xQOL0nB+R+HF9JMF8NNwVZvBGqivXzZRj4FYR+R6+BPNdx931OfWFpzIcAEFEgi7O0B9NDHQuUCjZisdzANvhNJO KbGSbpC6 hnfhNtwL4VPaLyFCLFJfZayuXwl2DerG+JW76/u7iLLzP/GDrZ5tvl22z3ZmMmiZfT17qlZclwyMlnK5BLRXeQdc1Fumn/GLP9Yl21QAPCZ5OSlmPHE0ClwfVaRVXo+aCCt4+yZSjkpviCk226qqfYaEATrj5PCCIoLDE1q0XC4Py81+SfyPrIkKQJe+qAl7SQvpxaeiNmlcsucA8UFMP5oFdrVaaPxOhiHYUOlj/v9hIrRyWKarZ59LqqbC7pCBJvJTuSCbLBHMdOoWFxf/1296jjZr1Jx+b+J/0D1Fphb1b9jjuwgRN0cH8lZvjwsDRis3u9/JNTH487C4vgQi1kPR/KtXH578tcHAoJK+mAm9J/WpLGjG0FvD5ikp0YrODRoh23I9WR++4mMYJ+OSA33P/al7MZPIdAAD0taz1sscPmIDlLFpO22wusieyEeNyVQ552sSbagdGrQvZ1A0N+ffzJDISHbx4quNc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/14/24 04:10, Luis Chamberlain wrote: > Provide a helper to iterate on buffer heads on a folio. We do this > as a preliminary step so to make the subsequent changes easier to > read. Right now we use an array on stack to loop over all buffer heads > in a folio of size MAX_BUF_PER_PAGE, however on CPUs where the system > page size is quite larger like Hexagon with 256 KiB page size support > this can mean the kernel can end up spewing spews stack growth > warnings. > > To be able to break this down into smaller array chunks add support for > processing smaller array chunks of buffer heads at a time. The used > array size is not changed yet, that will be done in a subsequent patch, > this just adds the iterator support and logic. > > While at it clarify the booleans used on bh_read_batch_async() and > how they are only valid in consideration when we've processed all > buffer-heads of a folio, that is when we're on the last buffer head in > a folio: > > * bh_folio_reads > * unmapped > > Signed-off-by: Luis Chamberlain > --- > fs/buffer.c | 130 +++++++++++++++++++++++++++++++++++++--------------- > 1 file changed, 94 insertions(+), 36 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich