From: Paolo Bonzini <pbonzini@redhat.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, mhocko@suse.com
Cc: akpm@linux-foundation.org, glauber@scylladb.com,
linux-mm@kvack.org, david@fromorbit.com, viro@zeniv.linux.org.uk,
jack@suse.com, airlied@linux.ie, alexander.deucher@amd.com,
shli@fb.com, snitzer@redhat.com
Subject: Re: [PATCH] mm,vmscan: Mark register_shrinker() as __must_check
Date: Wed, 22 Nov 2017 15:31:14 +0100 [thread overview]
Message-ID: <b04f6093-3b22-e57f-a276-bfaaf3b0ba1e@redhat.com> (raw)
In-Reply-To: <201711222206.JGF73535.OFFQSLOJFtHMVO@I-love.SAKURA.ne.jp>
On 22/11/2017 14:06, Tetsuo Handa wrote:
>> I am not sure we want to overcomplicate the code too much. Most
>> architectures do not have that many numa nodes to care. If we really
>> need to care maybe we should rethink and get rid of the per numa
>> deferred count altogether.
> the amount of changes needed for checking for an error will exceed the amount of
> changes needed for making register_shrinker() not to return an error.
> Do we want to overcomplicate register_shrinker() callers?
For KVM it's not a big deal, fixing kvm_mmu_module_init to check the
return value is trivial.
Paolo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-22 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 12:02 Tetsuo Handa
2017-11-21 21:40 ` Andrew Morton
2017-11-21 22:09 ` Tetsuo Handa
2017-11-22 10:53 ` Tetsuo Handa
2017-11-22 12:45 ` Michal Hocko
2017-11-22 13:06 ` Tetsuo Handa
2017-11-22 14:31 ` Paolo Bonzini [this message]
2017-11-22 14:36 ` Michal Hocko
2017-11-22 20:39 ` Dave Chinner
2017-11-23 6:34 ` Tetsuo Handa
2017-11-23 8:02 ` Michal Hocko
2017-11-23 9:21 ` Paolo Bonzini
2017-11-23 9:56 ` Tetsuo Handa
2017-11-23 10:02 ` Michal Hocko
2017-11-23 10:38 ` Tetsuo Handa
2017-11-23 10:43 ` Paolo Bonzini
2017-11-23 11:03 ` Tetsuo Handa
2017-11-22 12:33 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b04f6093-3b22-e57f-a276-bfaaf3b0ba1e@redhat.com \
--to=pbonzini@redhat.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=david@fromorbit.com \
--cc=glauber@scylladb.com \
--cc=jack@suse.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=shli@fb.com \
--cc=snitzer@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox