From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCF0C0015E for ; Thu, 22 Jun 2023 14:48:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A5598D0003; Thu, 22 Jun 2023 10:48:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 255268D0002; Thu, 22 Jun 2023 10:48:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11E058D0003; Thu, 22 Jun 2023 10:48:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 040468D0002 for ; Thu, 22 Jun 2023 10:48:03 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B6EB9AFE0D for ; Thu, 22 Jun 2023 14:48:02 +0000 (UTC) X-FDA: 80930663604.22.6A6D4A4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf18.hostedemail.com (Postfix) with ESMTP id 8204C1C0026 for ; Thu, 22 Jun 2023 14:48:00 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YraQJudJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6XBRPNh3; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687445280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+0hFI3xJ2OGZHWhdLSxnOFvnT5Y+IP+BBRNQel7RyVs=; b=0uX/18ZzWR6hCedZP1RuTbGWK1XTfoGBw1WCSHreSBRgYxaRfVXwJakBtGkc9exYkhT2/X XQvfLlc2uDqWlOYWvRZvjrvoQIbdf4YE9ZT2Y2wvA9GBCBXq7g/ilZJxrE+WjWmH9QlFyi sGW/B+l43hClKxUFFfJG4nX9XYLp/nM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YraQJudJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6XBRPNh3; dmarc=none; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687445280; a=rsa-sha256; cv=none; b=ZqjKXhWGJMeGIS6SIyBYDQHAftKE553d3h+2yhrABYAXYWSPBnxbjL2+DpFTRYm9zVssTm CIZmAzeKxYDb+ADwvPyX+DSmmDt21xHRkISrDflb93Xel08DO5DPFNAOuMkrIDcuK+CFtD En5YwSxGXrD2CkD1HS72h0OSW5USkDk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 22955229C0; Thu, 22 Jun 2023 14:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1687445279; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+0hFI3xJ2OGZHWhdLSxnOFvnT5Y+IP+BBRNQel7RyVs=; b=YraQJudJxxlhLJeEEEMxIUpfKYnVAv60cpmpHUQTGUBUh8t+ZXVmLjxm9M+1UGDbzHnQsz y6MEklPR6hPtAV8L33jHrD9qnGqvcBlma7u4mxdi/4lNztRux4EuDbVLobNoZf1RBa/v9Z PHfZlgjn/oBKddDSwkaKW1hcpThgEsQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1687445279; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+0hFI3xJ2OGZHWhdLSxnOFvnT5Y+IP+BBRNQel7RyVs=; b=6XBRPNh3BjOoRZ1UijrujZWnxKxTKGitdF/zIOBj8hh8OwgFWdOjIPj2xpz1ePgJ9tQjeA VaJVHD8gCvpB4lBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BA77013905; Thu, 22 Jun 2023 14:47:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id awUvLB5flGSsIgAAMHmgww (envelope-from ); Thu, 22 Jun 2023 14:47:58 +0000 Message-ID: Date: Thu, 22 Jun 2023 16:47:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 01/29] mm: shrinker: add shrinker::private_data field Content-Language: en-US To: Qi Zheng , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-2-zhengqi.arch@bytedance.com> From: Vlastimil Babka In-Reply-To: <20230622085335.77010-2-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: srfmkxayd3h7wak8afnjrzk61565w53f X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8204C1C0026 X-HE-Tag: 1687445280-980183 X-HE-Meta: U2FsdGVkX1+e6w+GmxKTcbqxoug8O5fsW34ci1IBCuQcEkyTTD6t7toory3xP6wCLkcT3SoYFzySufojgyki1jgvO2XZpDP14+vS7wDoP8lIP/PuhbUc2OzYxPszMOPtTPqIK7Lf5vG9nbXdNTF2wGQJO493y2x+EgndTT9c++hP2P4WCR3BHhr8zd1LuCWFCVfeSLjNXdajrxHHJS9tnomzU8H8djcuou1ildGSmd/4JJmfO0PZbCAgANLckmGXE+Lp2/ruxBM1yXykPuiupdRZ/8Nn1dmkDwSZn7Kv7+L01S4NyWL7u6eG49IXlh/ArapyPAtdUrtph0jE9u2EhbwCvOnHa0R/jdN6aa68FwpDESBhmk86jAH+pizIqbRPi+sgd3x88P6Skou/zpmgAz57dScugTgGBobp6XcmZCjteEOsk1OWZbFaVZikX5nab6ljc+UeMVyNNqlpQcYmgdlY91g8wCI/6OInV/5cKCVdTCu3NTtuLeEVoMgGWag6EbNQciRw25WLmDH7AAL9bPtKRKeEVa4Bqw1Hq5EjJXyJLbR3N0yls3zj5+LEM9QCC1DZhPLgyulk0g2uW7/SZdD7GeNUMHmDC1IeWRuX5qTPs4Dy6qeCOBnOzrvHjR1UOwnRPAmKGTVNuRdLl49OpjgEvwt3fGWeqDdiK5jrFW1CGaJCWp/t4LAv4WaSV7t0lb3RruaqmYVysiOrpwmL1c8whY80KIJSL0UYZgBt5KAVAdMPU8UuRNqUO3wfxkprDXZD5UPDYOy6uX7rfIrE5z3xgfwjR3qkrNmsMMPheC2ef6oyleLU8QxoB/WstxI0HTXniwiyBqRKPhpKtgVdvgQ9xYn95SOWzTicyuU9H3Xdjat7GBw/pKM8DSxUgozE1hgsgPeRNdxWAtCkoXSjW5GooaCvPVH3oYDJrNYweg245TBCjMyauupwmLcPkJgppiz6S2yMie4Dv41f0Ss 4YECNE5u nd0APtX/jcUjmy+Ti1fgC96JB10wCGA+DHHlJYFfyDRdwIDmtxnTqvUd01fl2qGhmu/NS66o6MZNFc4X+nAYUiN2AjbEhOP0XsVr4kY8KZxNxtTwCQ4zcyhmJxLM7NsvvQZ0DyGwp7jb3uDUVvZ/OjyJMHLS1MPyKx3Uk10ZUQ7fAQhrV+xE0JHflW6FGyD6uWoQHi+afS91yrFEOeCZFMziqRGFwhg6EpbGnAO5zqbnrADrEJqKVY0X9s+PnW5yiZwy13BS3HAiqIjhz6nSXC/fiBA5V4EHyzApEImCn+lgigzwcSRsSS2hJiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/22/23 10:53, Qi Zheng wrote: > To prepare for the dynamic allocation of shrinker instances > embedded in other structures, add a private_data field to > struct shrinker, so that we can use shrinker::private_data > to record and get the original embedded structure. > > Signed-off-by: Qi Zheng I would fold this to 02/29, less churn. > --- > include/linux/shrinker.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h > index 224293b2dd06..43e6fcabbf51 100644 > --- a/include/linux/shrinker.h > +++ b/include/linux/shrinker.h > @@ -70,6 +70,8 @@ struct shrinker { > int seeks; /* seeks to recreate an obj */ > unsigned flags; > > + void *private_data; > + > /* These are for internal use */ > struct list_head list; > #ifdef CONFIG_MEMCG