From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6BA8CD1292 for ; Mon, 8 Apr 2024 20:07:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E6136B007B; Mon, 8 Apr 2024 16:07:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 396056B0082; Mon, 8 Apr 2024 16:07:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20FA56B0083; Mon, 8 Apr 2024 16:07:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 02CF56B007B for ; Mon, 8 Apr 2024 16:07:09 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7D80AA017D for ; Mon, 8 Apr 2024 20:07:09 +0000 (UTC) X-FDA: 81987448578.17.5ED35AD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 4CB02180003 for ; Mon, 8 Apr 2024 20:07:07 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V5qkHeIi; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712606827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RXDUOOacueTNhjYoA1MSPWfoyZAMEiLovHwXNWshglo=; b=AIihKRsBk/CZ/v0FQBsN2PcjnkcqwghE+DPaa1CbXOsVAqyBr6CQOmLO13X+byj5Pw7ZhD tqJQnjAqi0KtHvnKa5gvkxlrBAA89qqdw2z7k/LSHUkSs3a69MzTk7SJKdhCRUu/NHsKce bgX5mgxKuf14P75t+ykk79sElx8lvQg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712606827; a=rsa-sha256; cv=none; b=otPEE469THyQsDJygqCYYnYWMvN0LA6n3kZGzpR2AzCo3zbNXSAXO8XrZlPe1XiY2gK8WY u44jK7hemJStLV+SNkf5B7JA5rnPs4zBPPlwEVGv+6+OBOc6oZeVZsgmF9hNcRM/4x6j+x wANXaGFs57Gys/e61TDMmsosyVmtseA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V5qkHeIi; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712606826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RXDUOOacueTNhjYoA1MSPWfoyZAMEiLovHwXNWshglo=; b=V5qkHeIiPu2/XY4V3U/jAKWl8/xCL+us9AZKp2w3U86SYZtdDfMhc9G6qzlaDN9JOwdGLC M3XiLzRDuW7Hj9CYo8/UIngaiQSwGsPBda7CFUOqBdYUUL1+qaJYVvPpqBHb7wqMaLZ39K FRlz3neD5Q97IDE8GFDHePTfXFAIsw8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-dYXNoJe5P8uL6RE86oaINA-1; Mon, 08 Apr 2024 16:07:04 -0400 X-MC-Unique: dYXNoJe5P8uL6RE86oaINA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-416612274e7so5000665e9.2 for ; Mon, 08 Apr 2024 13:07:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712606823; x=1713211623; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RXDUOOacueTNhjYoA1MSPWfoyZAMEiLovHwXNWshglo=; b=I9gT2dpHY4ZBhv1sI1idw6EQELHoP7usOLs82jhzi3E+ijg8GjNTjGvx5hSGZWhHpz VBS/gHkN/yvrrhtR0FoRm3esPlznafdHkzGBqvE1NNzeKOzgJtvPtb4qPDtLj8v7DrrJ 10AaywKMbkXcBDqYc5pyJbOrHuY0QoLsH4lGRvjnk+K8GCJNS8aMEt85tIKjZ2qrVyav EHXtv4lau/eInyh8sWrqzUYXcnEiFBWvY15118JioK8bKAGzOw+uLuSJ2VrI5vubJyVu ZTCANsAX2egNEXI8qVjk8y0TiRWRgpJGEJPlBD/Fl/uNy+d3MauoVSrKh80gw60Ci7vI VEAA== X-Gm-Message-State: AOJu0Yz/o76wwjvdvhPfKwQtn43ZKwYJFUAI2VhPQ4325s/q1rR8H+zH U0TUsfc6H48NwgR/iS3AvGM4hCynwiFsE0jXit8DhE2bUgJr/SezPTmUn/fJESWSQVxfEsw4a0x WO3kP67oRqveN21WFXsChBAallck8R2WvOpw0+f4peZhBzY2f X-Received: by 2002:a05:600c:45cc:b0:416:20c2:3b00 with SMTP id s12-20020a05600c45cc00b0041620c23b00mr6845674wmo.13.1712606823670; Mon, 08 Apr 2024 13:07:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGeOqUUmS4EkNQH7OL72KiwP/9d1uHm5eJTWch66iBFUID8rQ5EwuzFhTNSycN+5GqkaCP87A== X-Received: by 2002:a05:600c:45cc:b0:416:20c2:3b00 with SMTP id s12-20020a05600c45cc00b0041620c23b00mr6845661wmo.13.1712606823248; Mon, 08 Apr 2024 13:07:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:1300:9860:66a2:fe4d:c379? (p200300cbc7181300986066a2fe4dc379.dip0.t-ipconnect.de. [2003:cb:c718:1300:9860:66a2:fe4d:c379]) by smtp.gmail.com with ESMTPSA id v19-20020a05600c471300b004157ff88ad7sm14564561wmo.7.2024.04.08.13.07.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 13:07:02 -0700 (PDT) Message-ID: Date: Mon, 8 Apr 2024 22:07:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] khugepaged: Use a folio throughout hpage_collapse_scan_file() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240403171838.1445826-1-willy@infradead.org> <20240403171838.1445826-8-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240403171838.1445826-8-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 3d4n4egu8mjwuidbz3793c1y1o9nenit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4CB02180003 X-Rspam-User: X-HE-Tag: 1712606827-975984 X-HE-Meta: U2FsdGVkX1/2Fxnz9nA9c+YH8Z4cn/BzzexdIdTO5/M5Iky5aoJ6gioQlTepmXXGtVZhunKEzjhHHkgtlfTgl6Jq2SQg+E/08+R0sPZoWoKLClYgOPw2HLvMOIlO0JL3rvCZ848rlPcm8gJUff1Mvp2RanW8MZ1CB7PbsUWigWfUWnVjLQjD+RM825IS8trLYpBq0J7i8pyPhQ2xkZ7S3Mf0OyyNeFFoPJtU9I3bEmh+3fO5UogvVyT9q40PXcxpbH5NNgUQk2rzu+pUDsRf0fElSxVDNrh8SSYt+pTBWV3Sb/xwCp1ZO2SCgD4ulHBmNruQFpt5GsI2Sp8R9Gc2Fajbu5xLVFUEziDWxnmnfhrB4c7ZBgayXaHe8sK6AFf1m3Y4nR6FSQW60PsP4lDFzVpPWqGlgwVo8cGsVCKCcPsfbRD2mXBgjNxdakns0Gh5hpVVdFWr6Dz3+B0Kj7CCRnQYIobn7MxKhuO5G4YUA34tTcY4GjBJ46OGR3PdyRC79o660e1kBzwG1JkrFuoVXkLzvEgsod4mBPjXd3IoFVjOFOHHPBhsPl3k0jAnS955E+NK7Q0S/LJE7z3CVwznH3GetGXItvB02Be4j8BflJvYRsElQkUFrtFelSmD1VZJH+mgdJDriXYE7eRIjra0tytoCpfqDW3DM5A78ngF3yX+yZ27TqKari9Jnlwsy3FHMNIQi41YM7DSNYxzO+DPvQfC7pd3oIy5ALpfTjeWTyiS/6ACztxzlPdjZtu8tPFqbsF0sQl/O4evVojuh06K4MrlgttJW6hjLHcWDA09i5cZECQ+en+FW9mYO8jIfj1xesAntUiOj9CMklhA6HSm91P5P7VX86mDSSiIHHPr2RGP2d1MdT7KnSymtMeBbSebfspgVD7wbGdN/5+hwyexiGzHv6mwOoiN8x6dVURdTF7pI5KuWaE3dfcz166FBnTTRHUw9SkiibjonhlNsWp Dl/xa6bn TxvIEgBjL/SoidXhVUFKcthLXV4zHR0BQNmOp+jNBvnlXG0Yx66Ub8jc2IF3R2XzhaHAc58IN7NeWH2BSd3G2WjcGzUdkiaM3UA1v0Y5sP4OmUJDlSPpFiY6NaoY7RbBNHMg/SVfBD5E1dxaeYmFsOaxzjaYoSGu01zdJqvMT00xsJ+FC3n9F+xKqvw18tkCEQx8OEbwFB3Abp67TidIUonaVysMjNOROJukXW3Zq/TrpRstmCHWf2ms232jJmiEZ+s8LaH5Dqf1w4dLqWBdztL+ugsqqk03RHG9aJ5wn/DohvVaevtWV8aMk0yxTJry3UZHITEedMKkqSNww75uUsTdIeg4DZuYvpf+WBV4Oyv4Ty1hVB0h4dgpT+6CCrb9/37mVJRdqEAY7efsJ2zGrik3a1yO+Bt7MnvISCjxq8Svw9VwYMbXHkHZLzpN49YtpxfNW2HWGHwiRbViLhzLqswZctfgeEOVa8Y8TucjxYVHE5RoAnqTX015FiErgDb0lSsbX+UIolBfFNjJwkch3m+2aKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.04.24 19:18, Matthew Wilcox (Oracle) wrote: > Replace the use of pages with folios. Saves a few calls to > compound_head() and removes some uses of obsolete functions. > > Signed-off-by: Matthew Wilcox (Oracle) > --- [...] > > - if (page_count(page) != > - 1 + page_mapcount(page) + page_has_private(page)) { > + if (folio_ref_count(folio) != > + 1 + folio_mapcount(folio) + folio_test_private(folio)) { > result = SCAN_PAGE_COUNT; Just stumbled over that: page_has_private() would have checked PG_private and PG_private_2. The corresponding replacement would have been folio_has_private(). folio_test_private() only checks PG_private. Are we sure that we no longer have to check PG_private_2 here? pagecache ... so I have no clue :) -- Cheers, David / dhildenb