From: David Hildenbrand <david@redhat.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 7/7] khugepaged: Use a folio throughout hpage_collapse_scan_file()
Date: Mon, 8 Apr 2024 22:07:01 +0200 [thread overview]
Message-ID: <b0466b95-d4ac-4742-a3f5-9d76ff68f090@redhat.com> (raw)
In-Reply-To: <20240403171838.1445826-8-willy@infradead.org>
On 03.04.24 19:18, Matthew Wilcox (Oracle) wrote:
> Replace the use of pages with folios. Saves a few calls to
> compound_head() and removes some uses of obsolete functions.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
[...]
>
> - if (page_count(page) !=
> - 1 + page_mapcount(page) + page_has_private(page)) {
> + if (folio_ref_count(folio) !=
> + 1 + folio_mapcount(folio) + folio_test_private(folio)) {
> result = SCAN_PAGE_COUNT;
Just stumbled over that: page_has_private() would have checked
PG_private and PG_private_2. The corresponding replacement would have
been folio_has_private(). folio_test_private() only checks PG_private.
Are we sure that we no longer have to check PG_private_2 here? pagecache
... so I have no clue :)
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-04-08 20:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 17:18 [PATCH 0/7] khugepaged folio conversions Matthew Wilcox (Oracle)
2024-04-03 17:18 ` [PATCH 1/7] khugepaged: Inline hpage_collapse_alloc_folio() Matthew Wilcox (Oracle)
2024-04-05 21:13 ` Vishal Moola
2024-04-03 17:18 ` [PATCH 2/7] khugepaged: Convert alloc_charge_hpage to alloc_charge_folio Matthew Wilcox (Oracle)
2024-04-05 21:14 ` Vishal Moola
2024-04-07 3:44 ` Matthew Wilcox
2024-04-03 17:18 ` [PATCH 3/7] khugepaged: Remove hpage from collapse_huge_page() Matthew Wilcox (Oracle)
2024-04-05 21:14 ` Vishal Moola
2024-04-03 17:18 ` [PATCH 4/7] khugepaged: Pass a folio to __collapse_huge_page_copy() Matthew Wilcox (Oracle)
2024-04-05 21:19 ` Vishal Moola
2024-04-07 3:46 ` Matthew Wilcox
2024-04-03 17:18 ` [PATCH 5/7] khugepaged: Remove hpage from collapse_file() Matthew Wilcox (Oracle)
2024-04-05 21:19 ` Vishal Moola
2024-04-03 17:18 ` [PATCH 6/7] khugepaged: Use a folio throughout collapse_file() Matthew Wilcox (Oracle)
2024-04-05 21:20 ` Vishal Moola
2024-04-07 3:43 ` Matthew Wilcox
2024-04-03 17:18 ` [PATCH 7/7] khugepaged: Use a folio throughout hpage_collapse_scan_file() Matthew Wilcox (Oracle)
2024-04-05 21:21 ` Vishal Moola
2024-04-08 20:07 ` David Hildenbrand [this message]
2024-04-08 20:28 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0466b95-d4ac-4742-a3f5-9d76ff68f090@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox