linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Ken Chen" <kenchen@google.com>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-mm@kvack.org, libhugetlbfs-devel@lists.sourceforge.net,
	Andy Whitcroft <apw@shadowen.org>, Mel Gorman <mel@skynet.ie>,
	Bill Irwin <bill.irwin@oracle.com>,
	Dave McCracken <dave.mccracken@oracle.com>
Subject: Re: [PATCH 1/5] hugetlb: Account for hugepages as locked_vm
Date: Thu, 13 Sep 2007 22:41:54 -0700	[thread overview]
Message-ID: <b040c32a0709132241t7d464a2x68d1194887cd8e93@mail.gmail.com> (raw)
In-Reply-To: <20070913175905.27074.92434.stgit@kernel>

On 9/13/07, Adam Litke <agl@us.ibm.com> wrote:
> Hugepages allocated to a process are pinned into memory and are not
> reclaimable.  Currently they do not contribute towards the process' locked
> memory.  This patch includes those pages in the process' 'locked_vm' pages.

On x86_64, hugetlb can share page table entry if multiple processes
have their virtual addresses all lined up perfectly.  Because of that,
mm->locked_vm can go negative with this patch depending on the order
of which process fault in hugetlb pages and which one unmaps it last.

Have you checked all user of mm->locked_vm that a negative number
won't trigger unpleasant result?

- Ken

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-09-14  5:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-13 17:58 [PATCH 0/5] [hugetlb] Dynamic huge page pool resizing Adam Litke
2007-09-13 17:59 ` [PATCH 1/5] hugetlb: Account for hugepages as locked_vm Adam Litke
2007-09-14  5:41   ` Ken Chen [this message]
2007-09-14  9:15     ` Mel Gorman
2007-09-13 17:59 ` [PATCH 2/5] hugetlb: Move update_and_free_page Adam Litke
2007-09-13 17:59 ` [PATCH 3/5] hugetlb: Try to grow hugetlb pool for MAP_PRIVATE mappings Adam Litke
2007-09-13 18:06   ` [Libhugetlbfs-devel] " Dave Hansen
2007-09-13 20:21     ` Adam Litke
2007-09-14  5:46       ` David Gibson
2007-09-14 13:33         ` Adam Litke
2007-09-13 17:59 ` [PATCH 4/5] hugetlb: Try to grow hugetlb pool for MAP_SHARED mappings Adam Litke
2007-09-13 22:24   ` Dave McCracken
2007-09-14 14:03     ` Adam Litke
2007-09-13 17:59 ` [PATCH 5/5] hugetlb: Add hugetlb_dynamic_pool sysctl Adam Litke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b040c32a0709132241t7d464a2x68d1194887cd8e93@mail.gmail.com \
    --to=kenchen@google.com \
    --cc=agl@us.ibm.com \
    --cc=apw@shadowen.org \
    --cc=bill.irwin@oracle.com \
    --cc=dave.mccracken@oracle.com \
    --cc=libhugetlbfs-devel@lists.sourceforge.net \
    --cc=linux-mm@kvack.org \
    --cc=mel@skynet.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox