From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zps19.corp.google.com (zps19.corp.google.com [172.25.146.19]) by smtp-out.google.com with ESMTP id l6H01WVZ019074 for ; Mon, 16 Jul 2007 17:01:32 -0700 Received: from an-out-0708.google.com (andd11.prod.google.com [10.100.30.11]) by zps19.corp.google.com with ESMTP id l6H01Vn3008529 for ; Mon, 16 Jul 2007 17:01:31 -0700 Received: by an-out-0708.google.com with SMTP id d11so391690and for ; Mon, 16 Jul 2007 17:01:31 -0700 (PDT) Message-ID: Date: Mon, 16 Jul 2007 17:01:31 -0700 From: "Ken Chen" Subject: Re: [patch] fix periodic superblock dirty inode flushing In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070712120519.8a7241dd.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: linux-mm@kvack.org List-ID: On 7/13/07, Ken Chen wrote: > On 7/12/07, Andrew Morton wrote: > > Was this tested in combination with check_dirty_inode_list.patch, > > to make sure that the time-orderedness is being retained? > > I think I tested with the debug patch. And just to be sure, I ran the > test again with the time-order check in place. It passed the test. I ran some more tests over the weekend with the debug turned on. There are a few fall out that the order-ness of sb-s_dirty is corrupted. We probably should drop this patch until I figure out a real solution to this. One idea is to use rb-tree for sorting and use a in-tree dummy node as a tree iterator. Do you think that will work better? I will hack on that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org