From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zps78.corp.google.com (zps78.corp.google.com [172.25.146.78]) by smtp-out.google.com with ESMTP id l2NM4nYC026837 for ; Fri, 23 Mar 2007 15:04:49 -0700 Received: from an-out-0708.google.com (andd31.prod.google.com [10.100.30.31]) by zps78.corp.google.com with ESMTP id l2NM4Gww026563 for ; Fri, 23 Mar 2007 15:04:33 -0700 Received: by an-out-0708.google.com with SMTP id d31so976450and for ; Fri, 23 Mar 2007 15:04:33 -0700 (PDT) Message-ID: Date: Fri, 23 Mar 2007 15:04:33 -0700 From: "Ken Chen" Subject: Re: [patch] rfc: introduce /dev/hugetlb In-Reply-To: <20070323153006.GW2986@holomorphy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070323150924.GV2986@holomorphy.com> <20070323153006.GW2986@holomorphy.com> Sender: owner-linux-mm@kvack.org Return-Path: To: William Lee Irwin III Cc: Mel Gorman , Adam Litke , Andrew Morton , Arjan van de Ven , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Benjamin Herrenschmidt List-ID: On 3/23/07, William Lee Irwin III wrote: > On Fri, 23 Mar 2007, William Lee Irwin III wrote: > >> Lack of compiletesting beyond x86-64 in all probability. > > On Fri, Mar 23, 2007 at 03:15:55PM +0000, Mel Gorman wrote: > > Ok, this will go kablamo on Power then even if it compiles. I don't > > consider it a fundamental problem though. For the purposes of an RFC, it's > > grand and something that can be worked with. > > He needs to un-#ifdef the prototype (which he already does), but he > needs to leave the definition under #ifdef while removing the static > qualifier. A relatively minor fixup. Yes, sorry about that for lack of access to non-x86-64 machines. I needed to move the function prototype to hugetlb.h and evidently removed the #ifdef by mistake. I'm not going to touch this in my next clean up patch, instead I will just declare char specific file_operations struct in hugetlbfs and then have char device reference it. But nevertheless, hugetlb_get_unmapped_area function prototype better be in a header file somewhere. - Ken -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org