From: "Ken Chen" <kenchen@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Subject: Re: hugetlb: preserve hugetlb pte dirty state
Date: Tue, 6 Feb 2007 16:47:21 -0800 [thread overview]
Message-ID: <b040c32a0702061647k33c3354csc5d6b28ef3a102f7@mail.gmail.com> (raw)
In-Reply-To: <20070206163531.8d524171.akpm@linux-foundation.org>
On 2/6/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > --- ./mm/hugetlb.c.orig 2007-02-06 08:28:33.000000000 -0800
> > +++ ./mm/hugetlb.c 2007-02-06 08:29:47.000000000 -0800
> > @@ -389,6 +389,8 @@
> > continue;
> >
> > page = pte_page(pte);
> > + if (pte_dirty(pte))
> > + set_page_dirty(page);
> > list_add(&page->lru, &page_list);
> > }
> > spin_unlock(&mm->page_table_lock);
>
> I guess we really should be setting these pages dirty at fault-time, as we're
> now doing with regular pages.
yeah, I wonder why I didn't do that :-P Especially after I asked you
a similar question the other day. I will redo it and retest.
- Ken
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-02-07 0:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 21:06 Ken Chen
2007-02-06 21:36 ` Nish Aravamudan
2007-02-06 21:43 ` Ken Chen
2007-02-07 0:35 ` Andrew Morton
2007-02-07 0:47 ` Ken Chen [this message]
2007-02-07 1:08 ` Andrew Morton
2007-02-07 1:22 ` Ken Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b040c32a0702061647k33c3354csc5d6b28ef3a102f7@mail.gmail.com \
--to=kenchen@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox