From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CAE0CE7A94 for ; Mon, 25 Sep 2023 11:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 346408D0020; Mon, 25 Sep 2023 07:32:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F6978D0001; Mon, 25 Sep 2023 07:32:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E4CD8D0020; Mon, 25 Sep 2023 07:32:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0F8038D0001 for ; Mon, 25 Sep 2023 07:32:07 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 61CCDC0C13 for ; Mon, 25 Sep 2023 11:32:06 +0000 (UTC) X-FDA: 81274905852.27.77A20C6 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf21.hostedemail.com (Postfix) with ESMTP id 728C61C0014 for ; Mon, 25 Sep 2023 11:32:02 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695641524; a=rsa-sha256; cv=none; b=13eviWlbxb5atFjIR0lh1FiO34PmnqmLXy71gpKBqZcnlQQ5ou3mFYxhM7BgEbfsVX39o9 Scsq2uF3kXLG+z/+2zTBFtnX4dyUXP51dk0y2CAUksnPiNPK6MgLlFKZ5FB1gUlG4KblNy NMLasOnKTQlbpHlHorSg8wJV9m50mC4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695641524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eBteDN3wkuDebYxWfNNZSQFA1lvQsnIEGTsZrk1APww=; b=KRLvWV/1plWLJ57YOHL5iNqPYmGQunnYK/vhOwOQ7Kv4ysTpbXKJI9NyAaN4lJm/MMQiPN GhDOXudp/Xt7+hZBqbNAF59NEpRIs3wRhbueHf7eYjSBcZHFJmjTDGaAu/w7RyjNLfkOMt Q7BwsIcYc+bfJc1r92js5GrkKdEMNKg= Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RvLFz4vpqzNnnZ; Mon, 25 Sep 2023 19:27:51 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 25 Sep 2023 19:31:40 +0800 Subject: Re: [PATCH net-next v8 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA To: Ilias Apalodimas CC: Jesper Dangaard Brouer , , , , , , , Lorenzo Bianconi , Alexander Duyck , Liang Chen , Alexander Lobakin , Guillaume Tucker , Jesper Dangaard Brouer , Eric Dumazet , Linux-MM , Matthew Wilcox , Mel Gorman References: <20230912083126.65484-1-linyunsheng@huawei.com> <20230912083126.65484-2-linyunsheng@huawei.com> <84282e55-519c-0e17-30c5-b6de54d1001c@redhat.com> <15f95505-dba9-4afd-6980-5bdf0a64d507@huawei.com> From: Yunsheng Lin Message-ID: Date: Mon, 25 Sep 2023 19:31:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 728C61C0014 X-Stat-Signature: 4ku4fnmsmjujgzonzf8iip8nhkxmcmwa X-Rspam-User: X-HE-Tag: 1695641522-907050 X-HE-Meta: U2FsdGVkX1+XochGaSS7xl4tkE+nWmnuuYuLqTaVME3SLRRZL1xfXiam3E3zVviP33U1FyLaEaPm1YIiVpF918twkGJsu4EvRx5WerxdHbZpR1kyPIWXm/z9vlwxpqjZCnp9XR9yqufEkPIJULYJzDCZzWbqzGXFbPi0NJ5MBQbLqBgnfN3S07EHUiUb/Koqw3BV95Xkk4g7wrA45/Rp5YRVNKiOW2XIuFNyiIkqJ5ksSKL7XVmdzmzKKt8DeB93bDSRoDvxufL9XNlMowOQjTUeEhOVfaV0T3j9/PI0g7jkOEgnwnkKMo+aOBHlGFyoGBfHP7HNF+MkVj21LlAb6B8AoXlhsj81Mp+AG4oupm7NbtSDP7OjOtxmrkZvdyR4qsG6KnyC0mlwGawGtBQUy4cXB6miJuryay3Xuo3gRyw1xnTEJhGwWXvdbTKfIHDDgXD0CPwRVmh2I5FNZOSmGvr4xQ2cV3Zic44cbryG1yL2FFL6AbCa/z0FoVk+xrBNsdwhsjIAKhzR5TclbmuwCb6UOj29MngAC1X74jKrWijK0iaS0WJqhr7NAzGQ7DhKWdDiaolSbEufdaRBtW7VUVSdikxA8QLm06ukAFQkkL+eEUzwrWYI3o4WCAlbKpTjEQU2Dgrhwp9OAY5A1WM8QQoSMaM5ivjAtuo2vbbGEofKqbWd2Z5jFlRAZ+lyJZEd0G47WB285DLpJxTexgkHz+Ektm0lW0WH1sDDKhWiAe3qKOLo+sNjcWfsYhlEiQKIhjPuDYBfX0VAMYjW+elVOF+c5sg2AhzCVXCrJbHsm6VmWFXFdDQxhI8a3EEULjjwkjkhzHQX0346aUenziemJ1LsMrAaX9RvQ5+lA13r7unNwnZ50N5uibYW6CehUyJZJCCx2Q+SguJBPRIS6VXJbYhUDfN0EwcR1tuCb9E0aBdL8wf3WVxx8s7yPT6cred9O4j2fEPiXGV1eLL/eB8 1NeBELzl dyNhZF5is07zi1wRLLIWSlCxqlZAvc/k1RpRSDs6+zGhi1I9SBshvpoRmyEAXLsA1BDNGwL3xY2LSOw7fTFebF05nVP83DJkKu/a5+DyRCdzxZUsPRmLPJk1pi+IxY78f2AI1YXt2+JlztAcLEvg9cyfwWhE+4L/BnxjBk1trNVvGd28+XGqvhpwfgG1DQwh7bGuwoIM8Ee5q0SS+KgriAEn5e8y8NuuzYAA8u5lJY65kEf6D4+FRJ+msEwqlq1q11Ejhl/GmLj+h92OKkpNm5HGY9YuMcBDdq+Ajzrg2LEb5geLxur5J1Mc0UX10dnooc6Fhj2pite2OXJlG9uzIEVJCVxCim3PaelLC0CAMBoIVnqFpB58MbILdNfaY+Zi680BgliScH0cXW8+nUCApt+9AxicFayOIWhN/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/25 18:37, Ilias Apalodimas wrote: > Hi > > On Wed, 20 Sept 2023 at 11:59, Yunsheng Lin wrote: >> >> On 2023/9/15 16:28, Jesper Dangaard Brouer wrote: >>> Hi Lin, >>> >>> This looks reasonable, but given you are changing struct-page >>> (include/linux/mm_types.h) we need to MM-list . >>> Also Cc Wilcox. >>> >>> I think it was Ilias and Duyck that validated the assumptions, last time >>> this patch was discussed. Thus I want to see their review before this is >>> applied. >> >> FWIW, PAGE_SIZE aligned buffer being PAGE_SIZE aligned in DMA is >> validated by Duyck: >> https://lore.kernel.org/all/CAKgT0UfeUAUQpEffxnkc+gzXsjOrHkuMgxU_Aw0VXSJYKzaovQ@mail.gmail.com/ >> >> And I had done researching to find out there seems to be no combination of >> the above arch with an address space >16TB: >> https://lore.kernel.org/all/2b570282-24f8-f23b-1ff7-ad836794baa9@huawei.com/ > > Apologies for the late reply. I just saw you sent a v9, I'll review > that instead, but I am traveling right now, will take a while Actually there is a newer v10, see: https://lore.kernel.org/all/20230922091138.18014-2-linyunsheng@huawei.com/ Thanks for the time reviewing. > > Thanks > /Ilias