From: Yunsheng Lin <linyunsheng@huawei.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Jesper Dangaard Brouer <jbrouer@redhat.com>,
<davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<brouer@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>,
Liang Chen <liangchen.linux@gmail.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Guillaume Tucker <guillaume.tucker@collabora.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Eric Dumazet <edumazet@google.com>, Linux-MM <linux-mm@kvack.org>,
Matthew Wilcox <willy@infradead.org>,
Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [PATCH net-next v8 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA
Date: Mon, 25 Sep 2023 19:31:39 +0800 [thread overview]
Message-ID: <b0388db7-d4b2-443b-12f0-fbe6ae4002cd@huawei.com> (raw)
In-Reply-To: <CAC_iWjL_u=R+UK-6rhnv=32qX2P9SY72LFu928Y64u11EVoOPQ@mail.gmail.com>
On 2023/9/25 18:37, Ilias Apalodimas wrote:
> Hi
>
> On Wed, 20 Sept 2023 at 11:59, Yunsheng Lin <linyunsheng@huawei.com> wrote:
>>
>> On 2023/9/15 16:28, Jesper Dangaard Brouer wrote:
>>> Hi Lin,
>>>
>>> This looks reasonable, but given you are changing struct-page
>>> (include/linux/mm_types.h) we need to MM-list <linux-mm@kvack.org>.
>>> Also Cc Wilcox.
>>>
>>> I think it was Ilias and Duyck that validated the assumptions, last time
>>> this patch was discussed. Thus I want to see their review before this is
>>> applied.
>>
>> FWIW, PAGE_SIZE aligned buffer being PAGE_SIZE aligned in DMA is
>> validated by Duyck:
>> https://lore.kernel.org/all/CAKgT0UfeUAUQpEffxnkc+gzXsjOrHkuMgxU_Aw0VXSJYKzaovQ@mail.gmail.com/
>>
>> And I had done researching to find out there seems to be no combination of
>> the above arch with an address space >16TB:
>> https://lore.kernel.org/all/2b570282-24f8-f23b-1ff7-ad836794baa9@huawei.com/
>
> Apologies for the late reply. I just saw you sent a v9, I'll review
> that instead, but I am traveling right now, will take a while
Actually there is a newer v10, see:
https://lore.kernel.org/all/20230922091138.18014-2-linyunsheng@huawei.com/
Thanks for the time reviewing.
>
> Thanks
> /Ilias
prev parent reply other threads:[~2023-09-25 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230912083126.65484-1-linyunsheng@huawei.com>
[not found] ` <20230912083126.65484-2-linyunsheng@huawei.com>
2023-09-15 8:28 ` Jesper Dangaard Brouer
2023-09-20 8:59 ` Yunsheng Lin
2023-09-25 10:37 ` Ilias Apalodimas
2023-09-25 11:31 ` Yunsheng Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0388db7-d4b2-443b-12f0-fbe6ae4002cd@huawei.com \
--to=linyunsheng@huawei.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guillaume.tucker@collabora.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jbrouer@redhat.com \
--cc=kuba@kernel.org \
--cc=liangchen.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox