From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D19C369D5 for ; Mon, 28 Apr 2025 14:05:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F18566B00A9; Mon, 28 Apr 2025 10:04:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC80D6B00AC; Mon, 28 Apr 2025 10:04:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1CBD6B00AD; Mon, 28 Apr 2025 10:04:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B36496B00A9 for ; Mon, 28 Apr 2025 10:04:58 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9B05F801C4 for ; Mon, 28 Apr 2025 14:05:00 +0000 (UTC) X-FDA: 83383623960.27.DD8F8B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 0FDDB14001C for ; Mon, 28 Apr 2025 14:04:57 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Eh7x8fC3; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745849098; a=rsa-sha256; cv=none; b=7ka2u5Qj48IjdBqqgPyKh9D818Lp1UzcZ2BOV7Jpw/1IEShu+lEt4osVCBKpEPztsX5a78 dHxHATeSu+62gn2jSWBkmrg0yL6501WtvBJG8lc6R3JtQD8iPsyZYlsnXaxGvONGdXhLjj huJ/W9QwOr7hcqOb78w+Ys70koHMlNc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Eh7x8fC3; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745849098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LCPqXznOEi2VAzafxyWUGGwRnIkn4pZb5EHsf0ONcRo=; b=H4zNg3VgNoi+C5FqU3SHR7KSRtpCJejFQAuF/IsvErjiDTt+yUzKSJuMv2EdHe1fhQWOqi o0XopbaEbebhEgwu/23prhYH3GByqnRveE9YY2eVzD3UV63SsS4PGKP6oDZvvMAeloe1nH nnKfCWa5V0I4cJQRj5Uautu6hT2RvtQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745849097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LCPqXznOEi2VAzafxyWUGGwRnIkn4pZb5EHsf0ONcRo=; b=Eh7x8fC3Qr1BjdwlgL/Cp+DlOwyR1Ea4rVV8J3RmJDqtXQXgXhJzyG4qjFgjFe6LwkhqQH gElVjLzpMCJpBa0JB1quPPAMz7Ey24P3NGE6XqRcMcxllhpXTR/X1Tob+LdSBFdSWCgvvA Fj9x85M0TqYub6c2xOHatzS0cLh5lSA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-D8gZk2QXNlOoSdwHuX5PPQ-1; Mon, 28 Apr 2025 10:04:54 -0400 X-MC-Unique: D8gZk2QXNlOoSdwHuX5PPQ-1 X-Mimecast-MFC-AGG-ID: D8gZk2QXNlOoSdwHuX5PPQ_1745849093 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d5ca7c86aso28373315e9.0 for ; Mon, 28 Apr 2025 07:04:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745849093; x=1746453893; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LCPqXznOEi2VAzafxyWUGGwRnIkn4pZb5EHsf0ONcRo=; b=OZT82vinKZFI80KHgbOum/RVJp0mp9kOXaDkJBy6RTTi7a4116bWQEKB+F9dpqxQUB 5EtOKV/WEKHGfJjg3pnJtbF8wd9/yzCslWCAFrFg7O8CvhkRXHt5NstiGOsB6NPIZVJc lxXrtotHpqhIn3oA6/CEmI26g+7X0lwW8I8LGgyTV9WrDUUIyHjbSn9fZvoFsRHojcb8 H7YZXQ2l1G8nE4cbMSk328ECqp52JDy0XK4csaffy5dPdjNrxafzuYKnTZCZGVR/GKPC tbKJrfznctUiXn5eNhY06mEIchEgL1pmjRyPVDv0ecxKEYY1PpvJFyHgbc6J3FUBtEz8 kwNg== X-Forwarded-Encrypted: i=1; AJvYcCWr9+4/nnbjhUycVnnD9UXme05G9sj63AuptC/Ky5ANO5evtGFjompZyKunX4XzEgeqdVENgLInOg==@kvack.org X-Gm-Message-State: AOJu0YzLDDnpz256b4pK7sMmDSJpPaA7Jco4GNCTr/VZzTG13ZHMuPuz V4Euo7haT308hvFhyB60OPDKFAAW28O+RA2PiHmxHHJN0zTvcKsnh7jT2tsvvBvQEDpB+cSEby5 faMpMWSJjyfdxTfMhlB9zqhnfrMk/tw8tv/Pz6Lzo40mEQg00 X-Gm-Gg: ASbGnctrX9VBo877m0br0S2nJPG0Z1+S7r+dLrkz6nfQSTR4p0RpcV8y0RVWpXO/NS8 OlR7NyvzFn+2hPqGuH/eKu/M6mTbdjFPJa9eD1oi7A1ff7oKQzcPw5N8uPCnamwmrKZ1JgAybz5 h6qqGQL2RAC35QRsOMY2wCDeIcrTdGpXuEZ3OAowJXT5KyqLeo98+0MJfUBb5kmlXpra4hHUh2h uICoK8vNLwMfGAz7pDNMxBqO+8NaovsHfI4j5PvBatakl4Dqk7UBBCKg89/VBdQQwAa3h+dBVkJ eh3u+3yEJ5IhwfgIaqrNtphyI6dXUKiqhUH+HpZFGolP/JkdOVReNLuG0ANcb82cD16qNXv4tkO ddZEPBj8Rcgcc9rlLNR3VFwSAkBXJ8wigK5Cw+qA= X-Received: by 2002:a05:600c:3b9d:b0:43d:7588:66a5 with SMTP id 5b1f17b1804b1-440a66b08a0mr102610385e9.31.1745849092828; Mon, 28 Apr 2025 07:04:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJK4O2qWL0SIQ2GwqZNkaVAJoiBY3Z6hHfmUxMrilkaARu1MUCIpMtD7Rr7FPbch96+oAUlQ== X-Received: by 2002:a05:600c:3b9d:b0:43d:7588:66a5 with SMTP id 5b1f17b1804b1-440a66b08a0mr102609685e9.31.1745849092294; Mon, 28 Apr 2025 07:04:52 -0700 (PDT) Received: from ?IPV6:2003:d8:2f32:c200:9add:4a7a:46aa:f740? (p200300d82f32c2009add4a7a46aaf740.dip0.t-ipconnect.de. [2003:d8:2f32:c200:9add:4a7a:46aa:f740]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a5394bfasm126622875e9.40.2025.04.28.07.04.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 07:04:51 -0700 (PDT) Message-ID: Date: Mon, 28 Apr 2025 16:04:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: SNP guest crash in memblock with unaccepted memory To: Tom Lendacky , "Kirill A. Shutemov" Cc: Andrew Morton , Mike Rapoport , Vlastimil Babka , Mel Gorman , "Kalra, Ashish" , Rick Edgecombe , linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Roth References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DC6uUOvn45EbHRD3R6HpUOQX-pjEo1-Ty8GpmmpB7EM_1745849093 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0FDDB14001C X-Stat-Signature: 1j8w8u5ufs1xmnbig8z8615i6kakzqhn X-Rspam-User: X-HE-Tag: 1745849097-19438 X-HE-Meta: U2FsdGVkX18R23anUKQah//N35J482vUcS5MDgpSbk+Y2KfbZtBnzkzJHX3TwGS61GWJ3jK39+eGDIrdn9gWlSKU5j5kX5boSbo1NoMIr7XeImibcH0yLkOtbcdKC2nLoOAdBd1IiTbJqsBKiHSa2ACGMqgya/v5S2JJYtdn0feS5nMAfC4KOS7UG3eWrziyzKFzaHo54goZjnYpAH6+/Z/gVaHNkl7YHkzOBaQYmw6Cw60L9AVMNGfZZXRaMCo8oOZHCJ0qfFrliQ7ggY+ghqFEwj7nNhnjr8bttAuaMnTS71ilV6n5bnWrqgvEU2YbCZA8Bpw4Usk5+Rknzdic/FIJbX7t1grp+9kCWrhD8L3t+Zz0Hw+WEsByF7FLkohiHr49Q5+3yRLiazO+67s2DTRZgCPDj1V3iSr+HraKWaRGKZsuIhk4U5RD/xnGqTMuBJjsXzU4gmdA12HHKVbABYq0R7hcV7viuqT9KigwBsUhtMt9lmqdT/Y8GHZ3MP+JCPb6x3pYvhPCpvI8Ffg0Fvk3pDCx4X/py0HQNbcYljzfWmDgWgcC32JZkDslNwRosbX6LPzUuTF4sCTA9Pjiu4f8/2IU5cUt9ixi/wUZKDlNGuXUfvEDyQ0YV9fcS1biXETPH0IO8tB6naSxbULby2vcF7xWjGAQTEyuatNJihZof1IPE5uJXhWbmIc4Bn4NRufptn/Yzd2KOR6hvY1Am8QJHqnG9UFME8RBYHwbQ4LicARw4wABV3ApmCQRoD0DgVUVKWC/J5TrzNeV9iqjPDDx2B3dmnyWTLBKNv5CO8U78cvVjbR+fVr9NN3W0A3l3Zg81zCgj6HlWzOzwdlSNfb97AQ1FYK7gclqCiBHrinnQNgo547H44qrVX8FCYkWib0//BX2kzlcoCZQp5nmMV/0w9JEs+548svE2f62eR5ESWGt7raVA9tXx725OkF1dakhTgbOdJ1IT4tly8e MsYENATY /AlKsLe3GCKd97lMpHPIFIPXD+PJnzJiHzFWovrab2Rnon98HySwcPFcYCBwSbcOEDbw3uVhbig2uuLM/B9oZd8aLD9W0krHwtJVe8q0SUQ9pze+cCWiUxv6v+bqCEQiMvD3wWQwFOlI/fBaNKcK5l0IEewnrAUWyUkJpj14STxFdXxYF3LCon4jL5OsvQqQkf0DXM8Po50OTCrVIbSESEa2pBlYB+psPFcyirCX53EnFGBBcRG8LHyuSFyMDlkvPWvFZ7i3eBYvymcVZl3V8I8WCyH1eEeP8zYBFpVmwtWsp6jNaVaCjX4feK230GGWuO70uevc6RVMsoEKEIvpwAR8SPnig64zqtPg9JXQdQWzqWoluhum9S6y0vdy7e9gmR3Ad/88GG55Xr2iOOgADLiDArZyCPVvASyFrevQ/9Yb4SUkuE1MzTsO051lyClnJqrpOqIuGHISg4/0ZDlUGTTAWuRitt6J78RrwJeNmc9WfXBx/hAsk8eNakQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.04.25 17:01, Tom Lendacky wrote: > Hi Kirill, > > Every now and then I experience an SNP guest boot failure for accessing > memory that hasn't been accepted. I managed to get a back trace: > > RIP: 0010:memcpy_orig+0x68/0x130 > Code: ... > RSP: 0000:ffffffff9cc03ce8 EFLAGS: 00010006 > RAX: ff11001ff83e5000 RBX: 0000000000000000 RCX: fffffffffffff000 > RDX: 0000000000000bc0 RSI: ffffffff9dba8860 RDI: ff11001ff83e5c00 > RBP: 0000000000002000 R08: 0000000000000000 R09: 0000000000002000 > R10: 000000207fffe000 R11: 0000040000000000 R12: ffffffff9d06ef78 > R13: ff11001ff83e5000 R14: ffffffff9dba7c60 R15: 0000000000000c00 > memblock_double_array+0xff/0x310 > memblock_add_range+0x1fb/0x2f0 > memblock_reserve+0x4f/0xa0 > memblock_alloc_range_nid+0xac/0x130 > memblock_alloc_internal+0x53/0xc0 > memblock_alloc_try_nid+0x3d/0xa0 > swiotlb_init_remap+0x149/0x2f0 > mem_init+0xb/0xb0 > mm_core_init+0x8f/0x350 > start_kernel+0x17e/0x5d0 > x86_64_start_reservations+0x14/0x30 > x86_64_start_kernel+0x92/0xa0 > secondary_startup_64_no_verify+0x194/0x19b > > I don't know a lot about memblock, but it appears that it needs to > allocate more memory for it's regions array and returns a range of memory > that hasn't been accepted. When the memcpy() runs, the SNP guest gets a > #VC 0x404 because of this. > > Do you think it is as simple as calling accept_memory() on the memory > range returned from memblock_find_in_range() in memblock_double_array()? (not Kirill, but replying :) ) Yeah, we seem to be effectively allocating memory from memblock ("from ourselves") without considering that memory must be accepted first. accept_memory() on the new memory (in case of !slab) should be the right thing to do. -- Cheers, David / dhildenb