From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00420C3DA63 for ; Thu, 25 Jul 2024 01:01:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 141056B0083; Wed, 24 Jul 2024 21:01:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F16A6B0085; Wed, 24 Jul 2024 21:01:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F05E66B0088; Wed, 24 Jul 2024 21:01:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CB7CD6B0083 for ; Wed, 24 Jul 2024 21:01:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 870DF1A0752 for ; Thu, 25 Jul 2024 01:01:01 +0000 (UTC) X-FDA: 82376470722.26.F93E6A2 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf18.hostedemail.com (Postfix) with ESMTP id 4B2851C002E for ; Thu, 25 Jul 2024 01:00:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721869235; a=rsa-sha256; cv=none; b=V9qL2LIU4MW7NXYjq0n2ovZVDoftl5yrA2vFLAShYAjGisQlsoit6zBLvJjiaZexJRu6EX 6jZxR3vjzN0xqNLlvg1kEm5Z3XUgSQC7hgQntqgizfv1wfVcYaZs8n6/aOzsrzyANTeXsd i2nO+OS9u6WXMz2PdggbilFWx11T9AM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721869235; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lTjHZeMR/Cj+TyVLqOJTwjwFUvEgK3Zxq1b9a7P8h4w=; b=V4gZ8ujSZDGEzksp9Pu5dkO/VvVSlGGLb2ENg+tmenIpoDU72xoeADFBu/hKjE1oN3YsIN AYbYF4ciFyXrlBpc1EFlPpApTx2Sc89n8zCbMo9io8YvHXe5G8cPZU91QfSiLuCGdiF7D4 bbtag6X/VJDucAc74CNvUUm6RBFaPTE= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WTsxH5YbjznbfC; Thu, 25 Jul 2024 09:00:03 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 7A9F2180087; Thu, 25 Jul 2024 09:00:53 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 25 Jul 2024 09:00:52 +0800 Message-ID: Date: Thu, 25 Jul 2024 09:00:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] memory tiering: count PGPROMOTE_SUCCESS when mem tiering is enabled. Content-Language: en-US To: Zi Yan , Andrew Morton , CC: David Hildenbrand , "Huang, Ying" , Baolin Wang , Lorenzo Stoakes , References: <20240724130115.793641-1-ziy@nvidia.com> <20240724130115.793641-4-ziy@nvidia.com> From: Kefeng Wang In-Reply-To: <20240724130115.793641-4-ziy@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf100008.china.huawei.com (7.185.36.138) X-Stat-Signature: 3dscx8fy155dnsdp1t5dnyyqak9kuuoc X-Rspamd-Queue-Id: 4B2851C002E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721869257-620165 X-HE-Meta: U2FsdGVkX1+idw0M9hUjfy5UlKYrnazl/K95XG5F0iwAIQ7l3CqmJcL9xHCP3yBIGrxSjjwzM7IQKJqDoQ2c4QgutRWRRoOT1sjFfhBTgZ/MUUaEAvI6Qq//L90zWItA2OLaRFujMCmoQ7d1apN41cC6pVHdETtESdjCOgfk/qGFIeGUaI6LbwYZhjGez1sKXUZJLxLtWALLXyjqf+JrR5QawIUbsoMFlWZ3stAHuhYfPav65hT3ugc2pk7qIgkzG6D8JMuIgC7EaQvarMCkaxbfK3aGF4Y4PgdC0i4l2zdc1hxiDKZPLwygixPr7RFECyt4Jn0WH8+nBvNZalMdddLojLpCRaEcU9e2z6scwPWyrfvVZStEJo8c9HxJWZYvAUOiz7pTiKWVSbggYQvYKDvwMQkDMjZhttWNxtxYnq7CjnUBwcCGiP3szWtDic7yqCWldZnmHNkCo76VbIWYPURzG7AUB2ZVo68vBJR6oGwJrvNhSKUS0VODX/KMrR3jSRd8KxB4kuTuqM5I9lKhIMoVuGa8MEo4Phg9s8kL0Df/9CXLYapaeU3I7O2JRaItqHfskwuJXgNyzdOMeq29yWNaN0pJ7VXYMj6Tslt7Z7V5wX6uubiaituXBh3daXtXkY4XU250qaroodQEfX4zH1aCnnjtVvMu/bcPQQRYmSESsH9H67FY/n0zCAqKpqxHw1kOo2o/vxXMgCntyX1BoB1m/X1dFbTDGkBSYGWpTm67rB7e6LAKDzWgvH1kf1X1POYBCQbVim1dPNlm983GdcuqGsMAePgznKXCANLwmXxGglwhhJE6hTmnKqxNCT8jcjnqtWXr0ahOnZR6Gt2pYYbMSH47qWRgAFwdpGyYJtPA9Z4enk+SxqJtof8XfPouqWZP1Bm6qgCbRkAvfyqhC8zXuh6eLH5ZwGpIhnZcT0ymqmBUBfP/+ydSSmMWoTAV9P6jD46+Drtd2H121DC l08+Ay+c rAhbs+hCFgR6xKNZWH1hKl/ocK+hwYDUN+tk80+etdE1mWGSWUWT3SvR9eseEh71Ky8Chm16W0OO8HAMLfhe3YWJV0KA0etvWE0T3nwAtoT3QfJRwrm5l4qmAp/foa6ZVsGYDbcYdZPJsrZrAl3NL+xiWlf5hfQ57yuXTMqPwNx+9KZWmlAmywZdanc+oTsuOyoMv46zxt/PAxh+uITWjemh7MgP6r/TsDH50YoIbQR6eGclwLznY8psPg7S80KMrfD26Lf4TFsDWFxYuR7jKbGwRvcYcqQmb6RCBp1ZbNaJrcM3bKyugJRrKB6djED9dGbxA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/24 21:01, Zi Yan wrote: > memory tiering can be enabled/disabled at runtime and > sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING is used to check > it. In migrate_misplaced_folio(), the check is missing when > PGPROMOTE_SUCCESS is incremented. Add the missing check. > > Reported-by: Kefeng Wang > Closes: https://lore.kernel.org/linux-mm/f4ae2c9c-fe40-4807-bdb2-64cf2d716c1a@huawei.com/ > Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") > Signed-off-by: Zi Yan Reviewed-by: Kefeng Wang > --- > mm/migrate.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index e7296c0fb5d5..826afb82ca56 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2630,7 +2630,9 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, > putback_movable_pages(&migratepages); > if (nr_succeeded) { > count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); > - if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node)) > + if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) > + && !node_is_toptier(folio_nid(folio)) > + && node_is_toptier(node)) > mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, > nr_succeeded); > }